Repository navigation
Conversation
…ly group Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — moves the GStreamer catalog bench into the existing rust-extra group, so it keeps its label and paired comparison and rust-bench returns inside its 55-minute budget.
Reviewed changes
Reviewed the full diff of both files.
sh/gh/nightly.sh—criterion gst -p moq-gst --bench catalogmoves fromrust-benchtorust-extra, aftermsf'scatalogbench, and the comment about the shared target name moves with it.sh/gh/nightly.test.py—rust-benchnow expects 3 release invocations ending in kio. The failed-build test's last call is updated to match.test_every_cargo_bench_target_runs_nightlystill coversmoq-gst.
I found no other references to the old placement in sh/gh or .github.
claude-sonnet-5-5 | 𝕏

Problem
Nightly's Rust bench targets job has failed at its 55-minute
Run workloadtimeout every night since at least 2026-11-16, andmoq-gst's catalog bench, which runs last in that group, never ran. Because it never finished, no night kept its executable as the next night's base, so each night has to build the base from source.moq-net/auth,moq-net/publisher, andmoq-net/session. Those hangs were already fixed onmainby moq-dev/moq#9039 and the commits around it, and they did not recur in run 44562804083 (job 135696388596).rust-benchfinishedmoq-net, its CPU clock,kio, and their confirmation rounds at minute 43.5. Thegsthead build took 7m21s on a cold cache, and the step timed out while the base was building from source (No kept base executable ... building the base).The suite outgrew the budget.
gstcosts about 16 minutes with no kept base and about 9 with one, and either amount pushesrust-bench(43.5 min without it) past 55 minutes.Approach
Move
criterion gst -p moq-gst --bench catalogfromrust-benchtorust-extra("Rust supplemental benchmarks"), still under its own label, next tomsf's same-namedcatalogbench. Same dev shell, same paired comparison.Budget from the 2026-11-19 run (55-minute workload step each):
rust-benchgst)rust-extraOnce a night keeps
gst's executable,rust-extradrops to about 38 minutes.Validation
python3 sh/gh/nightly.test.py: 22 tests pass, includingtest_every_cargo_bench_target_runs_nightly(moq-gstis still covered).cargo bench -p moq-gst --bench catalog -- --testin the dev shell: all 9 cases pass. The bench hadn't run in Nightly for days, so I checked it still works.rust-bench) and 135696388603 (rust-extra) in run 44562804083.just checkpasses.Caused by
No single PR:
gsthas run last inrust-benchsince moq-dev/moq#5759, and the group grew past its budget over many bench additions plus the paired base run.Impact
None: CI layout only. No public API or wire change.
Alternatives
timeout-minutes: 60caps it, and the cold-cache build cost would stay in the critical path.gsttorust-relay(about 16 minutes of work): more headroom, but that job is the relay session suite.moq-netacross two jobs: a bigger change than one 9 to 16 minute target needs.Follow-ups
Models
Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort
(Written by Opus 5.5)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 742ed46
Base: origin/main at 1471225
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1f4e4-32ba-7ea0-9975-655f9d43529a, round 1Score: 10/10,
The benchmark moves to another existing Nightly group without losing coverage, and the updated assertions reflect that move; source inspection found no actionable defects, with tests intentionally not run.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none