Repository navigation
Conversation
…leted Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. The three steps filter for route::tests::{handoff,scope,search,cache}, which no longer exist, so dropping them is the right fix.
Reviewed changes
test/route-sweep.sh: removes the three steps that matched deleted tests.rs/moq-net/src/route/tests/has nohandoff,scope,search, orcachemodules, and the five remaining filters (mesh_sweep,bakeoff,multicast*,warmth,node_layer) all map to existing files..config/nextest.toml: thesweepprofile comment pointed atMOQ_ROUTE_SCENARIOS, which nothing reads any more. It now points attest/route-sweep.sh.
No other references to the deleted test paths remain in the repo.
claude-sonnet-5-5 | 𝕏
|
No actionable comments were generated in the recent review. WalkthroughThe route sweep script removes three test invocations: the handoff and scope sweep, the ignored search delivery-order sweep, and the cache-routing sweep. The nextest comment replaces its previous example with bounded runs started through the script and the sweep profile. Merge Risk:
|

Problem
Nightly
Tests (test route-sweep)fails witherror: no tests to run(run 44562804083). Its first step,mesh_sweep, passes now that moq-dev/moq#9108 fixed the 11-18RESTART to the same instancefailure, so the script reaches its second step for the first time since moq-dev/moq#8987. That PR deleted the old path rule along withroute::tests::{handoff, scope, search, cache}, and three steps oftest/route-sweep.shstill filter for those tests and match nothing.Approach
Drop the three steps that name deleted tests. The remaining steps (
mesh_sweep, bake-off, multicast, warmth, node layer) all still resolve. Thesweepprofile's comment namedMOQ_ROUTE_SCENARIOS, which nothing reads any more; it now points at the script.Impact
None: CI script and a nextest comment only. No public API or wire change.
Alternatives
Port the deleted sweeps to the new route rule: they tested the old rule's path, handoff, and cache behaviour, which no longer exists. The new rule's random sweeps are
mesh_sweepand the multicast tests the script already runs.Caused by
test/route-sweep.shsteps (found by check: Nightly route-sweep)Validation
cargo nextest list --run-ignored allwith the three removed filters lists no tests onmain, matching the nightly'sno tests to run.MOQ_ROUTE_SEED=169144521 just test route-sweep(the 11-19 nightly seed) on this branch: all five remaining steps pass (1, 4, 6, 4, and 2 tests), about 22 minutes on a shared host.main:MOQ_ROUTE_SEED=255657690 MOQ_ROUTE_CASE=41fails at the nightly's4f3ba3317f, and bisecting tomainnames moq-dev/moq#9108 as the first passing commit; the full 500-case sweep for that seed passes onmain.Models
Size: S
Implementer: Claude Code, claude-opus-5-5, unknown
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 0d9333f
Base: origin/main at b73a023
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1f501-457b-7750-bcf7-24de80734824, round 1Score: 10/10,
The change narrowly removes nightly commands for test modules that no longer exist, preserves the remaining routing sweeps, and introduces no behavioral regression identified by source inspection.Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none