Skip to content

ci(test): route-sweep drops the steps for tests the new route rule deleted - #9200

Open
kixelated wants to merge 1 commit into
mainfrom
fix/route-sweep-deleted-tests
Open

kixelated wants to merge 1 commit into
mainfrom
fix/route-sweep-deleted-tests

Conversation

@kixelated

@kixelated kixelated commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Nightly Tests (test route-sweep) fails with error: no tests to run (run 44562804083). Its first step, mesh_sweep, passes now that moq-dev/moq#9108 fixed the 11-18 RESTART to the same instance failure, so the script reaches its second step for the first time since moq-dev/moq#8987. That PR deleted the old path rule along with route::tests::{handoff, scope, search, cache}, and three steps of test/route-sweep.sh still filter for those tests and match nothing.

Approach

Drop the three steps that name deleted tests. The remaining steps (mesh_sweep, bake-off, multicast, warmth, node layer) all still resolve. The sweep profile's comment named MOQ_ROUTE_SCENARIOS, which nothing reads any more; it now points at the script.

Impact

None: CI script and a nextest comment only. No public API or wire change.

Alternatives

Port the deleted sweeps to the new route rule: they tested the old rule's path, handoff, and cache behaviour, which no longer exists. The new rule's random sweeps are mesh_sweep and the multicast tests the script already runs.

Caused by

  • moq-dev/moq#8987 - deleted the handoff, scope, search, and cache tests without removing their test/route-sweep.sh steps (found by check: Nightly route-sweep)

Validation

  • Reproduced: cargo nextest list --run-ignored all with the three removed filters lists no tests on main, matching the nightly's no tests to run.
  • MOQ_ROUTE_SEED=169144521 just test route-sweep (the 11-19 nightly seed) on this branch: all five remaining steps pass (1, 4, 6, 4, and 2 tests), about 22 minutes on a shared host.
  • Separately confirmed the 11-18 failure is fixed on main: MOQ_ROUTE_SEED=255657690 MOQ_ROUTE_CASE=41 fails at the nightly's 4f3ba3317f, and bisecting to main names moq-dev/moq#9108 as the first passing commit; the full 500-case sweep for that seed passes on main.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, unknown

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 0d9333f

  • Base: origin/main at b73a023

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f501-457b-7750-bcf7-24de80734824, round 1

  • Score: 10/10, The change narrowly removes nightly commands for test modules that no longer exist, preserves the remaining routing sweeps, and introduces no behavioral regression identified by source inspection.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

…leted

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. The three steps filter for route::tests::{handoff,scope,search,cache}, which no longer exist, so dropping them is the right fix.

Reviewed changes

  • test/route-sweep.sh: removes the three steps that matched deleted tests. rs/moq-net/src/route/tests/ has no handoff, scope, search, or cache modules, and the five remaining filters (mesh_sweep, bakeoff, multicast*, warmth, node_layer) all map to existing files.
  • .config/nextest.toml: the sweep profile comment pointed at MOQ_ROUTE_SCENARIOS, which nothing reads any more. It now points at test/route-sweep.sh.

No other references to the deleted test paths remain in the repo.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The route sweep script removes three test invocations: the handoff and scope sweep, the ignored search delivery-order sweep, and the cache-routing sweep. The nextest comment replaces its previous example with bounded runs started through the script and the sweep profile.

Merge Risk: Minimal · up to 0d933

This change only removes stale route-sweep CI steps that fail with "no tests to run" and refreshes a nextest comment. It has no effect on runtime behavior or public APIs, and no merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: it removes route-sweep steps for tests that the new route rule deleted. It matches the raw summary, the PR objectives, and the description. The title uses the ci(test)…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the problem (nightly Tests (test route-sweep) fails with 'no tests to run'), the approach (drop three steps in test/route-sweep.sh that name deleted tests, update the sweep prof…
Full details: Title check

Explanation

The title names the main change: it removes route-sweep steps for tests that the new route rule deleted. It matches the raw summary, the PR objectives, and the description. The title uses the ci(test) prefix, which fits a CI script change.

Full details: Description check

Explanation

The description states the problem (nightly Tests (test route-sweep) fails with 'no tests to run'), the approach (drop three steps in test/route-sweep.sh that name deleted tests, update the sweep profile comment), the impact (CI script and nextest comment only), and validation steps. It matches the raw summary, which shows test/route-sweep.sh losing three invocations and the .config/nextest.toml comment changing. The description is specific and on-topic.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 521719b4-754e-4c6f-ae82-7b2e47dd9c66
Commits

Reviewing files that changed from the base of the PR and between b73a023 and 0d9333f.

Files selected for processing: 2

  • .config/nextest.toml
  • test/route-sweep.sh
Files with no reviewable changes: 1

  • test/route-sweep.sh

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant