Skip to content

quest: delete ts-step-damage, an import ending with the cause is right - #9205

Merged
kixelated merged 2 commits into
mainfrom
quest/delete-ts-step-damage
Nov 19, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/delete-ts-step-damage

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Deletes quest/m1/ts-step-damage.md (a lone TS elementary stream's PTS step ends the import) and records why in quest/m1/precut-fixes/README.md.

Maintainer decision (2026-11-19, /quest-complete): ✅ delete (rejected: keep it and start the investigation; keep it idle). It was read from source with no field report. On 2026-11-18 the maintainer ruled that an unexplained step should not be tolerated, and since #9170 the import ends with the cause on a unit it cannot decode, which is the right behavior here. A real muxer or splicer that resets one stream would come back as a field report with a capture.

Impact

Quest files only. Public API: none. Wire: none.

(Written by Claude Opus 5.5 with high)

🤖 Generated with Claude Code

kixelated and others added 2 commits November 19, 2026 12:41
No field report backs it, and since #9170 the import ends with the cause
on a step it cannot explain, which the maintainer ruled is the right
behavior for unexplained corruption.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e0e20b8f-3d4f-4988-a5dd-1f281dab0c69
Commits

Reviewing files that changed from the base of the PR and between c6e0b15 and 39325c6.

Files selected for processing: 2

  • quest/m1/precut-fixes/README.md
  • quest/m1/ts-step-damage.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — removes a quest that was read from source with no field report, and records the decision in the epic README.

Reviewed changes

  • Delete quest/m1/ts-step-damage.md — the standalone quest file is removed.
  • Update quest/m1/precut-fixes/README.md — the link to the deleted quest becomes plain text, and a note records the deletion and why. No references to the deleted file remain in the repo.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 075130c Nov 19, 2026
6 checks passed
@kixelated
kixelated deleted the quest/delete-ts-step-damage branch November 19, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant