Repository navigation
docs(rs): create_track examples handle the Option it returns - #9208
Merged
Merged
Conversation
#9150 made broadcast::Producer::create_track return None for a taken name, but three doc examples still applied ? to it, so their doctests no longer compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
enabled auto-merge
November 19, 2026 21:27
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Doc examples in
rs/moq-mux/src/catalog/tracks.rs,rs/moq-mux/src/json.rsandrs/moq-net/src/model/origin.rsnow map theOptionfromcreate_tracktomoq_net::Error::Duplicateinstead of applying?to it.Error::Duplicateexists inrs/moq-net/src/error.rs.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
moq-dev/moq#9150 made
broadcast::Producer::create_trackreturnNonewhile a live track holds the name, but three doc examples still applied?to it, so their doctests stopped compiling:moq_net::origin::Route(rs/moq-net/src/model/origin.rs),moq_mux::json(rs/moq-mux/src/json.rs), and the telemetry example inrs/moq-mux/src/catalog/tracks.rs. Each now turnsNoneintomoq_net::Error::Duplicate.Doctests run only in Nightly's
rs doctest --workspacerow, and #9150 landed after the 2026-11-19 Nightly started, so this fixes the next Nightly before it fails.Validation
cargo test --workspace --doc --all-featurespasses; onmain, the three examples fail withthe ? operator can only be used on Results, not Options.Caused by
create_trackreturn anOptionwithout updating its doc examplesImpact
Docs only. Public API: none. Wire: none.
Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
(Written by Claude Opus 5.5 with high)
🤖 Generated with Claude Code
Review
Skipped: a three-line doc example change with no behavior; the workspace doctests compiling and passing is the whole check.