Skip to content

quest: splice-stall narrows to a reader stranded by an Unroutable its relay sends - #9209

Merged
kixelated merged 4 commits into
mainfrom
quest/m2/multicast/splice-stall
Nov 20, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m2/multicast/splice-stall

Conversation

@kixelated

@kixelated kixelated commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Rewrites quest/m2/multicast/splice-stall.md to what remains, with the evidence from rerunning the mesh replay after moq-dev/moq#9174 landed. The quest is not finished: readers still starve, rarely, and the cause is narrowed but not fixed.

What the runs show

just test mesh-replay --mesh test/mesh-replay/ring4.toml --script test/mesh-replay/reopen.toml --broadcasts 32, each under quest gate, on nixos (32 cores). reopen.toml lists no [[known]] entries, so every run judges the starve check without editing script.toml. Relay binaries were prebuilt and passed with --new, so the A/B arms ran interleaved under the same load. Longest pause is the median across runs, in seconds, for a link reopen, a relay reopen (every link of a), and a kill.

Build Passed Starved paths per failed run Longest pause (link / relay / kill) Load average
main (309a287), debug 19/20 8 (2 paths x 4 events) 14 / 31 / 29 3-47
main with #9179's router change reverted, debug 4/8 32, 64, 32, 48 14 / 58 / 31 4-37
main merged with #9155 (this head), debug 2/3 1 + 128 12 / 24-28 / 26-29 (passing runs) 3-49
main, release 1/1 - 11 / 18 / 23 22-35
main, release, every relay on lite-06 1/1 - 12 / 18 / 20 22-43
main, debug, every relay on lite-06 2/2 - 13 / 26 / 28 11-47
moq-relay 0.17.17 release (lite-06) 1/1 - 10 / 16 / 19 15-22

The harness's --new can't run lite-06 by itself: the 0.17.17 binary speaks an older moq-lite-07-wip, which the new moq-bench rejects. The lite-06 rows instead run reopen.toml with start = "old" and --old <relay> --old-versions moq-lite-06.

Not found: why relay b sent Unroutable for those 2 paths and not the other 30. That run had info logs only. Runs with debug logs on lite::publisher, lite::subscriber, and model, on debug and release relays, failed only on a saturated host (100% CPU, relays at 5-30% of a core). There, relay a logged serving 30-40 groups per 10s to its reader, but the reader recorded 0-12 over a loopback hop, so the measuring chain itself starved. Those runs are discarded as evidence. A mock-time ring4 integration test reproduced nothing in 176 cases: 8 to 32 broadcasts, readers on their own sessions, a link cut or paused, and the cut swept 0-1.5s after readers start. It is not committed, since it never failed.

Decisions

  • Land this as a quest rewrite rather than keep it a draft. The quest's cause is narrowed and its plan replaced, and its old plan's first step (rerun after A subscription from an old relay mid-roll is fed #9174) is done. Holding the claim open with no fix would only block the next attempt. Rejected: deleting the quest, since a reader still starves about once in twenty runs.
  • Keep the three splice-stall [[known]] entries. The quest's acceptance is not met. Their comment now describes the Unroutable strand.
  • Recommended fix direction, recorded in the quest: a hop must not answer a live subscription Unroutable while it keeps showing the broadcast available. Either its front waits for a way, as for an orphaned claim (Front::waiting), or it moves its announcement so the downstream re-asks. Rejected: having the client re-ask on a quiet table, which needs a timer and can loop on a standing refusal.

Public API and wire impact

None. Quest and replay-script comment only.

Validation

The runs above, logs inspected in each failing run's kept directory. quest check --base origin/main passes.

Follow-ups

None. The remaining work stays in this quest.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 3235a22

  • Base: origin/main at b3de94d

  • Risk: low, Only quest documentation and test comments change, so no consumer or peer behavior can break, and a revert fully undoes the change.

  • Classified: low by Codex, gpt-6.1-sol, low effort, session 01a1f6ec-32bd-73a0-9cd8-910dedcd4e75

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1f6ec-796a-79c3-a0d3-3f0f0e40b7cd, round 1

  • Score: 10/10, The change updates quest documentation and test comments without changing executable behavior or test configuration, and no actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 4 commits November 19, 2026 14:29
… relay sends

19 of 20 reopen.toml runs on main pass; the failure starved 2 reader paths whose
relay reset them Unroutable while still showing the broadcast. Reverting #9179
brings back reopen-starve (4 of 8 failed). Pauses match lite-06 per build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lice-stall

# Conflicts:
#	quest/m2/multicast/README.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title A front keeps delivering after it switches copies on lite-07 quest: splice-stall narrows to a reader stranded by an Unroutable its relay sends Nov 20, 2026
@kixelated
kixelated marked this pull request as ready for review November 20, 2026 03:08
@kixelated
kixelated enabled auto-merge November 20, 2026 03:09

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the full diff: a quest rewrite, its README link text, and a script.toml comment. No executable behavior changes.

  • splice-stall.md retitles and narrows the quest to a reader stranded by an Unroutable its relay sends, with the run evidence, open questions, and next steps.
  • README.md updates the quest's link text to match the new title.
  • test/mesh-replay/script.toml updates the [[known]] comment to describe the Unroutable strand.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The documentation and replay issue record now describe a reader whose live subscription receives Unroutable while the broadcast remains announced. The reader does not retry and waits for a route change. The report records unresolved possible causes and investigation and testing steps. The changes document the issue and do not implement a fix.

Merge Risk: Minimal · up to 3235a

This documentation-only change updates the multicast stall report and a replay-script note. It has no runtime effect and carries no merge risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the quest now narrows to a reader stranded by an Unroutable response from its relay. The changeset rewrites splice-stall.md around that strand, and the title matches i…
Description check Passed The description states the quest rewrite, the mesh replay evidence, the narrowed cause, the kept known entries, and the recommended fix. All of these match the changed files and the objectives.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the quest now narrows to a reader stranded by an Unroutable response from its relay. The changeset rewrites splice-stall.md around that strand, and the title matches it.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4c991f5d-d5a3-4b79-b924-ed63f25547b8
Commits

Reviewing files that changed from the base of the PR and between b3de94d and 3235a22.

Files selected for processing: 3

  • quest/m2/multicast/README.md
  • quest/m2/multicast/splice-stall.md
  • test/mesh-replay/script.toml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Merged via the queue into main with commit 1a34abe Nov 20, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m2/multicast/splice-stall branch November 20, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant