Skip to content

docs(agents): a cache never changes what a subscription delivers - #9211

Merged
kixelated merged 1 commit into
mainfrom
docs/cache-rule
Nov 20, 2026
Merged

kixelated merged 1 commit into
mainfrom
docs/cache-rule

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Adds a Required rule to AGENTS.md: a cache only makes things faster. What a subscription delivers never depends on what a copy happens to hold. A copy answers from its cache only what it can prove upstream would answer, and anything else updates the upstream subscription and waits for its answer.

Decisions

Maintainer, 2026-11-19 (/quest-complete), while reviewing #9198 and #9172: ✅ "subscriptions MUST NOT change behavior based on cache state" and "The cache is a performance optimization that should not change user behavior. Similar concept to HTTP." A provable answer, such as #8638's time placement between held groups linked by Previous Start, is allowed. The maintainer asked for this rule in AGENTS.md.

Impact

Agent instructions only. Public API: none. Wire: none.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort

Review

Skipped: one maintainer-dictated rule, worded from the maintainer's own statements.

(Written by Claude Opus 5.5 with high)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge pick (2026-11-19, maintainer): ✅ /quest-merge; the maintainer asked for this rule.

(Written by Claude Opus 5.5 with high)

@kixelated
kixelated enabled auto-merge November 20, 2026 00:56

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — records the maintainer's stated cache rule in AGENTS.md under Required.

Reviewed changes

  • AGENTS.md cache rule: adds one Required bullet saying a cache never changes what a subscription delivers, and a copy answers from cache only what it can prove upstream would answer.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

AGENTS.md adds a rule for subscription caches. A copy may answer from its cache only when it can prove the upstream answer. Otherwise, it must update the upstream subscription and wait for the upstream answer.

Merge Risk: Minimal · up to a4b64

This PR adds a documentation rule for subscription caches and does not change runtime behavior, so it is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: a new Required rule in AGENTS.md that caches must not change what a subscription delivers. The raw summary confirms the only change is a one-line addition to AGENTS.m…
Description check Passed The description matches the changeset. It describes the added Required rule in AGENTS.md about caches answering only provable upstream answers and updating the upstream subscription otherwise. It also…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: a new Required rule in AGENTS.md that caches must not change what a subscription delivers. The raw summary confirms the only change is a one-line addition to AGENTS.md about cache behavior and subscription results. The docs(agents) prefix matches the file touched. The title is 64 characters, slightly long for a conventional title, but it is specific and accurate.

Full details: Description check

Explanation

The description matches the changeset. It describes the added Required rule in AGENTS.md about caches answering only provable upstream answers and updating the upstream subscription otherwise. It also covers the stated impact (agent instructions only, no public API or wire changes) and the maintainer decision behind the rule.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6a4b582d-52dd-4f8a-861c-cc05901a637f
Commits

Reviewing files that changed from the base of the PR and between 8c741d3 and a4b6410.

Files selected for processing: 1

  • AGENTS.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Merged via the queue into main with commit b3de94d Nov 20, 2026
5 checks passed
@kixelated
kixelated deleted the docs/cache-rule branch November 20, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant