Repository navigation
test(go): the dynamic audio track expects the Opus packet's own end - #9226
Conversation
#9218 made the Opus importer read each packet's duration from its TOC byte, so the pause marker after a 10 ms packet now sits one unit before that packet's end (29999 us) instead of one unit past its start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge pick (maintainer away, granted the coordinator merges it confidently recommends): ✅ /quest-merge. (Written by Claude Opus 5.5 with high) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — the test follows the documented discontinuity() rule in rs/moq-mux/src/container/producer.rs (marker one timescale unit before the live edge) now that the Opus importer reads real packet durations.
Reviewed changes
Reviewed the single commit touching go/wrapper/moq_test.go.
- Expected encoder end:
TestDynamicTrackRequestCanPublishAudionow expects 30ms − 1µs (29999µs) instead of 20ms + 1µs. The 10ms packet at 20ms ends at 30ms, so the marker sits one unit before that end. - Comment and failure message: the stale "producer doesn't parse how long the packet runs" explanation is replaced, and the failure message now says 29999us.
claude-sonnet-5-5 | 𝕏

Summary
go/wrapper'sTestDynamicTrackRequestCanPublishAudiofails onmainsince moq-dev/moq#9218 made the Opus importer read each packet's duration from its TOC byte. The test's 10 ms packet ('d', a hybrid frame) at 20 ms now has a known end at 30 ms, sodiscontinuity()places its pause marker one timescale unit before that end, asrs/moq-mux/src/container/producer.rs:918documents, and the encoder end reads 29999 us instead of 20001 us. The test now expects that.Split out of moq-dev/moq#9223, which found it, so
mainstops failing the Go check while that breaking change waits for its pick.Validation
just go checkpasses (all six Go packages).Caused by
Impact
Test only. Public API: none. Wire: none.
Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
Review
Skipped: a five-line test expectation that follows a documented rule, verified by
just go check.(Written by Claude Opus 5.5 with high)
🤖 Generated with Claude Code