Skip to content

test(go): the dynamic audio track expects the Opus packet's own end - #9226

Merged
kixelated merged 1 commit into
mainfrom
fix/go-opus-duration-test
Nov 20, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/go-opus-duration-test

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

go/wrapper's TestDynamicTrackRequestCanPublishAudio fails on main since moq-dev/moq#9218 made the Opus importer read each packet's duration from its TOC byte. The test's 10 ms packet ('d', a hybrid frame) at 20 ms now has a known end at 30 ms, so discontinuity() places its pause marker one timescale unit before that end, as rs/moq-mux/src/container/producer.rs:918 documents, and the encoder end reads 29999 us instead of 20001 us. The test now expects that.

Split out of moq-dev/moq#9223, which found it, so main stops failing the Go check while that breaking change waits for its pick.

Validation

  • just go check passes (all six Go packages).

Caused by

  • moq-dev/moq#9218 - gave Opus packets their real durations without updating the Go wrapper test

Impact

Test only. Public API: none. Wire: none.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort

Review

Skipped: a five-line test expectation that follows a documented rule, verified by just go check.

(Written by Claude Opus 5.5 with high)

🤖 Generated with Claude Code

#9218 made the Opus importer read each packet's duration from its TOC
byte, so the pause marker after a 10 ms packet now sits one unit before
that packet's end (29999 us) instead of one unit past its start.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge pick (maintainer away, granted the coordinator merges it confidently recommends): ✅ /quest-merge.

(Written by Claude Opus 5.5 with high)

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3bd11de3-8437-4844-aca8-fe9eb6ad0ec9
Commits

Reviewing files that changed from the base of the PR and between 9d3dd9b and 8bf4e3a.

Files selected for processing: 1

  • go/wrapper/moq_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 20, 2026 06:26

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — the test follows the documented discontinuity() rule in rs/moq-mux/src/container/producer.rs (marker one timescale unit before the live edge) now that the Opus importer reads real packet durations.

Reviewed changes

Reviewed the single commit touching go/wrapper/moq_test.go.

  • Expected encoder end: TestDynamicTrackRequestCanPublishAudio now expects 30ms − 1µs (29999µs) instead of 20ms + 1µs. The 10ms packet at 20ms ends at 30ms, so the marker sits one unit before that end.
  • Comment and failure message: the stale "producer doesn't parse how long the packet runs" explanation is replaced, and the failure message now says 29999us.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 7b89fd6 Nov 20, 2026
5 checks passed
@kixelated
kixelated deleted the fix/go-opus-duration-test branch November 20, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant