Repository navigation
quest: plan the cache, no-overlap, and route-switch gaps before lite-07 - #9234
Conversation
Records the three subscription rules in moq-net's AGENTS.md and plans each gap the audit found: groups never overlap (strong form) gates the lite-07 cut; a relay asks upstream for a Min Age join and a missing group head; a route switch caps the old subscription at one boundary, by group now and by frame when the Position end lands; a replaced copy's short group continues; and expiry bounds an incomplete group by a higher group's lowest timestamp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. It records the three subscription rules in rs/moq-net/AGENTS.md and plans each remaining gap as a quest, so nothing ships ahead of the lite-07 cut unowned.
Reviewed changes
Docs and quest files only, with no code or wire change. I read the quest/m2/lite07-finalize.md, group-times.md, expire-by-higher-min.md, fmp4-group-start-tfdt.md, and rs/moq-net/AGENTS.md hunks closely. I did not read the new m1 quests or the moved groups-never-overlap.md.
rs/moq-net/AGENTS.md: the live position now comes only from an open upstream subscription's answer, groups never overlap, expiry uses both timestamps and wall clock, and a route switch splits one subscription at one boundary. The duplicate cache rule is dropped, since the rootAGENTS.mdalready states it.lite07-finalize: it records the decisions and addsgroups-never-overlapto Required. The frame cap is explicitly not Required.groups-never-overlap: the quest moves fromm3tom2, and the links ingroup-times.mdandfmp4-group-start-tfdt.mdare updated to match.expire-by-higher-min: a newm3quest that bounds a group by a higher group's lowest timestamp, gated on the no-overlap rule.- Switch and missing-head quests:
missing-head-asks-upstream,switch-caps-old,switch-frame-cap, andswitch-partial-closeare newm1quests.
claude-sonnet-5-5 | 𝕏

Problem
The maintainer set three rules for moq-net subscriptions and asked whether they hold before the lite-07 cut:
SUBSCRIBE_OKsays where live is.None of the three is fully implemented on main. The lite-07 wire parts are now owned by quests on main: group times and no relative anchors, both from moq-dev/moq#9249 and both Required by the cut. This PR plans the rest.
Summary
rs/moq-net/AGENTS.mdstates rules 2 and 3, plus the moq-net parts of rule 1 (the live position and partial hits). The rootAGENTS.mdalready states the general cache rule, so its duplicate here goes. The "never blocks an answer" line stays as it was. Rule 2 bounds a whole group by its End, which group times keeps on GROUP_END at or above the highest frame.What the audit found
Each claim was checked in the code on main at 9828a20, in Rust and JS.
SUBSCRIBE_OK.containing_received; JStrack.ts).reach_back).position_group,a_missing_head_is_dropped_early).check_startcompare frame 0s.a_keyframe_overlapping_the_previous_group_publishes).ended_at).Decisions
From the maintainer's /quest-plan interview, 2026-11-20:
ended_at, and closed moq-dev/moq#9221's mean-interval estimate; timestamps only).Owned elsewhere
quest/m1/time-start-asks-upstream.md, which owns the time-start hole placement. A comment there namescontaining_receivedas one more unproven inference to remove, and notes that rule 1 answers that quest's waiting cost question: accept the extra range.Impact
Agent guidance and quests only. Public API and wire: none.
Validation
quest check(511 documents) andsh/markdown.sh checkpass after merging main.just checkpassed on d9c3bef, including all 10,889 Rust tests. The first run had four trivial moq-net track tests time out together at 60 s. Rerun alone, they pass in 9 ms, and the branch changes no Rust code.Models
Size: M
Implementer: Codex, gpt-6.2-astra, high effort
Implementer: Claude Code, claude-opus-5-5, unknown effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 852ed66
Base: origin/main at cedb53b
Risk: medium,
The quest plans and revised moq-net agent instructions could steer contributors toward incorrect cache, expiry, or route-switch behavior, but change no shipped code or agent permissions and are fully undone by a revert.Classified: medium by Codex, gpt-6.1-sol, low effort, session
01a1fa8f-7029-7ad1-bbd9-57ca082a546fReviewer: Codex, gpt-6.1-sol, high effort
Session:
01a1fa8b-c6f4-7e01-9370-07e2256d8884, round 2Score: 9/10,
The incremental changes consistently align the guidance and plans with group End semantics and the merged base, with no actionable defects found.Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none