Repository navigation
A WHEP re-offer plays under load - #9241
Merged
Merged
Conversation
Quest-Claim: 1a6d45b26bf073fa
… plays Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 20, 2026 19:57
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. The test now pushes from a live source in both phases, which fixes the stale-first-packet cause rather than raising a timeout.
Reviewed changes
Reviewed the full diff: one test change and three quest plan files.
played_livehelper (rs/moq-webrtc/src/lib.rs): pushes a packet every 20 ms until the viewer receives one, and replaces the one-shot first packet and the inline loop in the second phase.a_reoffer_from_the_same_address_plays: both phases now useplayed_liveand assertNEW_PACKET. Nothing pushesOPUS_PACKETany more, so the tightened assertion is correct.- Quest files: the claim, the sibling-tests follow-up and the DTLS flight finding. None change code.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Claims quest/m0/test-flakes-3/webrtc-reoffer-load.md, and finishes it.
Summary
a_reoffer_from_the_same_address_playspushed one Opus packet before its first viewer existed and then waited for it.Bridge::pushcuts a group per packet, so that packet's group has a successor at once and goes staleegress::MAX_DELAY(100 ms) later. On a loaded host the session's ICE and DTLS take longer than that (a 330 ms gap between the mux listening and ICE checking was logged), so the session read nothing and the 10 sreceivedtimed out. That is the firstreceived, not the re-offered session's push loop: the fixed test's second phase was already live. The test's own second-phase comment named the cause but only applied it there.The fix is in the test: both phases now push from a live source until their viewer plays (
played_live). The code under test is unchanged; no timeout was raised and nothing retries.Validation
systemd-run --user --scope -p CPUQuota=100%: 78 of 80 failed at 10 s with the panic atlib.rs:300. The viewer's ICE and DTLS completed in the failing runs; only media never arrived.KIO_DENY_HOST_TIMERS=1 cargo nextest run -p moq-webrtc: 109 passed.just checklint and format pass; itsrstest step failed only onmoq-clitests that waited 60 s for machine-wide scheduler capacity on a busy host, none touching WebRTC.Caused by
Public API and wire
None.
Follow-ups
moq-webrtctests wait on the same one-shot packet and all time out under the same load (not seen flaking injust checkyet). Left to a quest because each has its own take-over or kill step, and they should share one helper.server/mux.rsthat deserves its own review.Models
Size: S
Implementer: Claude, claude-sonnet-5-5, default effort (arm B)
(Written by Sonnet 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 07ff0af
Base: origin/main at 2170d06
Risk: low,
Only test code and quest plans change, so any regression affects contributor test coverage rather than consumers or deployed peers, and a revert fully undoes it.Classified: low by Codex, gpt-6.1-sol, low effort, session
01a1fa88-643c-7672-98bf-67bf5b29c8a8Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1fa88-7727-7753-ad4f-e3ea13666126, round 1Score: 9/10,
Source inspection found no actionable defects: the test keeps its source live during both connections and preserves the re-offer playback check, though execution checks were intentionally omitted.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none