Skip to content

ci: install Nix with cachix/install-nix-action - #9245

Merged
kixelated merged 1 commit into
mainfrom
ci/cachix-install-nix-action
Nov 21, 2026
Merged

kixelated merged 1 commit into
mainfrom
ci/cachix-install-nix-action

Conversation

@kixelated

@kixelated kixelated commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

DeterminateSystems/nix-installer-action with determinate: false installs upstream Nix, which its v23 release calls unsupported and may remove, breaking CI without warning. Decided in kixel-ai/token-max#177, with the other repos to follow.

Approach

Replace both uses with cachix/install-nix-action v32.0.0, pinned by commit SHA with a version comment like the other actions: .github/actions/nix/action.yml (the composite every job uses) and .github/workflows/runner-vm.yml. It installs upstream Nix by design, matching the nixpkgs Nix of the dev shells, and needs no Cachix account.

  • extra-conf becomes extra_nix_config (accept-flake-config, max-jobs = auto); it appends to the same nix.conf. trusted-users is set by default, which accept-flake-config needs for the flake's cache.
  • Like the old action, it skips installing when nix is already on the PATH (the self-hosted runners).
  • DeterminateSystems/flake-checker-action in check.yml is not an installer and stays.

Impact

CI only. No public API or wire change.

Alternatives

Keeping the DeterminateSystems pin, or switching to Determinate Nix: rejected in the linked decision.

Follow-ups

None. #8048 (retiring Cachix as a binary cache) touches only quest files and does not overlap.

Validation

  • just check passes.
  • Dispatched on this branch: Runner VM (the action used directly) and TS (through the ./.github/actions/nix composite, with accept-flake-config). Results are in the PR comment.

Models

Size: XS
Implementer: Claude Code, claude-sonnet-5-5, unknown effort

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 11dd50f

  • Base: origin/main at 4359f07

  • Risk: high, it changes .github/actions/nix/action.yml, which is always high, as are 1 more of its paths: the repository's actions run inside its workflows, with their secrets

  • Classified: high by the always-high paths

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1fa6b-3944-73b1-b3cb-7bfa16a1b32a, round 1

  • Score: 9/10, The installer replacement preserves shared Nix configuration and updates both installation sites consistently, with no actionable defects found by source inspection; builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

CI exercise on head 11dd50f:

  • Runner VM (direct use): passed, cachix/install-nix-action and just gh runner-vm-ci green.
  • TS (through the ./.github/actions/nix composite): the install and every dev-shell step passed, so accept-flake-config and the cache worked. The run failed only at the TS congested path rate test (a throughput measurement on a shared runner); ts.yml on main also failed on 2026-11-17 and 2026-11-18 on its schedule, so I did not treat it as caused by the installer.

(Written by Claude Sonnet 5.5)

@kixelated
kixelated marked this pull request as ready for review November 20, 2026 19:25

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — swaps the unsupported upstream-Nix mode of the DeterminateSystems installer for cachix/install-nix-action, which installs upstream Nix by design.

Reviewed changes

  • Composite action: .github/actions/nix/action.yml now uses cachix/install-nix-action (SHA matches the v32.0.0 tag), with extra-conf renamed to extra_nix_config and determinate: false dropped.
  • Runner VM workflow: .github/workflows/runner-vm.yml gets the same installer swap.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Nix action configuration and runner VM workflow replace the Determinate Systems installer with Cachix’s Nix installer action, pinned to v32.0.0. The action configuration renames extra-conf to extra_nix_config and removes determinate: false. Its flake-config acceptance and automatic job-count settings remain.

Merge Risk: Minimal · up to 11dd5

This CI-only change replaces the Nix installer action with a pinned alternative and keeps the same Nix settings. No product behavior changes. The one reported CI failure is a throughput test that appears unrelated to the installer, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: Nix installation moves to cachix/install-nix-action. The PR replaces DeterminateSystems/nix-installer-action in the shared nix composite action and in runner-vm.yml, w…
Description check Passed The description states the problem (upstream Nix via determinate: false flagged as unsupported), the approach (replacing both uses with cachix/install-nix-action v32.0.0, pinned by SHA), the config re…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: Nix installation moves to cachix/install-nix-action. The PR replaces DeterminateSystems/nix-installer-action in the shared nix composite action and in runner-vm.yml, which matches the title's subject.

Full details: Description check

Explanation

The description states the problem (upstream Nix via determinate: false flagged as unsupported), the approach (replacing both uses with cachix/install-nix-action v32.0.0, pinned by SHA), the config rename from extra-conf to extra_nix_config, the impact, alternatives, and validation runs. It relates directly to the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5753b39c-caad-41ba-aaca-2ebac60459e6
Commits

Reviewing files that changed from the base of the PR and between 9828a20 and 11dd50f.

Files selected for processing: 2

  • .github/actions/nix/action.yml
  • .github/workflows/runner-vm.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Maintainer decision: ✅ /quest-merge for #9245 (rejected: /quest-iterate only, skip), once the TS workflow's TS congested path failure on this head is rerun and passes. That test also failed in main's nightly on 2026-11-17 and 2026-11-18 and passed on 2026-11-19 and 2026-11-20.

(Written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Following up on the maintainer decision: the TS rerun failed again in TS congested path, and a side-by-side dispatch failed in the same step on main (run 44892351304) as on this branch (run 44892353270), so it is a pre-existing flake, not this change. Maintainer decision: ✅ queue this head now, and plan a moq quest to fix the flake at its root (rejected: queue only, wait for a flake fix).

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Nov 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 21, 2026
@moq-bot

moq-bot Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at 11dd50f because its merge_group build failed (failed_checks).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

Queue / Queue (job) failure at step Check:

…--------------------------------------------------
Ran 1 test in 3.126s

OK
python3 sh/rs/select.test.py SelectTest.test_dispatch_scope_covers_rust_reads
.
----------------------------------------------------------------------
Ran 1 test in 0.461s

OK
##[endgroup]
##[group]check tooling
python3 sh/version.test.py
.......
----------------------------------------------------------------------
Ran 7 tests in 8.251s

OK
python3 sh/local.test.py
..........
----------------------------------------------------------------------
Ran 10 tests in 0.408s

OK
python3 test/smoke/runner.test.py
............
----------------------------------------------------------------------
Ran 12 tests in 0.030s

OK
python3 sh/coverage.test.py
......
----------------------------------------------------------------------
Ran 6 tests in 1.355s

OK
python3 sh/size/report.test.py
.............
----------------------------------------------------------------------
Ran 13 tests in 0.227s

OK
python3 sh/size/release.test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.026s

OK
python3 sh/size/nightly.test.py
.
----------------------------------------------------------------------
Ran 1 test in 0.217s

OK
python3 bench/compare.test.py
...................
----------------------------------------------------------------------
Ran 19 tests in 0.072s

OK
python3 bench/summary.test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.065s

OK
python3 bench/profile.test.py
..................................s..
----------------------------------------------------------------------
Ran 37 tests in 1.191s

OK (skipped=1)
python3 bench/fanout.test.py
....
----------------------------------------------------------------------
Ran 4 tests in 0.006s

OK
python3 bench/lock.test.py
....
----------------------------------------------------------------------
Ran 4 tests in 0.091s

OK
python3 bench/local.test.py
./nix/store/bya4ansy58az5133kryqp2cvrxbnz8qy-python3-3.14.10/lib/python3.14/unittest/case.py:704: ResourceWarning: unclosed file <_io.TextIOWrapper name=4 encoding='UTF-8'>
  function, args, kwargs = self._cleanups.pop()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
.
----------------------------------------------------------------------
Ran 2 tests in 0.105s

OK
python3 sh/gh/gst-formula.test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.017s

OK
python3 sh/changed.test.py
..................
----------------------------------------------------------------------
Ran 18 tests in 1.657s

OK
python3 sh/large-files.test.py
.......
----------------------------------------------------------------------
Ran 7 tests in 0.761s

OK
python3 sh/migrate.test.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.286s

OK
python3 sh/text.test.py
........
----------------------------------------------------------------------
Ran 8 tests in 0.405s

OK
python3 sh/coverage-tables.test.py
........
----------------------------------------------------------------------
Ran 8 tests in 0.260s

OK
python3 sh/tlc.test.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.021s

OK
python3 sh/tla.test.py
......
----------------------------------------------------------------------
Ran 6 tests in 1.478s

OK
python3 sh/dispatch-query.test.py
...........................................
----------------------------------------------------------------------
Ran 43 tests in 44.342s

OK
python3 sh/gh/test-inventory.test.py
...................
----------------------------------------------------------------------
Ran 19 tests in 1.405s

OK
bun test ./sh/gh/remeasure.test.ts
bun test v1.4.4 (38afee6c8)

##[group]sh/gh/remeasure.test.ts:
(pass) only packages pinned by a break trigger measurement [0.22ms]
(pass) kept evidence is the logs and the matrix inputs, not build output [180.24ms]
(pass) release remeasurement executes trusted code with protected write credentials [0.63ms]
(pass) publishing attempts remeasure even after a partial publish fails [0.43ms]
(pass) later publications update one PR and request landing on its new head [0.26ms]
(pass) generated PR preserves the resolver report and credits the workflow [70.36ms]
(pass) a failed measurement still uploads its logs and none of its binaries [72.84ms]

##[endgroup]

 7 pass
 0 fail
 56 expect() calls
Ran 7 tests across 1 file. [380.00ms]
bun test ./sh/gh/setup.test.ts
bun test v1.4.4 (38afee6c8)

##[group]sh/gh/setup.test.ts:
(pass) check queries before setup and keeps its check name [0.35ms]
(pass) check keeps release checks on a hosted runner [0.02ms]
(pass) self-hosted queue jobs use local caches without R2 credentials [0.70ms]
(pass) one job runs one CI dispatch with one checkout and cache restore [0.06ms]
(pass) nightly fuzzing restores and saves minimized target-specific corpora [0.80ms]

##[endgroup]

 5 pass
 0 fail
 161 expect() calls
Ran 5 tests across 1 file. [5.00ms]
bun sh/gh/queue.test.ts
queue event policy passed
python3 sh/gh/install-formula.test.py
.
----------------------------------------------------------------------
Ran 1 test in 0.228s

OK
sh/gh/release.test.sh
release.sh ffi-unreleased: ok
python3 sh/gh/ffi.test.py
.............
----------------------------------------------------------------------
Ran 13 tests in 4.198s

OK
bun test ./sh/gh/ffi.test.ts ./sh/gh/cpp.test.ts ./sh/gh/publish.test.ts
bun test v1.4.4 (38afee6c8)

##[group]sh/gh/ffi.test.ts:
(pass) shared default builds cover each consumer exactly once [1.81ms]
(pass) wrapper gates preserve trusted tag inputs and inspect only their publisher [0.56ms]
(pass) privileged workflow_run jobs require a protected release tag before running its code [0.93ms]
(pass) Nightly and alert chains retain packaged outputs with one shared producer [3.20ms]

##[endgroup]

##[group]sh/gh/cpp.test.ts:
(pass) OBS builds on branch dry runs, and on tags only after the C++ release succeeds [0.38ms]

##[endgroup]

##[group]sh/gh/publish.test.ts:
(pass) no workflow that runs as main names the publish Environment [6.26ms]
(pass) tag runs reach their publishers without workflow_run [0.49ms]
(pass) release dispatches name a release ref [0.17ms]
(pass) Python release retries share the release ref and FFI gates with pushes [0.29ms]

##[endgroup]

 9 pass
 0 fail
 163 expect() calls
Ran 9 tests across 3 files. [19.00ms]
python3 sh/rs/package-rename.test.py
using deb packager...
created package: /var/cache/github-runner-work/_temp/tmp4biqjdcu/moq-nfpm.deb
using deb packager...
created package: /var/cache/github-runner-work/_temp/tmp4biqjdcu/moq-transition.deb
using rpm packager...
created package: /var/cache/github-runner-work/_temp/tmp4biqjdcu/moq-nfpm.rpm
.
----------------------------------------------------------------------
Ran 1 test in 0.433s

OK
python3 sh/dart/build.test.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.692s

OK
python3 sh/kt/gradle.test.py
.....
----------------------------------------------------------------------
Ran 5 tests in 1.010s

OK
python3 sh/rs/select.test.py
.....F.....................
======================================================================
FAIL: test_every_jq_failure_stops_selection_even_after_partial_output (__main__.MetadataTest.test_every_jq_failure_stops_selection_even_after_partial_output) (stage=5)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/cache/github-runner-work/moq/moq/sh/rs/select.test.py", line 441, in test_every_jq_failure_stops_selection_even_after_partial_output
    self.assert_failed_selection(result)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/var/cache/github-runner-work/moq/moq/sh/rs/select.test.py", line 385, in assert_failed_selection
    self.assertIn("jq:", result.stderr)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'jq:' not found in ''

----------------------------------------------------------------------
Ran 27 tests in 65.591s

FAILED (failures=1)
error: recipe `test` failed on line 99 with exit code 1
##[endgroup]
##[error]ci: check tooling failed
ci: wall and CPU seconds per module
     4      38  check biome
     9       9  check markdown
    17      24  check gh
   138     118  check tooling (failed)
    18      17  check shell
     0       0  check large_files
     0       0  check text
     1       0  check toml
     2       2  check nix
     1       0  check justfile
   168     211  whole run
error: recipe `ci` failed on line 120 with exit code 1
##[error]Process completed with exit code 1.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: cargo-timings
  path: target/cargo-timings/cargo-timing-*.html
  if-no-files-found: ignore
  retention-days: 14
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  BASE: 9df4313aba06ba32907da7ba128b796f76d4c444
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
  MBX_CACHE_LINKS: 1
  MBX_REMOTE_URL: 
##[endgroup]
No files were found with the provided path: target/cargo-timings/cargo-timing-*.html. No artifacts will be uploaded.
Post job cleanup.
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__d39973db-f068-4d3b-9827-008d4005dd43.mbx]
##[end-action id=__d39973db-f068-4d3b-9827-008d4005dd43.mbx;outcome=skipped;conclusion=skipped;duration_ms=0]
Post job cleanup.
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git version
git version 2.56.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/449f28d1-0b8f-428c-bfd0-36a82b78b9de' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/moq/moq
Removing SSH command configuration
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/qrn6ds64bzvwbm5nwf245ifz2c6jb9xw-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 131 objects and 39 action results (69.7 MiB logical); 50.0 GiB logical remain
dropped 3 stale checkout records
dropped 6 session event streams
removed 0 learned incremental units and 2 checkout directories (3.7 KiB logical); 39 units (4.7 GiB logical) remain
removed 2 target directories (2.1 MiB logical, 2 abandoned and 0 live); 14.9 GiB logical remain
Cleaning up orphan processes

(written by quest land watch)

@moq-bot

moq-bot Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

quest land watch: Another session holds this pull request, so the watcher stops acting on it and leaves it to that session: the hold ends the pick, and a maintainer enqueues it again once that session is done.

(written by quest land watch)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Diagnosis of the failed_checks ejection (Queue run 44917926398): a flake on main, not this PR. The head is unchanged and landable; requeue it.

  • The failing job is queue.yml's Queue job. It never uses ./.github/actions/nix (it runs ./.github/actions/just, then nix develop), so this PR's diff, which touches only .github/actions/nix/action.yml and runner-vm.yml, cannot reach it. The step list and the untrusted flake configuration warnings match the passing Queue run 44915794578 on main's earlier base.
  • The merge group's sh/rs/select.test.py and sh/rs/select.sh are byte-identical to main's. Run 44918324150 (PR 9300) ran the same base 9df4313aba straight after and passed.
  • The failure: in test_every_jq_failure_stops_selection_even_after_partial_output (stage 5), the script exited nonzero with empty stderr, where the mock jq always writes jq: injected failure first. I could not reproduce it in about 500 runs of the test, alone, under 32-core CPU load, in 72 parallel copies, in the nix dev shell (bash 5.3p20, jq 1.8.2), and with CI's env vars and stdin closed. The failed run took 65s for 27 tests, against 25s for 22 in a passing one, so the runner was loaded.
  • No open PR touches select.test.py or select.sh.

Suggested follow-up for its own PR: have assert_failed_selection put returncode, stdout, and stderr in the jq: assertion message, so the next occurrence names the exit status (a signal, an OOM kill, or an EPIPE on the mock's echo).

(Written by Claude Sonnet 5.5)

@kixelated
kixelated added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit ecf42f5 Nov 21, 2026
10 of 13 checks passed
@kixelated
kixelated deleted the ci/cachix-install-nix-action branch November 21, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant