Repository navigation
ci: install Nix with cachix/install-nix-action - #9245
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
CI exercise on head 11dd50f:
(Written by Claude Sonnet 5.5) |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — swaps the unsupported upstream-Nix mode of the DeterminateSystems installer for cachix/install-nix-action, which installs upstream Nix by design.
Reviewed changes
- Composite action:
.github/actions/nix/action.ymlnow usescachix/install-nix-action(SHA matches thev32.0.0tag), withextra-confrenamed toextra_nix_configanddeterminate: falsedropped. - Runner VM workflow:
.github/workflows/runner-vm.ymlgets the same installer swap.
claude-sonnet-5-5 | 𝕏
|
No actionable comments were generated in the recent review. WalkthroughThe Nix action configuration and runner VM workflow replace the Determinate Systems installer with Cachix’s Nix installer action, pinned to v32.0.0. The action configuration renames Merge Risk:
|
|
Maintainer decision: ✅ /quest-merge for #9245 (rejected: /quest-iterate only, skip), once the TS workflow's (Written by Claude Opus 5.5) |
|
Following up on the maintainer decision: the TS rerun failed again in (Written by Claude Opus 5.5) |
|
quest land watch: the merge queue removed this pull request at 11dd50f because its The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.
…--------------------------------------------------
Ran 1 test in 3.126s
OK
python3 sh/rs/select.test.py SelectTest.test_dispatch_scope_covers_rust_reads
.
----------------------------------------------------------------------
Ran 1 test in 0.461s
OK
##[endgroup]
##[group]check tooling
python3 sh/version.test.py
.......
----------------------------------------------------------------------
Ran 7 tests in 8.251s
OK
python3 sh/local.test.py
..........
----------------------------------------------------------------------
Ran 10 tests in 0.408s
OK
python3 test/smoke/runner.test.py
............
----------------------------------------------------------------------
Ran 12 tests in 0.030s
OK
python3 sh/coverage.test.py
......
----------------------------------------------------------------------
Ran 6 tests in 1.355s
OK
python3 sh/size/report.test.py
.............
----------------------------------------------------------------------
Ran 13 tests in 0.227s
OK
python3 sh/size/release.test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.026s
OK
python3 sh/size/nightly.test.py
.
----------------------------------------------------------------------
Ran 1 test in 0.217s
OK
python3 bench/compare.test.py
...................
----------------------------------------------------------------------
Ran 19 tests in 0.072s
OK
python3 bench/summary.test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.065s
OK
python3 bench/profile.test.py
..................................s..
----------------------------------------------------------------------
Ran 37 tests in 1.191s
OK (skipped=1)
python3 bench/fanout.test.py
....
----------------------------------------------------------------------
Ran 4 tests in 0.006s
OK
python3 bench/lock.test.py
....
----------------------------------------------------------------------
Ran 4 tests in 0.091s
OK
python3 bench/local.test.py
./nix/store/bya4ansy58az5133kryqp2cvrxbnz8qy-python3-3.14.10/lib/python3.14/unittest/case.py:704: ResourceWarning: unclosed file <_io.TextIOWrapper name=4 encoding='UTF-8'>
function, args, kwargs = self._cleanups.pop()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
.
----------------------------------------------------------------------
Ran 2 tests in 0.105s
OK
python3 sh/gh/gst-formula.test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.017s
OK
python3 sh/changed.test.py
..................
----------------------------------------------------------------------
Ran 18 tests in 1.657s
OK
python3 sh/large-files.test.py
.......
----------------------------------------------------------------------
Ran 7 tests in 0.761s
OK
python3 sh/migrate.test.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.286s
OK
python3 sh/text.test.py
........
----------------------------------------------------------------------
Ran 8 tests in 0.405s
OK
python3 sh/coverage-tables.test.py
........
----------------------------------------------------------------------
Ran 8 tests in 0.260s
OK
python3 sh/tlc.test.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.021s
OK
python3 sh/tla.test.py
......
----------------------------------------------------------------------
Ran 6 tests in 1.478s
OK
python3 sh/dispatch-query.test.py
...........................................
----------------------------------------------------------------------
Ran 43 tests in 44.342s
OK
python3 sh/gh/test-inventory.test.py
...................
----------------------------------------------------------------------
Ran 19 tests in 1.405s
OK
bun test ./sh/gh/remeasure.test.ts
bun test v1.4.4 (38afee6c8)
##[group]sh/gh/remeasure.test.ts:
(pass) only packages pinned by a break trigger measurement [0.22ms]
(pass) kept evidence is the logs and the matrix inputs, not build output [180.24ms]
(pass) release remeasurement executes trusted code with protected write credentials [0.63ms]
(pass) publishing attempts remeasure even after a partial publish fails [0.43ms]
(pass) later publications update one PR and request landing on its new head [0.26ms]
(pass) generated PR preserves the resolver report and credits the workflow [70.36ms]
(pass) a failed measurement still uploads its logs and none of its binaries [72.84ms]
##[endgroup]
7 pass
0 fail
56 expect() calls
Ran 7 tests across 1 file. [380.00ms]
bun test ./sh/gh/setup.test.ts
bun test v1.4.4 (38afee6c8)
##[group]sh/gh/setup.test.ts:
(pass) check queries before setup and keeps its check name [0.35ms]
(pass) check keeps release checks on a hosted runner [0.02ms]
(pass) self-hosted queue jobs use local caches without R2 credentials [0.70ms]
(pass) one job runs one CI dispatch with one checkout and cache restore [0.06ms]
(pass) nightly fuzzing restores and saves minimized target-specific corpora [0.80ms]
##[endgroup]
5 pass
0 fail
161 expect() calls
Ran 5 tests across 1 file. [5.00ms]
bun sh/gh/queue.test.ts
queue event policy passed
python3 sh/gh/install-formula.test.py
.
----------------------------------------------------------------------
Ran 1 test in 0.228s
OK
sh/gh/release.test.sh
release.sh ffi-unreleased: ok
python3 sh/gh/ffi.test.py
.............
----------------------------------------------------------------------
Ran 13 tests in 4.198s
OK
bun test ./sh/gh/ffi.test.ts ./sh/gh/cpp.test.ts ./sh/gh/publish.test.ts
bun test v1.4.4 (38afee6c8)
##[group]sh/gh/ffi.test.ts:
(pass) shared default builds cover each consumer exactly once [1.81ms]
(pass) wrapper gates preserve trusted tag inputs and inspect only their publisher [0.56ms]
(pass) privileged workflow_run jobs require a protected release tag before running its code [0.93ms]
(pass) Nightly and alert chains retain packaged outputs with one shared producer [3.20ms]
##[endgroup]
##[group]sh/gh/cpp.test.ts:
(pass) OBS builds on branch dry runs, and on tags only after the C++ release succeeds [0.38ms]
##[endgroup]
##[group]sh/gh/publish.test.ts:
(pass) no workflow that runs as main names the publish Environment [6.26ms]
(pass) tag runs reach their publishers without workflow_run [0.49ms]
(pass) release dispatches name a release ref [0.17ms]
(pass) Python release retries share the release ref and FFI gates with pushes [0.29ms]
##[endgroup]
9 pass
0 fail
163 expect() calls
Ran 9 tests across 3 files. [19.00ms]
python3 sh/rs/package-rename.test.py
using deb packager...
created package: /var/cache/github-runner-work/_temp/tmp4biqjdcu/moq-nfpm.deb
using deb packager...
created package: /var/cache/github-runner-work/_temp/tmp4biqjdcu/moq-transition.deb
using rpm packager...
created package: /var/cache/github-runner-work/_temp/tmp4biqjdcu/moq-nfpm.rpm
.
----------------------------------------------------------------------
Ran 1 test in 0.433s
OK
python3 sh/dart/build.test.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.692s
OK
python3 sh/kt/gradle.test.py
.....
----------------------------------------------------------------------
Ran 5 tests in 1.010s
OK
python3 sh/rs/select.test.py
.....F.....................
======================================================================
FAIL: test_every_jq_failure_stops_selection_even_after_partial_output (__main__.MetadataTest.test_every_jq_failure_stops_selection_even_after_partial_output) (stage=5)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/var/cache/github-runner-work/moq/moq/sh/rs/select.test.py", line 441, in test_every_jq_failure_stops_selection_even_after_partial_output
self.assert_failed_selection(result)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
File "/var/cache/github-runner-work/moq/moq/sh/rs/select.test.py", line 385, in assert_failed_selection
self.assertIn("jq:", result.stderr)
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'jq:' not found in ''
----------------------------------------------------------------------
Ran 27 tests in 65.591s
FAILED (failures=1)
error: recipe `test` failed on line 99 with exit code 1
##[endgroup]
##[error]ci: check tooling failed
ci: wall and CPU seconds per module
4 38 check biome
9 9 check markdown
17 24 check gh
138 118 check tooling (failed)
18 17 check shell
0 0 check large_files
0 0 check text
1 0 check toml
2 2 check nix
1 0 check justfile
168 211 whole run
error: recipe `ci` failed on line 120 with exit code 1
##[error]Process completed with exit code 1.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
name: cargo-timings
path: target/cargo-timings/cargo-timing-*.html
if-no-files-found: ignore
retention-days: 14
compression-level: 6
overwrite: false
include-hidden-files: false
archive: true
env:
BASE: 9df4313aba06ba32907da7ba128b796f76d4c444
CHECK_FAIL_FAST: 1
NEXTEST_TEST_THREADS: 24
MBX_CACHE_LINKS: 1
MBX_REMOTE_URL:
##[endgroup]
No files were found with the provided path: target/cargo-timings/cargo-timing-*.html. No artifacts will be uploaded.
Post job cleanup.
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__d39973db-f068-4d3b-9827-008d4005dd43.mbx]
##[end-action id=__d39973db-f068-4d3b-9827-008d4005dd43.mbx;outcome=skipped;conclusion=skipped;duration_ms=0]
Post job cleanup.
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git version
git version 2.56.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/449f28d1-0b8f-428c-bfd0-36a82b78b9de' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/moq/moq
Removing SSH command configuration
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/qrn6ds64bzvwbm5nwf245ifz2c6jb9xw-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 131 objects and 39 action results (69.7 MiB logical); 50.0 GiB logical remain
dropped 3 stale checkout records
dropped 6 session event streams
removed 0 learned incremental units and 2 checkout directories (3.7 KiB logical); 39 units (4.7 GiB logical) remain
removed 2 target directories (2.1 MiB logical, 2 abandoned and 0 live); 14.9 GiB logical remain
Cleaning up orphan processes
(written by quest land watch) |
|
quest land watch: Another session holds this pull request, so the watcher stops acting on it and leaves it to that session: the hold ends the pick, and a maintainer enqueues it again once that session is done. (written by quest land watch) |
|
Diagnosis of the
Suggested follow-up for its own PR: have (Written by Claude Sonnet 5.5) |

Problem
DeterminateSystems/nix-installer-actionwithdeterminate: falseinstalls upstream Nix, which its v23 release calls unsupported and may remove, breaking CI without warning. Decided in kixel-ai/token-max#177, with the other repos to follow.Approach
Replace both uses with
cachix/install-nix-actionv32.0.0, pinned by commit SHA with a version comment like the other actions:.github/actions/nix/action.yml(the composite every job uses) and.github/workflows/runner-vm.yml. It installs upstream Nix by design, matching the nixpkgs Nix of the dev shells, and needs no Cachix account.extra-confbecomesextra_nix_config(accept-flake-config,max-jobs = auto); it appends to the same nix.conf.trusted-usersis set by default, whichaccept-flake-configneeds for the flake's cache.nixis already on the PATH (the self-hosted runners).DeterminateSystems/flake-checker-actionincheck.ymlis not an installer and stays.Impact
CI only. No public API or wire change.
Alternatives
Keeping the DeterminateSystems pin, or switching to Determinate Nix: rejected in the linked decision.
Follow-ups
None. #8048 (retiring Cachix as a binary cache) touches only quest files and does not overlap.
Validation
just checkpasses../.github/actions/nixcomposite, withaccept-flake-config). Results are in the PR comment.Models
Size: XS
Implementer: Claude Code, claude-sonnet-5-5, unknown effort
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 11dd50f
Base: origin/main at 4359f07
Risk: high,
it changes .github/actions/nix/action.yml, which is always high, as are 1 more of its paths: the repository's actions run inside its workflows, with their secretsClassified: high by the always-high paths
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1fa6b-3944-73b1-b3cb-7bfa16a1b32a, round 1Score: 9/10,
The installer replacement preserves shared Nix configuration and updates both installation sites consistently, with no actionable defects found by source inspection; builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none