Skip to content

quest: plan the main → release audit's gaps, and fix its small findings - #9258

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/release-audit-2026-11-20
Nov 21, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/release-audit-2026-11-20

Conversation

@kixelated

@kixelated kixelated commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Plans the gaps left by the 2026-11-20 audit of main (9828a20cab) against release (381b802d9b), and fixes its small findings.

Problem

The audit found six release blockers and several smaller issues. Most already had an owner, and those stay where they are (see Overlap). The rest had none: the archive guide, the moq.pro attach recheck, a Swift crash, a JSON snapshot bug, the cut PR's thin interop gate, and the two refactors the audit recommended.

Approach

Quests:

Quest Size Milestone Why there
New: range table M m2 The cut waits: a Rust/JS divergence in which groups get delivered has to be found before lite-07 publishes. Requires no relative anchors.
New: route forward states L m4 After the cut: #9231 fixed the race the audit found, and mesh replay violations owns the open strands.
Edit: cut - m3 Candidate checks: keep the behavior of release-only fixes, roll a relay with a reader attached in both directions, read the new full gate, and attach results to the candidate SHA.
Edit: migration audit - m3 The archive guide's format 3/4 entries are wrong since #8932. sh/migrate.sh refuses MIGRATE.md edits outside the cut, so the fix lives here.
Edit: attached credentials downstream - m2 Rechecked: moq.pro 828766e510 still reads only query. The wait now names moq.pro and Kixel as the parties, with a grep and a test to check each.

Fixes:

  • Swift checkTrackInfo validates refresh.interval too, so a negative, infinite, or NaN interval throws MoqError.Config instead of reaching UniFFI's fatalError. Go already validated it. Kotlin's and Python's generated converters throw.
  • @moq/json Producer.mutate treats a published null as a value, since only undefined means nothing was published. Before, it threw with no initial and edited a stale initial otherwise. Rust's Option-based encoder is unaffected.
  • interop.yml: the cut PR (head main) runs the full moq-transport matrix and Released wire compatibility. A backport PR keeps the reduced matrix and still skips wire compatibility. Before, every release PR skipped the check against published versions, which is the one the cut most needs.

Overlap

Already owned, unchanged here:

Withdrawn: the audit's moq-net minimal-feature finding. just rs no-async passes on 0f920c1e0d, and moq-net's default feature set is empty, so its self dev-dependency enables nothing.

Decisions

From the /quest-plan interview (maintainer, 2026-11-20):

  • Scope: ✅ plan the gaps and fix the small ones in this PR (rejected: plan only; cut blockers only). The archive guide couldn't be fixed here, as above.
  • Fixes: ✅ archive guide, Swift refresh check, JSON null, full interop on the cut PR (none rejected).
  • Range table: ✅ m2, the cut waits (rejected: m4; drop it).
  • Route forward states: ✅ m4 (rejected: m2; drop it).

Follow-ups

  • moq-dev/moq.pro (for its own /quest-plan): the edge auth handler reads an attached credential from token on attach, revalidate, and end, with a test that presents distinct credentials against the last released relay and the candidate. Required by moq.pro's quest/m0/adopt-cut-pin.md. Kept (maintainer, 2026-11-20 pick round).

Caused by

Validation

  • JSON: the new mutate starts from a published null test fails on main (mutate() requires a prior update()) and passes with the fix. bun test src/snapshot/ passes 81, and tsc and biome are clean.
  • Swift: just swift check on macOS (arm64, kixtop) at 102ef455c7 passes all 51 tests, including testBadDurationThrowsConfig with the new refresh-interval cases. I did not run the new cases without the fix, since that path aborts the test process.
  • just check (changed scope) passes, and quest check passes 510 documents.
  • Workflow: only the cut PR changes. A backport PR keeps the old arguments and skips, and nightly and manual runs are unchanged. It runs for real on the cut PR.

Impact

Public API: none (Swift and JS behavior only: a bad refresh interval throws, and mutate after update(null) receives null). Wire: none.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 102ef45

  • Base: origin/main at 5169af0

  • Risk: high, it changes .github/workflows/interop.yml, which is always high: workflows run with the repository's secrets and decide what merges and ships

  • Classified: high by the always-high paths

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1fb93-ba54-7c10-a6b3-47be143bba4e, round 1

  • Score: 9/10, No actionable defects were found, and the fixes and release-cut conditions match their callers and documented process; builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Plans the 2026-11-20 release audit's unowned findings: a shared Rust/JS
range table the cut waits on, explicit route forwarding states after the
cut, the archive guide correction, the moq.pro attach recheck, and extra
candidate checks in the cut.

Fixes the small findings: Swift validates a track's refresh interval
before UniFFI aborts on it, @moq/json's mutate keeps a published null,
and the cut PR runs the full moq-transport matrix and released wire
compatibility.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 21, 2026 00:50
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0057ec54-3136-4136-8e5c-886bd464fe33
Commits

Reviewing files that changed from the base of the PR and between 5169af0 and 102ef45.

Files selected for processing: 10

  • .github/workflows/interop.yml
  • js/json/src/snapshot/producer.ts
  • js/json/src/snapshot/snapshot.test.ts
  • quest/m2/auth-attach-downstream.md
  • quest/m2/time-addressing/range-table.md
  • quest/m3/release/cut.md
  • quest/m3/release/migrate-audit.md
  • quest/m4/route-forward-states.md
  • swift/Sources/Moq/Durations.swift
  • swift/Tests/MoqTests/SmokeTests.swift
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. Each fix sits where the defect lives: Swift's existing duration guard, the one ?? fallback in mutate, and the two if/args expressions that select the cut PR's gate. The quest docs plan only what has no owner yet.

Reviewed changes

All 10 files in the single commit, including the workflow's reach through release-gate.yml and the Swift and JS callers.

  • Cut PR interop gate: interop.yml runs the full moq-transport matrix and Released wire compatibility when a pull_request has head main. It reaches release PRs only through release-gate.yml's workflow_call, which passes the caller's head_ref. That gate's interop paths filter includes test/** and interop.yml, so a cut PR always selects it. Backports are unchanged.
  • @moq/json mutate on a published null: the encoder's value getter is undefined only before the first commit, so the !== undefined check correctly treats a published null as the base. The new test covers both the no-initial and stale-initial paths.
  • Swift refresh.interval check: checkTrackInfo is the single choke point for both publishTrack and accept, so the guard covers every public entry that takes a TrackInfo.
  • Quest plans: the new range-table (m2) and route-forward-states (m4) quests, plus edits to cut, migrate-audit, and auth-attach-downstream. Every in-repo path they cite exists. Node::forward does return Option<Option<Via>>, and moq-archive reads and writes only one VERSION, which matches the migrate-audit note.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit f839672 Nov 21, 2026
11 checks passed
@kixelated
kixelated deleted the quest-plan/release-audit-2026-11-20 branch November 21, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant