Repository navigation
Conversation
Quest-Claim: 2a5be1b00e4db843
… the group's end On lite-07-wip, GROUP loses Previous Start, the first FRAME's Timestamp Delta counts from the Group Start (the FETCH's on a Fetch Stream), a scale-less FRAME carries no Timestamp Delta, and GROUP_END carries the End as a non-negative delta from the highest frame timestamp on the stream, or from the Group Start. A whole group's span, [start, End), holds no other start. Its GROUP_END accounts for the starts inside it, which a copy records skipped, and a drop of a group held whole names its span. The publisher's elision of skips a GROUP's Previous Start passed over goes. `finish_at` refuses an End below the group's highest frame, so moq-mux and hang's legacy producer close without an End when theirs would fall below a frame of their own. The time-anchor rule for spans moves to a follow-up quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ing/group-times # Conflicts: # quest/m2/README.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes Group times. On lite-07-wip a Group Stream carries each time once:
lite::Clock, shared by Group and Fetch Streams on both sides.A whole group's span, [start, End), holds no other start:
append_groupdid.TrackRun::elided,owes_group,send_elided) is gone.group::Producer::finish_atrefuses an End below the group's highest frame, and accepts one equal to it or to the start.Producers that ended a group below a frame of their own now close it without an End: moq-mux
close_groupand hang's legacy#close. Their overlap belongs to groups never overlap, which now lists both guards to delete.The draft (Frame, Group, GROUP, FRAME, GROUP_END, SUBSCRIBE_SKIP/DROP, the changelog),
doc/concept/moq-lite.md, and the subscribe model (SubscribeAccounting.tla) change with it.Public API and wire impact
group::Producer::finish_atreturnsTimestampMismatchfor an End below the group's highest frame, where it previously accepted any End above the start. JSGroup.Producer.finishAtmatches.track::Subscriber::previous_startandholdsbecamespan_end; JS hookspreviousStartbecamewholeEnd/wholeAround.Migration note for
MIGRATE.md: a producer callingfinish_at(end)must pass anendat or above every frame timestamp it wrote to the group, or callfinish().Validation
just checkpasses, after merging main (with fix(moq-net): a waiting time start reads its owed group first, and a fill past the live edge reaches subscriptions #9172).just rs test --workspace --all-features: 13050 passed.bun testinjs/net(3431) andjs/hang(786) pass.just test interop --all: all checks passed, includingdrop moq-lite-07-wipboth ways and the lite-07 tail and compress cases./verify-subscribe:SubscribeAccounting.tlachecksServedOnce,NamedOnce, andQuietIsSettledwith group 1 ending at 2, 3, or 4, so its span holds none, one, or both starts above it: 75.7M distinct states, nine minutes, no violation. Only its comments changed after that run.rs/moq-net/fixtures/lite.json.receive_group; JS, also for a stream resumed at Frame Start above 0).group_end_counts_from_the_highest_frame), and an End past 64 bits is refused.lite07_skips_only_past_a_whole_groups_end), even when each group finishes as the next is appended.GroupOutcomes::whole).Two regressions found and fixed along the way:
a_lost_discontinuity_marker_still_breaks_the_clock, whose marker group starts inside the previous group's span. That is the overlap noted in groups-never-overlap.Waiting
Follow-ups
cut(end)just closed, and the overlapping keyframe's estimated End.Models
Size: L
Implementer: Claude, claude-opus-5-5, high effort
(Written by Claude Opus 5.5 with high)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 168e500, named in full once no reviewer reports a finding
Base: origin/main at cb9cb51
Risk: high,
The change alters lite-07 GROUP headers and timestamp/end encoding, which can break interoperability for Rust and JS consumers and deployed peers; reverting code cannot restore compatibility with peers already using the changed wire format.Classified: high by Codex, gpt-6.1-sol, low effort, session
01a1fc78-e908-7012-b343-32c3a7c8d81dReviewer: Codex, gpt-6.1-sol, xhigh effort
Session:
01a1fc79-10e6-74d3-83a4-866bb80bf064, round 1Score: 6/10,
The head needs rework because span traversal can panic and valid JS streamed-frame groups are rejected.Rounds: 1; first round 2 (high 1, medium 1); findings 2 (high 1, medium 1): fixed 0, refuted 0, open 2
Findings, open until the next round settles them:
rs/moq-net/src/model/track.rs:1805:Stop span traversal when it passes the requested endjs/net/src/group.ts:741:Rescale streamed timestamps before validating the group end