Repository navigation
Conversation
Quest-Claim: d35f0dc05081d1b5
…up's start Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes quest/m2/time-addressing/scale-less-arrival.md, one of the lite-07 cut's blockers.
@moq/net, and the lite-07 draft. Its group starts are bare numbers, so they never count as milliseconds of a Max Age: keys 0, 10000, and 20000 arriving together no longer expire group 0 under a 5 ms budget.model/track.rs:presentedandstarted_atgive no time on a scale-less track, so it has no live edge, no reach, and a group finished whole waits for a successor (ended_at), instead of ageing from its arrival plus its bare span.poll_driftedstops after the wall-clock check there.ageis gone.track.ts:#driftfinds no presentation edge on a scale-less track, and#presented/#reach/#endedAtfollow Rust. A track whose info is not accepted yet keeps measuring by its frames' timestamps, as before.@moq/netstamps a scale-less frame or datagram on lite-05/06 with its group's start (or its sequence), as Rust'sStamp::wirealready did, instead ofTimestamp.now(). A frame now carries the same timestamp at every hop and on every fetch.wireTimemirrorsStamp::wire, andStamp.timedandbareTimeare gone.rs/moq-net/fixtures/stamps.json, pins a scale-less group's lite-05 and lite-06 Group Stream. Rust (serve_group_test::a_scale_less_group_stream_matches_the_shared_fixture) and JS (lite/publisher.test.ts) both serve it and compare byte for byte.@moq/netpublisher still sends send times, which is whyuncheckedstays.Choices made without asking, for review:
finish_at) no longer ages from its own end. Its end is a bare number, so treating its span as time is the same bare-units-as-milliseconds rule this quest rejected. It now ages only once a successor arrives, as the draft already says for every group.group-id.test.tsdrops its lite-05 and lite-06 lanes (see Decisions).resume.test.ts"a group fetched over a wire goes stale by the fetch's own budget" judged a scale-less track by its keys under a still clock. It now advances the clock a second past the successor's arrival.Impact
@moq/netnow carries its group's start (or sequence) in milliseconds, not its send time, which matches what Rust already sent. On lite-07-wip, expiry semantics change for scale-less tracks (an unpublished version).Decisions
Unattended choices, taken by the
/quest-runorchestrator's recommendation while the maintainer was away. A review can still undo them; none is a maintainer decision.Timestampholds a number, so a JS receiver cannot hold such a key (Rust's bound is 2^61). Rust publishers already sent these keys before this PR, so only the JS-to-JS case is new. ✅ (a) accept the limit, since lite-05/06 are legacy and lite-07 carries a scale-less key as a bigint (rejected: (b) keep send times in JS only for keys past 2^53, which reintroduces a timestamp that differs per hop; (c) make JS timestamps hold a bigint for timed tracks, which touches the whole time API).group-id.test.tstherefore drops its lite-05/06 lanes. Today the failure also closes the downstream session of a JS node that republishes the track; the follow-up below fixes that for any malformed group.Validation
model/track.rsandtrack.tstime starts):cargo test -p moq-net --all-featuresall pass (4146), andbun testinjs/net3441 pass.just rs test -p moq-net --all-features: 4106 passed. The 4 integration timeouts seen in earlier full runs moved between unrelated tests from run to run while the host's load average was about 24 on 24 cores. They pass on rerun, and on main.bun testinjs/net: 3425 pass.js/hangandjs/publishpass.just test interop --all: all checks passed, including JS-to-Rust over lite-05/06.track.ts, "a scale-less track ages by arrival alone" fails. With main'spublisher.ts, both fixture cases fail (...0001 61...instead of...0a01 61...), and so do the new lite-05/06 lanes ofuntimed.test.ts("an untimed group past 0 arrives stamped with its start").00, GROUP03 00 05 00(lite-06; lite-05 has no frame start, so02 00 05), then frames0a 01 61(zigzag(5), size 1,a) and00 01 62. Both languages produced exactly these bytes.just check: its only failures were the timeouts above and onejs/publishworker test, which all passed on rerun.Caused by
age,presented, andended_at(found by person: the pre-cut audit's /quest-plan).@moq/net's#drift/#presented(found by person).Follow-ups
Models
Size: M
Implementer: Claude, claude-opus-5-5, high effort (arm B)
Implementer: Claude Code, claude-opus-5-5 (iterate, M, arm B)
(Written by Opus 5.5)
🤖 Generated with Claude Code