Repository navigation
Conversation
Quest-Claim: e28baad8495c494c
just ci runs clippy for aarch64-apple-darwin and x86_64-pc-windows-msvc over rs's selection (the new rs_cross module), with a flake-pinned toolchain carrying those targets' std and zig compiling build scripts' C. Fixes the Windows-only dead code it found in moq-video's test util. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just ci(andjust check) now run clippy foraarch64-apple-darwinandx86_64-pc-windows-msvcfrom Linux over the Rust crates the diff changed plus their dependents, so a platform-gated compile error or unfulfilled#[expect]fails the merge queue instead of the nightly macOS and Windows lanes. Tests stay on Linux; real macOS and Windows runners stay out of the gate.sh/dispatch.sh: newrs_crossmodule, same scope asrs, its own lane, runningjust rs cross-lint-changed.sh/rs/select.sh: newcrossaction sharingplatform's selection and flags (moq-gst excluded, the cli's device and sound-server features on). Under--allit also excludesmoq-auth-fuzzandqmux-fuzz, whose libFuzzer C++ includessys/syscall.h, which zig's macOS libc lacks; fuzzing runs only on Linux.sh/rs/cross-lint.sh: builds.#rust-cross(new inflake.nix: the pinned 1.98.1 toolchain with clippy and those two targets' std, kept out of the dev shell likerust-nightly), puts the mbx shim back in front, and runs onecargo clippy --target=… --target=… --all-targets -- -D warnings, so both targets share host build scripts and proc macros.sh/rs/zig-cc.sh,zig-c++.sh,zig-ar.sh: the CC, CXX, and AR for build scripts on those targets. They strip the Apple and LLVM target flags cc-rs adds, which zig rejects, and pick the zig target from Cargo'sTARGET.test_util::Spent::peakin moq-video is read only by the hardware encoders' tests, so anopenh264build without VideoToolbox, NVENC, or VA-API never reads it. It now carries acfg_attr-scopedexpect(dead_code).CONTRIBUTING.md:platform.ymlnow only needs dispatching to run tests.Choices made without asking
x86_64-pc-windows-msvc, the targetrelease-binary.ymlships, sotarget_env = "msvc"cfgs are checked. Build-script C is compiled by zig against MinGW headers, because nixpkgs'windows.sdk(the MSVC CRT and SDK via xwin) is unfree and requires accepting Microsoft's license (xwin --accept-license). A lint links nothing, so the objects' ABI never matters. The gnu target was not needed.rslane. Lanes run concurrently, so the cross build overlaps therslane's long test run instead of extending it. Cargo's build-directory lock barely contended in the runs below (one "Blocking waiting for file lock on build directory" over all of them).just checkruns it locally too, since it shares the module list withjust ci. A host withoutnixorzigskips it (and fails underCI_STRICT), like any other module.cross-lint.shand the zig wrappers toselect.sh's "select everything" paths, the same asplatform.sh.Validation
just rs cross-lint-changed --all: passes for both targets (after the moq-video fix). Before that fix the Windows target failed withfield 'peak' is never readinrs/moq-video/src/encode/backend/mod.rs.all(test, not(target_os = "macos"))back toteston theclippy::large_enum_variantexpectation inrs/moq-audio/src/capture.rs) and ranjust rs cross-lint-changedon a list containing only that file. It failed witherror: this lint expectation is unfulfilledatcapture.rs:185, the same error the macOS lane reported.cargo clippy -p moq-video --no-default-features --features openh264 --lib --tests -- -D warningson Linux still passes (the new expectation is fulfilled there too).python3 sh/rs/select.test.pypasses; shellcheck, shfmt, nixfmt, andjust --fmt --checkare clean.Cost to a queue run (local, 24 cores, shared with other agents, mbx cache warm for unchanged crates)
Each run appended a fresh comment to the edited file, so the edited crate and its dependents miss the cache. "rs" is
just rs lint-changedplustest-changed, therslane; "both" runs thersandrs_crosslanes concurrently, as the gate does.rs/moq-relay/src/main.rs(typical)rs/moq-net/src/lib.rs(selects nearly every crate)select.sh), and its per-module timing table will show the--allcost.rs_crossat all.rust-stdcomponents (about 22 MiB of fetches here, then a local build of the toolchain join).Public API and wire impact
None. CI and tooling only, plus a test-only lint attribute in moq-video.
Caused by
Spent::peak, which no test reads on Windows withopenh264(found by check)Follow-ups
None.
Models
Size: M
Implementer: Claude, claude-opus-5-5, medium effort (arm A)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 3f085f9fa221009ac5947821f583cb4efb22fb48
Base: origin/main at 2661d47
Risk: high,
The new cross-target CI gate and compiler wrappers could fail or consume extra runner resources for contributors’ Rust changes, with a revert restoring the gate but not recovering resources already spent.Classified: high by Codex, gpt-6.1-sol, low effort, session
01a1fc1b-c5d0-7ec0-a88b-c0247bb33233Reviewer: Codex, gpt-6.1-sol, high effort
Session:
01a1fc18-c8a1-7c50-9bb8-fc5b35510b60, round 2Score: 10/10,
Source inspection confirms the toolchain-input selection gap is fixed, with no new findings in the changes since the previous review.Rounds: 2; first round 1 (medium 1); findings 1 (medium 1): fixed 1, refuted 0, open 0
Findings: none
The last round's findings, at 9843070:
sh/dispatch.sh:125:Select cross-lint when its toolchain inputs change;At the head, sh/dispatch.sh includes flake.nix and flake.lock in rs_cross’s scope, and sh/rs/select.sh selects the whole workspace for cross when either file changes.