Skip to content

quest: the 2026-11-20 relay join regressions are gone on main - #9272

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/nightly/relay-join-regressions
Nov 21, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/nightly/relay-join-regressions

Conversation

@kixelated

@kixelated kixelated commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/nightly/relay-join-regressions.md by deleting it: the regressions are already gone on main, so this PR changes no code.

Problem

Nightly run 44767045952 flagged six Relay session cells on moq-lite-07-wip (a759e4cf6 against a4fa80a74). moq-dev/moq#9237 fixed other benches from that window (moq-quic noop waits, stats presence) and did not touch these.

Findings

Wall time on this host was too noisy to bisect (load around 22 on 24 cores, ±15% between runs). So the bisect timed each join, and each paced delivery round, in retired user instructions on one pinned core, through a scratch patch to the bench that is not committed. Millions of instructions per iteration:

Commit join_broadcasts relays=1, 1024 join_relays relays=8, publishers=16
a4fa80a74 (base) 130.3 4.32 to 4.36
3b7c9e449 135.9 4.37
95979c7e2 135.7 4.38
46059266e (moq-dev/moq#9202) 161.0 5.02
a759e4cf6 (the nightly's head) 161.2 -
b4496b120 (main with moq-dev/moq#9251) 132.3 4.29
  • Cause. fix(moq-net): lite-07 answers a prefix wider than the grant region by region #9202 changed Answer::shows (rs/moq-net/src/lite/publisher/routed.rs) to search for a covered path both the permit and the handle allow, through Permit::beneath and origin::Consumer::reaches_any. Every claim a joining viewer's answer syncs then built a subtree pattern, intersected it with the grant and the limit (each building a pattern index), and rebased the handle's scope. The before/after profile shows moq_pattern::index::Node::child, Patterns::intersect, Index::contains, and extra malloc/free only after fix(moq-net): lite-07 answers a prefix wider than the grant region by region #9202.
  • Already fixed. moq-dev/moq#9251 ("grants are path prefixes again"), merged after this quest was planned, replaced that search with a prefix intersection (Permit::within(...).overlaps). On current main every flagged join cell is back within 2% of base:
    • join_broadcasts relays=1/2/8 at 64 broadcasts: 8.23, 8.64, 9.48 against base 8.48, 8.88, 9.37.
    • relays=8 at 1024: 144.0 against base 141.8.
  • delivery_paced/.../viewers=256 is noise. Its nightly rounds were +6.2%, +26.9%, and +36.7%. Its instruction count moved only +1.5% from base to a759e4cf6 (viewers=16: +1.6%), and is 29.7 on main against base 29.4. The cell is memory-bound, at IPC 0.35 to 0.45, and its cycles and cache misses varied more between runs of one binary than between base and new.

This branch first carried its own fix for #9202's cost: a fast path in shows that checks the claim's own path before searching. It recovered the same cells (136.9 and 4.41 above), and the full moq-net, moq-relay, and moq-auth suites passed with an assert that it agreed with the search. #9251 then rewrote the same lines, so the merge of main took #9251's version and dropped the fix as redundant.

Impact

  • Public API: none. Wire: none. Code: none, only the quest file is deleted.

Validation

  • The paired instruction counts above, measured from bench builds at each commit on the same pinned core.
  • quest check passes.

Caused by

  • moq-dev/moq#9202 - Answer::shows intersected patterns and rebased the scope for every claim it synced, adding 12 to 20% on relay_session_join_broadcasts and 14.8% on relay_session_join_relays (found by check). moq-dev/moq#9251 already removed it.

Decisions

  • I closed relay_session_delivery_paced/.../viewers=256 as noise instead of accepting it, since no culprit exists to accept it, as moq-dev/moq#9237 did for relay_auth_refresh.
  • I did not bisect the 3 to 4% of join_broadcasts instructions between a4fa80a74 and 3b7c9e449. It is under the paired comparison's 10% threshold, and current main is within 2% of base anyway.
  • The bisect timed instructions, not wall time. The next scheduled Nightly, paired against a759e4cf6, is the wall-time check.

Follow-ups

None.

Models

Size: M
Implementer: Claude, claude-opus-5-5, medium effort (arm A)

Review

  • Head: 73ad8aa
  • Skipped: the head's diff against main only deletes the quest file. Codex (gpt-6.1-sol, high effort) reviewed the earlier head d256f5d with its shows fast path, which the merge of main dropped: score 9/10, no findings.

(Written by Claude Opus 5.5 with medium)

kixelated and others added 2 commits November 20, 2026 17:13
…out searching beneath it

#9202 made Answer::shows build the permit's subtree intersection and
rebase the handle's scope for every claim it syncs, though nearly every
claim sits at a path both allow. Check that path directly first and keep
the search for a claim above a region.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title The 2026-11-20 relay session regressions are fixed or accepted perf(moq-net): a lite-07 answer shows a claim at an allowed path without searching beneath it Nov 21, 2026
…y-join-regressions

# Conflicts:
#	rs/moq-net/src/lite/publisher/routed.rs
#	rs/moq-net/src/model/origin.rs
@kixelated kixelated changed the title perf(moq-net): a lite-07 answer shows a claim at an allowed path without searching beneath it quest: the 2026-11-20 relay join regressions are gone on main Nov 21, 2026
@kixelated
kixelated marked this pull request as ready for review November 21, 2026 04:08
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request deletes a Markdown document that described six Relay session benchmark regressions, listed suspected pull requests, and proposed a paired local benchmark run before code changes.

Merge Risk: Minimal · up to 73ad8

This change removes a documentation file about resolved benchmark regressions. It does not alter runtime behavior, so it is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: the 2026-11-20 relay join regressions are gone on main, which matches the PR's stated finding and its deletion of the quest file. It is specific enough for a teammate scann…
Description check Passed The description states that the PR deletes quest/m0/nightly/relay-join-regressions.md because the regressions are already fixed on main, and it gives benchmark findings, the causal PR (#9202), the fix…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: the 2026-11-20 relay join regressions are gone on main, which matches the PR's stated finding and its deletion of the quest file. It is specific enough for a teammate scanning history, though it does not name the file deletion itself.

Full details: Description check

Explanation

The description states that the PR deletes quest/m0/nightly/relay-join-regressions.md because the regressions are already fixed on main, and it gives benchmark findings, the causal PR (#9202), the fixing PR (#9251), and validation. This relates directly to the changeset, which only deletes that file.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 15122596-5d03-4458-a830-dc8833b7d9fe
Commits

Reviewing files that changed from the base of the PR and between b4496b1 and 73ad8aa.

Files selected for processing: 1

  • quest/m0/nightly/relay-join-regressions.md
Files with no reviewable changes: 1

  • quest/m0/nightly/relay-join-regressions.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — the regressions were already fixed by #9251, so deleting the quest file is the right close-out.

Reviewed changes

  • Quest file deleted — quest/m0/nightly/relay-join-regressions.md is removed; no code, API, or wire changes.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit cb9cb51 Nov 21, 2026
8 checks passed
@kixelated
kixelated deleted the quest/m0/nightly/relay-join-regressions branch November 21, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant