Repository navigation
Conversation
Quest-Claim: f7e02889d0950415
…ing it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ule asks upstream Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A relay whose copy holds only the later frames of a group a subscription covers now fetches the earlier frames from upstream and serves the group whole. It names the group in SUBSCRIBE_DROP only when nothing upstream can supply them. Before, the lite publisher dropped any such group (
position_groupclamped the read to the first held frame and skipped the group), even though the model already knew how to fetch the head.Changes
position_group(rs/moq-net/src/lite/publisher.rs) asks the group whether it can fetch the missing frames (group::Consumer::fetches_from). If it can, it starts the read at the asked frame without clamping (fetching_from). If it can't, it skips the group as before.Laggedpath inresume.rs). A plain track with aRequestshandler now does the same through a flight:shed_nextboards one for a frame below the copy's offset when no front recovers it.poll_finishedjudges the end from the copy's start in that case, so the publisher's give-up check doesn't treat the missing head as a failure.settle_failedpath names the group in SUBSCRIBE_DROP.@moq/netalready behaves this way: a headless group asks a fill for its head (#askHeadintrack.ts, covered byfill.test.tsandlite/copy_fill.test.ts). It gives the group up with NotFound only when no fill serves it. No JS change was needed.quest/m2/time-addressing/range-table.mdinto that quest's Plan.Choices for review
TrackRun.Requests, not only relays. The rule is the same either way: a cache only makes things faster.Impact
Public API: none (crate-private
group::Consumer::fetches_from/fetching_from,track::flies). Wire: none. The draft's Positions rule changes for relays. This is a behavior change, so the title has no!.Validation
a_missing_head_is_fetched(a plain track with aRequestshandler) anda_relay_fetches_a_missing_head_from_its_route(an origin front whose route copy holds a headless group) both failed before the fix: the group was dropped or no fetch was ever asked. With the fix, both pass. They check that the Group Stream carries Frame Start 0 and the head before the tail, with no drop. The refused variant checks that SUBSCRIBE_DROP names the group.cargo test -p moq-net --all-featurespasses: 3485 lib tests plus the integration suites, including the existinga_missing_head_is_dropped_earlyandheld_first_group_starts_past_a_skipped_head, which still drop when no handler serves.just checkpasses.Caused by
No single PR. The drop was the draft's documented rule, which this quest (found by the 2026-11-20 subscription-rules audit) changes.
Follow-ups
None.
Models
Size: M
Implementer: Claude, claude-opus-5-5, medium effort (arm A)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: fc28267, named in full once no reviewer reports a finding
Base: origin/main at 3728b96
Risk: medium,
The missing-head fetch and group-read changes could disrupt frame delivery or completion for Rust relay subscribers, but preserve public APIs and wire compatibility, and a revert fully undoes them.Classified: medium by Codex, gpt-6.1-sol, low effort, session
01a1fc03-d832-7ba0-b12a-58c5f8b5f2cdReviewer: Codex, gpt-6.1-sol, high effort
Session:
01a1fc03-fb90-7442-bcea-8df3e3c86829, round 1Score: 6/10,
The fix needs rework because JS relays still drop recoverable groups that the change should cover.Rounds: 1; first round 1 (medium 1); findings 1 (medium 1): fixed 0, refuted 0, open 1
Findings, open until the next round settles them:
rs/moq-net/src/lite/publisher.rs:4852:Recover missing heads in the existing JS publisher too