Repository navigation
Conversation
…link's negotiated version A link may name the build whose dialers dial it, so a roll that also changes the graph replays mid-roll as each relay's build would dial. Each event records every dialed link's version as its acceptor negotiated it, replacing the inference from configured version lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The mesh replay holds one graph for the whole run, and it infers which links run moq-lite-07 from the configured version lists, counting a build with its default list as not lite-07.
Approach
build(oldornew): only a dialer on that build dials it. The relay's config leaves the others out, the mesh must be connected on either build, the roll's drain report lists the links the drained relay held, and areopen-linknaming no link picks one every build dials.negotiated version=...lines. A link's version is the one its acceptor logged on the dialer's newest session there that has not ended (the auth server'sconnect/endevents), counting only the acceptor's current process;downwhen none. Every event records the map, which replaces the inference for the route counters' lite-07 attribution.Validation
python3 test/mesh-replay/replay.test.py: 23 pass. New: the version read (partial lines, a newer session winning, an ended one, a restarted acceptor, a one-build link), a build's config dialing only its links, the graph per build and thereopen-linkdefault, the refusals, and the version table.ring4.tomlplus ana-cchord only the old build dials,half-roll.toml, the release at upstreamreleasedf1562c3bagainst this branch: passed. The report readstart: moq-lite-06 5,roll a to new: a-c: moq-lite-06 to -,roll b to new: a-b: moq-lite-06 to moq-lite-07-wip; independently,a's generated old config dials two peers and its new one onlyb.ruff checkandruff format --checkpass.Impact
No public API or wire change.
report.json'smesh.diameterbecomes a map ({"all": n}, or{"old": n, "new": m}), each event gainsversions, and each linkbuild. Mesh files gain an optionalbuildkey.Alternatives
Models
Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort
(Written by Claude Opus 5.5)