Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,12 @@ execpolicy rules, and Claude Code with only read tools and the Bash commands it
judges read-only, in `dontAsk` mode. Claude Code loads no settings files, so no
allow rule, even the user's own, widens that. Codex skips the user's config,
whose project trust would load the checkout's `.codex/config.toml` and start its
MCP servers outside the sandbox. The base is fetched first, since
MCP servers outside the sandbox. Whether those flags isolate is up to each
CLI's release, so `just review-sandbox`, in this repository, plants project MCP
servers and hooks for both CLIs on a head, runs `quest review` with the
installed CLIs and copies of your logins, and fails if any of it runs or the
review trusts a new directory. It spends real usage, so CI never runs it; run it
after upgrading either CLI. The base is fetched first, since
the sandbox has no network. The reviewer follows the base's `AGENTS.md` and `CLAUDE.md`, at the
root and in each directory holding a changed path, never the checkout's, so a
change cannot instruct its own reviewer. The base's `REVIEW.md` is optional,
Expand Down
6 changes: 6 additions & 0 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ _test:
bash scripts/lifecycle-check.sh "$PWD/dist/quest"
just worker-test

# Check that `quest review` runs nothing a reviewed head plants, with the real
# Codex and Claude Code CLIs. Uses each CLI's login and spends its usage; run it
# after upgrading either CLI. Arguments go to vitest, such as `-t codex`.
review-sandbox *args:
QUEST_LIVE=1 bun run vitest run {{args}}

# Apply formatters without changing program behavior.
fix:
bun run fix
Expand Down
1 change: 0 additions & 1 deletion quest/m0/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ ownership-manifest design:
- [Kix decision UI](/quest/m0/kix/README.md) - planning and implementation through prompts and summaries, run on the maintainer's own runners
- [Codex cloud off](/quest/m0/codex-cloud-off.md) - automatic Codex cloud reviews stop once no open PR relies on them
- [Review handles expired and environment logins](/quest/m0/review-login.md) - `quest review` says to log in again instead of failing with a 401, and reviews with credentials from the environment
- [Live sandbox test](/quest/m0/review-sandbox.md) - the real reviewer CLIs run nothing a reviewed head plants
- [Agent test environment](/quest/m0/agent-test-env.md) - `just test` passes inside agent sessions
- [Stale skill stubs](/quest/m0/init-prune.md) - `quest init` and `quest uninstall` remove stubs of retired skills such as `quest-ready`
- [Bun EFAULT report](/quest/m0/bun-efault.md) - condition: Bun fixes concurrent `rmSync` on Windows; report it, then drop the workaround
Expand Down
2 changes: 1 addition & 1 deletion quest/m0/codex-project-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ Decided 2026-10-28 (user, /quest-plan of the follow-ups from [moq-dev/quest#271]
- Do not post upstream, on #49333 or a new issue; the maintainer declined.
Only watch for the change.
- This quest waits on Codex. Check #49333 and Codex release notes each time
ready work is triaged; [the live sandbox test](/quest/m0/review-sandbox.md)
ready work is triaged; the live sandbox test, `just review-sandbox`,
catches a release that changes the behavior first.
8 changes: 2 additions & 6 deletions quest/m0/review-harness.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,10 @@ Decided 2026-10-28 (user, /quest-plan of the follow-ups from [moq-dev/quest#271]
the default tier is the newest general model at medium effort, and the deep
tier the strongest one. Bump any that are stale, and check that both CLIs
accept the new ids.
- Run [the live sandbox test](/quest/m0/review-sandbox.md) with the CLIs
installed at the time, and plan a quest for any failure.
- Run the live sandbox test, `just review-sandbox`, with the CLIs installed
at the time, and plan a quest for any failure.
- This quest recurs. The PR that finishes this run creates
`/quest/m1/review-harness.md` with this Goal, listed in m1's `Required`,
and `Required: /quest/m0/README.md`, so the next run becomes ready when m0
completes. Each run creates the next milestone's run the same way, carrying
forward the model ids it found and anything to check first.

## Required

- [Live sandbox test](/quest/m0/review-sandbox.md) - the test each run executes
28 changes: 0 additions & 28 deletions quest/m0/review-sandbox.md

This file was deleted.

Loading
Loading