Repository navigation
test: make the usage and review tests host-independent - #715
Merged
Merged
Conversation
Quest-Claim: 1950d7707f24f52a
…ENAI_BASE_URL Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 13, 2026 23:48
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
enabled auto-merge
November 13, 2026 23:48
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the full diff of the two commits on this PR.
test/usage.test.ts: the deleted-checkout fixtures now use temp directories the test creates and removes (WORK,OTHER_WORK), so a host with a real/workno longer changes the attribution. Every remainingcwdin the file already points at a git repo the test creates.test/review.test.ts:setup()unsetsOPENAI_BASE_URL, whichsrc/cli/review.tsreads, so the direct 429 case no longer turns into a usage limit on hosts that set it.quest/m0/host-independent-tests.md: the finished quest file is removed.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Finishes
quest/m0/host-independent-tests.md.test/usage.test.ts: fixture sessions in deleted checkouts used/work,/work/nested, and/other, which a host with a real/workreads. They now use temporary directories the test creates and removes.test/review.test.ts: the review readsOPENAI_BASE_URL(src/cli/review.ts863, 1686) andsetup()didn't clear it, so a host with it set turned the direct 429 into a usage limit (exit 3, not 1).setup()now unsets it. Reproduced withOPENAI_BASE_URLset: fails before, passes after./workwas absent here, so the usage failure was fixed from the code. #704 rewritestest/usage.test.ts; whichever lands second should point itsexportedfixture atWORK.just checkandjust testpass.🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with low)
Models
Review
Rewritten by
quest reviewafter each round.Head: e39cbf6
Base: origin/main at b62403e
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1d74f-8858-7b60-b665-8cbba66175e7, round 1Score: 10/10,
Code inspection found no introduced defects: the changes isolate fixture paths and clear the ambient gateway setting without changing production behavior; builds and tests were not run, as instructed.Rounds: 1; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1d74f-8858-7092-99f6-4edb0d041ccd, round 1Score: 9/10,
The focused changes address the identified host dependencies without actionable defects found by code inspection; builds and tests were not run as instructed.Rounds: 1; findings 0: fixed 0, refuted 0, open 0
Findings: none