Skip to content

test: make the usage and review tests host-independent - #715

Merged
moq-bot[bot] merged 2 commits into
mainfrom
quest/m0/host-independent-tests
Nov 13, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
quest/m0/host-independent-tests

Conversation

@kixelated

@kixelated kixelated commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/host-independent-tests.md.

  • test/usage.test.ts: fixture sessions in deleted checkouts used /work, /work/nested, and /other, which a host with a real /work reads. They now use temporary directories the test creates and removes.
  • test/review.test.ts: the review reads OPENAI_BASE_URL (src/cli/review.ts 863, 1686) and setup() didn't clear it, so a host with it set turned the direct 429 into a usage limit (exit 3, not 1). setup() now unsets it. Reproduced with OPENAI_BASE_URL set: fails before, passes after.

/work was absent here, so the usage failure was fixed from the code. #704 rewrites test/usage.test.ts; whichever lands second should point its exported fixture at WORK.

just check and just test pass.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with low)

Models

  • claude-opus-5-5 low: implementation

Review

Rewritten by quest review after each round.

  • Head: e39cbf6

  • Base: origin/main at b62403e

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d74f-8858-7b60-b665-8cbba66175e7, round 1

  • Score: 10/10, Code inspection found no introduced defects: the changes isolate fixture paths and clear the ambient gateway setting without changing production behavior; builds and tests were not run, as instructed.

  • Rounds: 1; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1d74f-8858-7092-99f6-4edb0d041ccd, round 1

  • Score: 9/10, The focused changes address the identified host dependencies without actionable defects found by code inspection; builds and tests were not run as instructed.

  • Rounds: 1; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 13, 2026 15:46
…ENAI_BASE_URL

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Make the usage and review tests host-independent test: make the usage and review tests host-independent Nov 13, 2026
@kixelated
kixelated marked this pull request as ready for review November 13, 2026 23:48
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b75ffca9-6b66-4850-b2d3-0561777dd14b
Commits

Reviewing files that changed from the base of the PR and between b62403e and e39cbf6.

Files selected for processing: 3

  • quest/m0/host-independent-tests.md
  • test/review.test.ts
  • test/usage.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 13, 2026 23:48

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the full diff of the two commits on this PR.

  • test/usage.test.ts: the deleted-checkout fixtures now use temp directories the test creates and removes (WORK, OTHER_WORK), so a host with a real /work no longer changes the attribution. Every remaining cwd in the file already points at a git repo the test creates.
  • test/review.test.ts: setup() unsets OPENAI_BASE_URL, which src/cli/review.ts reads, so the direct 429 case no longer turns into a usage limit on hosts that set it.
  • quest/m0/host-independent-tests.md: the finished quest file is removed.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 436c535 Nov 13, 2026
26 checks passed
@moq-bot
moq-bot Bot deleted the quest/m0/host-independent-tests branch November 13, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant