Repository navigation
feat(gate)!: remove the gate's quick flag - #750
Conversation
Quest-Claim: cc47c99804817b05
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
I reviewed the whole change that removes quest gate --quick. Every reference to quick admission is gone across the scheduler, the CLI, the docs, the lifecycle script and the tests. A repo-wide search at the head commit finds no remaining --quick, QUICK_MS or .quick.
- Admission no longer times out:
admitdropsdeadlineand the earlyadmitted(now)exit. For gates that never passed the flag nothing changes, because their deadline wasInfinityandMath.min(wait, Infinity - now)already equalledwait. - CLI surface: the
--quickoption and its help text are removed.gateBoundary'sskipno longer takes a list of gate-only flags, so only the global--rootis skipped before the gated command. - Lifecycle check:
scripts/lifecycle-check.shnow runsgate env, which still exercises the.envisolation test. - Docs and tests: the README drops the quick paragraph and the "no timeout except
--quick's" caveat. The tests that only covered quick are removed, and the shared priority tests keep their priority half. - Quest bookkeeping: deletes
quest/m0/gate-quick.mdand its link inquest/m0/benchmark/gating.md.
claude-opus-5-5 | 𝕏

Finishes
quest/m0/gate-quick.md:quest gatehas no--quickflag and admission has no quick precedence.Summary
src/cli/gate.ts: dropsQUICK_MS,Precedence.quick,GateOptions.quick, andadmit's deadline, so admission never times out;Precedencekeeps onlypriority.src/cli/main.ts: drops the option and its help text;gateBoundaryno longer knows a gate option of its own (only the global--root).scripts/lifecycle-check.shrunsquest gate env.README.md: drops the--quickparagraph and the "no timeout except--quick's" caveat; the priority paragraph stands alone.--quickparsing tests.quest/m0/benchmark/gating.md.Public API
Breaking CLI change:
quest gate --quick <command>now fails withunknown option '--quick'(exit 2). To migrate, drop the flag; for a cheap command such as a formatter, leave it out of the gate asquest contextsays. No wire or on-disk change: the ledger format is unchanged. No repository script passes it outside Quest's own lifecycle check, which this PR updates.Validation
quest gate just checkandquest gate just testpass, on the head merged with the currentmain.quest gate --quick trueexits 2 withunknown option '--quick';quest gate trueexits 0;quest gate --helpmentions quick only in "leave ... quick tools such as formatters out of the gate".Infinityfor them, sohost.sleep(Math.min(wait, deadline - now))equalshost.sleep(wait).quest/m0/benchmark/gating.md's PR are expected, since it also touches the gate.Models
Size: XS
Implementer: Claude, claude-sonnet-5-5, unknown effort (arm A)
(Written by Claude Sonnet 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 43ddedc
Base: origin/main at 1dd857d
Risk: medium,
Removing `quest gate --quick` breaks callers using that option and makes gated commands wait indefinitely for admission under sustained contention; reverting restores the option and prior scheduling behavior.Classified: medium by Codex, gpt-6.1-sol, low effort, session
01a1e05c-119b-7d40-8413-67fc06d92457Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1e05c-2719-7c40-935f-5dd358ce1762, round 1Score: 9/10,
The change consistently removes quick admission across the CLI, scheduler, documentation, and tests and updates the lifecycle caller, with no actionable defects found by inspection; builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1e05c-2718-76f0-aa37-e0017f150050, round 1Score: 9/10,
Quick admission is consistently removed from the CLI, scheduling logic, documentation, and tests, with no remaining references found by inspection; builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none