Skip to content

feat(gate)!: remove the gate's quick flag - #750

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/gate-quick
Nov 15, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/gate-quick

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/gate-quick.md: quest gate has no --quick flag and admission has no quick precedence.

Summary

  • src/cli/gate.ts: drops QUICK_MS, Precedence.quick, GateOptions.quick, and admit's deadline, so admission never times out; Precedence keeps only priority.
  • src/cli/main.ts: drops the option and its help text; gateBoundary no longer knows a gate option of its own (only the global --root).
  • scripts/lifecycle-check.sh runs quest gate env.
  • README.md: drops the --quick paragraph and the "no timeout except --quick's" caveat; the priority paragraph stands alone.
  • Tests: removes the two quick admission tests, the quick half of the shared priority tests, and the --quick parsing tests.
  • Deletes the quest and the link to it from quest/m0/benchmark/gating.md.

Public API

Breaking CLI change: quest gate --quick <command> now fails with unknown option '--quick' (exit 2). To migrate, drop the flag; for a cheap command such as a formatter, leave it out of the gate as quest context says. No wire or on-disk change: the ledger format is unchanged. No repository script passes it outside Quest's own lifecycle check, which this PR updates.

Validation

  • quest gate just check and quest gate just test pass, on the head merged with the current main.
  • Built CLI: quest gate --quick true exits 2 with unknown option '--quick'; quest gate true exits 0; quest gate --help mentions quick only in "leave ... quick tools such as formatters out of the gate".
  • No behavior change for gates without the flag: the removed deadline was Infinity for them, so host.sleep(Math.min(wait, deadline - now)) equals host.sleep(wait).
  • Merge conflicts with quest/m0/benchmark/gating.md's PR are expected, since it also touches the gate.

Models

Size: XS
Implementer: Claude, claude-sonnet-5-5, unknown effort (arm A)

(Written by Claude Sonnet 5.5)

Review

Rewritten by quest review after each round.

  • Head: 43ddedc

  • Base: origin/main at 1dd857d

  • Risk: medium, Removing `quest gate --quick` breaks callers using that option and makes gated commands wait indefinitely for admission under sustained contention; reverting restores the option and prior scheduling behavior.

  • Classified: medium by Codex, gpt-6.1-sol, low effort, session 01a1e05c-119b-7d40-8413-67fc06d92457

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e05c-2719-7c40-935f-5dd358ce1762, round 1

  • Score: 9/10, The change consistently removes quick admission across the CLI, scheduler, documentation, and tests and updates the lifecycle caller, with no actionable defects found by inspection; builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1e05c-2718-76f0-aa37-e0017f150050, round 1

  • Score: 9/10, Quick admission is consistently removed from the CLI, scheduling logic, documentation, and tests, with no remaining references found by inspection; builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

@kixelated kixelated changed the title Remove the gate's quick flag feat(gate)!: remove the gate's quick flag Nov 15, 2026
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 17:58
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 799ae3a9-3e8a-473c-a93a-6c64d4da7895
Commits

Reviewing files that changed from the base of the PR and between f3bf9ca and 43ddedc.

Files selected for processing: 7

  • README.md
  • quest/m0/benchmark/gating.md
  • quest/m0/gate-quick.md
  • scripts/lifecycle-check.sh
  • src/cli/gate.ts
  • src/cli/main.ts
  • test/gate.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

I reviewed the whole change that removes quest gate --quick. Every reference to quick admission is gone across the scheduler, the CLI, the docs, the lifecycle script and the tests. A repo-wide search at the head commit finds no remaining --quick, QUICK_MS or .quick.

  • Admission no longer times out: admit drops deadline and the early admitted(now) exit. For gates that never passed the flag nothing changes, because their deadline was Infinity and Math.min(wait, Infinity - now) already equalled wait.
  • CLI surface: the --quick option and its help text are removed. gateBoundary's skip no longer takes a list of gate-only flags, so only the global --root is skipped before the gated command.
  • Lifecycle check: scripts/lifecycle-check.sh now runs gate env, which still exercises the .env isolation test.
  • Docs and tests: the README drops the quick paragraph and the "no timeout except --quick's" caveat. The tests that only covered quick are removed, and the shared priority tests keep their priority half.
  • Quest bookkeeping: deletes quest/m0/gate-quick.md and its link in quest/m0/benchmark/gating.md.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit c12e2b1 Nov 15, 2026
27 checks passed
@kixelated
kixelated deleted the quest/m0/gate-quick branch November 15, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant