Skip to content

docs(audit): fix what let each finding in, so the next run finds none - #781

Merged
kixelated merged 1 commit into
mainfrom
audit-prevent-recurrence
Nov 19, 2026
Merged

kixelated merged 1 commit into
mainfrom
audit-prevent-recurrence

Conversation

@kixelated

@kixelated kixelated commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Every audit run now fixes the cause of each kind of finding, not only its instances, so the next run finds fewer. The fix can be a fast gate check, a test, a simpler design, or an AGENTS.md rule, which goes under ## Waiting because agent instructions change only on the maintainer's yes.

This adds one line to assets/audit.md's Findings section, which every audit run reads. It replaces the code audit's narrower "add a check to the gate" line, which now says the same thing twice.

Public API

None. Only the shipped audit text changes.

Validation

No behavior to exercise: this is a prompt-text change. Ran just check and just test; both pass.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 1f750e2

  • Base: origin/main at 3ddd1af

  • Risk: high, The shared audit instructions broaden required fixes across repositories using Quest, potentially causing unwanted code or workflow changes whose effects remain after reverting the instructions.

  • Classified: high by Codex, gpt-6.1-sol, low effort, session 01a1f5a7-db9b-7912-bfe1-6f374511345f

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f5a8-0d4e-7273-95b5-cfc5f16f4fc9, round 1

  • Score: 10/10, The change consistently moves recurrence-prevention guidance into the shared audit workflow while preserving maintainer approval for instruction changes, with no actionable defects found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1f5a8-0d4d-75a2-9a15-140894db96b2, round 1

  • Score: 10/10, The instruction-only change consistently moves recurrence prevention into the shared audit instructions without introducing a concrete defect and is ready to land.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 19, 2026 21:13
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 15c773f4-bcac-4683-87f9-05a89f9d3707
Commits

Reviewing files that changed from the base of the PR and between 80cd2c8 and 1f750e2.

Files selected for processing: 2

  • assets/audit.md
  • assets/audits/code.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 19, 2026 21:15

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — the recurrence-prevention rule lives once in the shared audit text, so every audit kind inherits it, and instruction changes still wait on the maintainer.

Reviewed changes

Reviewed the full diff of the two prompt files.

  • assets/audit.md: adds a Findings line to fix what let each kind of finding in. It points to quest guide prompting, which exists as ## Prompting in assets/AGENTS.md.
  • assets/audits/code.md: drops the narrower "add a check to the gate" clause, which the new shared line now covers.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 52c29ad Nov 19, 2026
28 checks passed
@kixelated
kixelated deleted the audit-prevent-recurrence branch November 19, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant