Skip to content

Point to token-max - #785

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/token-waste/token-max
Nov 19, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/token-waste/token-max

Conversation

@kixelated

@kixelated kixelated commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

token-max 0.0.1 is out (crates.io and GitHub Releases), so Quest now points to it:

  • SETUP.md gets a Check agent settings section. The setup agent offers token-max's run-once lines (curl -LsSf https://max.kixel.ai/run.sh | sh, or irm https://max.kixel.ai/run.ps1 | iex on native Windows) and runs them with the user's consent. It says that run without a terminal, as an agent runs it, token-max doctor only prints its report and exits 1 when it recommends a change. The section also names cargo install --locked token-max for quest usage and the records sender, and says to ask first because that install is global.
  • The missing-token-max hints in src/cli/send.ts and src/cli/usage.ts now name the published crate (cargo install --locked token-max) instead of --git https://github.com/kixel-ai/token-max.
  • This PR deletes the finished quest quest/m0/token-waste/token-max.md. That leaves the token-waste epic with no children, so its README is now the epic's remaining work (the closing re-measure) and is sized [S], as quest check requires.

Public API and wire: none. Two error messages change.

Choices for review

  • I placed the section after "Configure the user's agent", since both are about the user's own agent settings, not the repository's.
  • The Plan said only "point at its run-once lines". I added the headless/exit-1 behavior after running it, because an agent running the line would otherwise read exit 1 as a failure. I also added that doctor writes settings only after a final yes on a terminal.
  • I sized the remaining epic [S]. Its work is one week of quest usage and token-max runs compared against the recorded baseline.

Validation

  • Ran sh run.sh --since 2026-11-17 </dev/null (the script served at max.kixel.ai): it downloaded v0.0.1 for x86_64-unknown-linux-musl, verified it, printed the doctor report ending "Nothing was changed", and exited 1. token-max doctor --help confirms exit 1 means "changes recommended" when there is no terminal.
  • curl https://max.kixel.ai/run.ps1 returns 200 and is the documented PowerShell runner. I did not run it, because no Windows host was involved.
  • cargo install --locked token-max --root .tmp/tm (nixpkgs cargo) installed token-max v0.0.1, and token-max --version printed 0.0.1.
  • quest usage --pr 785 with token-max removed from PATH printed: token-max is not installed, so no session tokens or cost are reported; install it with \cargo install --locked token-max``.
  • just check and just test pass. quest check --base origin/main passes.

Caused by

None: the old hints predate the crate's publication.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, medium effort (arm B)

Review

Rewritten by quest review after each round.

  • Head: e445b9b

  • Base: origin/main at e10252e

  • Risk: medium, The changed CLI installation hints could direct users to a different token-max version and affect their usage or record-pricing setup; reverting restores the hints, while documentation and plan changes add no runtime risk.

  • Classified: medium by Codex, gpt-6.1-sol, low effort, session 01a1f2d5-573a-7052-89f6-d02cd01c6759

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f2d5-75c3-71c3-83fa-d63b5ef3a6ac, round 1

  • Score: 10/10, The scoped diff adds consent-based token-max setup guidance and updates installation hints to the published crate without changing runtime behavior; no actionable defects were found by inspection, and builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1f2d5-75c3-7443-8a0b-f7ea91177d7a, round 1

  • Score: 10/10, The changes update token-max installation guidance without changing runtime behavior, and no actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 18, 2026 23:44
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 19, 2026 08:04
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0fada217-3e83-41f8-b2eb-1637ecfe7c23
Commits

Reviewing files that changed from the base of the PR and between 00c72eb and e445b9b.

Files selected for processing: 5

  • SETUP.md
  • quest/m0/token-waste/README.md
  • quest/m0/token-waste/token-max.md
  • src/cli/send.ts
  • src/cli/usage.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. It points setup at token-max's published run-once lines and crate, and finishes the quest by deleting its file.

Reviewed changes

Reviewed the full diff of 5 files, and grepped for leftover references to the deleted quest and the old --git hint (none).

  • SETUP.md: adds a "Check agent settings" section with the consent-gated run-once lines, the headless exit-1 behavior, and a note to ask before the global cargo install --locked token-max.
  • src/cli/send.ts, src/cli/usage.ts: the missing-token-max hints now name the published crate.
  • quest/m0/token-waste/: deletes the finished token-max.md quest and sizes the epic README [S].

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 3ddd1af Nov 19, 2026
25 checks passed
@kixelated
kixelated deleted the quest/m0/token-waste/token-max branch November 19, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant