Skip to content

ci: install Nix with cachix/install-nix-action - #788

Merged
kixelated merged 1 commit into
mainfrom
ci/cachix-install-nix-action
Nov 20, 2026
Merged

kixelated merged 1 commit into
mainfrom
ci/cachix-install-nix-action

Conversation

@kixelated

@kixelated kixelated commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Switches every workflow that installed Nix with DeterminateSystems/nix-installer-action and determinate: false to cachix/install-nix-action (v32.0.0, pinned by commit like the other actions). DeterminateSystems' v23 release calls determinate: false unsupported and may remove it, which would break CI without warning; the cachix action installs upstream Nix by design, matching the nixpkgs Nix the dev shells use. Maintainer's decision: kixel-ai/token-max#177 (comment)

The installed Nix is now upstream 2.36.0 (from the action) instead of the Determinate action's pinned upstream build.

pullfrog.yml needed more than a swap: the cachix action has no github-token input and always writes the job token into nix.conf when github_access_token is empty, so a step now deletes that line before the agent can read /etc/nix. trust-runner-user: false becomes set_as_trusted_user: false, and the /nix/receipt.json check goes, since upstream Nix writes none.

Public API

None: CI only, no CLI or wire change.

Validation

  • just check and just test pass locally.
  • check.yml (both jobs) runs the new installer on this PR's CI.
  • pullfrog.yml and release.yml only run from main (environment and schedule), so I ran the Pullfrog install, token-removal, and dev-shell steps verbatim in a throwaway push-triggered workflow on a scratch branch (since deleted): run passed, including the existing "job token reached Nix's config" and "daemon trusts the runner user" guards, and nix develop worked. The release.yml change is the same plain install as check.yml's, and is not exercised until the next release run.

Models

Size: XS
Implementer: Claude Code, claude-sonnet-5-5, unknown effort

Review

Rewritten by quest review after each round.

  • Head: ae0cfaa

  • Base: origin/main at 8a8c899

  • Risk: high, it changes .github/workflows/check.yml, which is always high, as are 2 more of its paths: workflows run with the repository's secrets and decide what merges and ships

  • Classified: high by the always-high paths

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1fa4a-7c1a-7340-b355-a1f5a9667bcc, round 1

  • Score: 8/10, The workflow changes appear consistent and no actionable regressions were identified, but builds and tests were not run as instructed, and network restrictions prevented verifying the pinned action's implementation.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1fa4a-7c1a-7583-92be-05c19bf99f6e, round 1

  • Score: 9/10, No actionable defects were found and the installer replacement preserves relevant configuration safeguards, but builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

DeterminateSystems' v23 release calls determinate: false unsupported and may remove it. The cachix action installs upstream Nix by design, matching the nixpkgs Nix the dev shells use.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 20, 2026 18:49
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The check, lifecycle, build, and Pullfrog workflows replace the Determinate Systems Nix installer with cachix/install-nix-action. Pullfrog configures the installer not to trust the runner user, removes access-tokens entries from /etc/nix/nix.conf, and limits the token-leak check to /etc/nix.

Merge Risk: Minimal · up to ae0cf

This swaps the CI Nix installer for the Cachix action and keeps the Pullfrog token-leak protections. No merge-blocking risk was found. The release workflow will first run the new installer at the next release.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "ci: install Nix with cachix/install-nix-action" matches the main change. All three workflows (check.yml, pullfrog.yml, release.yml) swap the Nix installer from DeterminateSystems/nix-instal…
Description check Passed The description states the change: every workflow that installed Nix switches from DeterminateSystems/nix-installer-action to cachix/install-nix-action v32.0.0. It gives the reason (the determinate in…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: install Nix with cachix/install-nix-action" matches the main change. All three workflows (check.yml, pullfrog.yml, release.yml) swap the Nix installer from DeterminateSystems/nix-installer-action to cachix/install-nix-action. The title is specific, short, and follows a conventional commit style.

Full details: Description check

Explanation

The description states the change: every workflow that installed Nix switches from DeterminateSystems/nix-installer-action to cachix/install-nix-action v32.0.0. It gives the reason (the determinate input is unsupported in v23) and describes the pullfrog.yml follow-up edits, the nix.conf token removal, and the receipt.json check removal. It also covers validation. This matches the raw summary and objectives.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ef2d166e-fda6-4f2f-bf86-0a84d7e585cc
Commits

Reviewing files that changed from the base of the PR and between 8a8c899 and ae0cfaa.

Files selected for processing: 3

  • .github/workflows/check.yml
  • .github/workflows/pullfrog.yml
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — swaps to the upstream-Nix installer in every workflow, and keeps the job token out of /etc/nix with an explicit step plus the existing grep guard.

Reviewed changes

Reviewed the full diff of the single commit across the three workflow files.

  • check.yml: both jobs now use cachix/install-nix-action pinned by commit (v32.0.0).
  • pullfrog.yml: uses set_as_trusted_user: false. A new step deletes the access-tokens line from nix.conf before the agent runs. The token guard now greps only /etc/nix, since upstream Nix writes no receipt.
  • release.yml: the same plain installer swap.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit eaee1d5 Nov 20, 2026
25 checks passed
@kixelated
kixelated deleted the ci/cachix-install-nix-action branch November 20, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant