Repository navigation
ci: install Nix with cachix/install-nix-action - #788
Conversation
DeterminateSystems' v23 release calls determinate: false unsupported and may remove it. The cachix action installs upstream Nix by design, matching the nixpkgs Nix the dev shells use. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughThe check, lifecycle, build, and Pullfrog workflows replace the Determinate Systems Nix installer with Merge Risk:
|
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — swaps to the upstream-Nix installer in every workflow, and keeps the job token out of /etc/nix with an explicit step plus the existing grep guard.
Reviewed changes
Reviewed the full diff of the single commit across the three workflow files.
check.yml: both jobs now usecachix/install-nix-actionpinned by commit (v32.0.0).pullfrog.yml: usesset_as_trusted_user: false. A new step deletes theaccess-tokensline fromnix.confbefore the agent runs. The token guard now greps only/etc/nix, since upstream Nix writes no receipt.release.yml: the same plain installer swap.
claude-sonnet-5-5 | 𝕏

Switches every workflow that installed Nix with
DeterminateSystems/nix-installer-actionanddeterminate: falsetocachix/install-nix-action(v32.0.0, pinned by commit like the other actions). DeterminateSystems' v23 release callsdeterminate: falseunsupported and may remove it, which would break CI without warning; the cachix action installs upstream Nix by design, matching the nixpkgs Nix the dev shells use. Maintainer's decision: kixel-ai/token-max#177 (comment)The installed Nix is now upstream 2.36.0 (from the action) instead of the Determinate action's pinned upstream build.
pullfrog.ymlneeded more than a swap: the cachix action has nogithub-tokeninput and always writes the job token intonix.confwhengithub_access_tokenis empty, so a step now deletes that line before the agent can read/etc/nix.trust-runner-user: falsebecomesset_as_trusted_user: false, and the/nix/receipt.jsoncheck goes, since upstream Nix writes none.Public API
None: CI only, no CLI or wire change.
Validation
just checkandjust testpass locally.check.yml(both jobs) runs the new installer on this PR's CI.pullfrog.ymlandrelease.ymlonly run frommain(environment and schedule), so I ran the Pullfrog install, token-removal, and dev-shell steps verbatim in a throwaway push-triggered workflow on a scratch branch (since deleted): run passed, including the existing "job token reached Nix's config" and "daemon trusts the runner user" guards, andnix developworked. Therelease.ymlchange is the same plain install ascheck.yml's, and is not exercised until the next release run.Models
Size: XS
Implementer: Claude Code, claude-sonnet-5-5, unknown effort
Review
Rewritten by
quest reviewafter each round.Head: ae0cfaa
Base: origin/main at 8a8c899
Risk: high,
it changes .github/workflows/check.yml, which is always high, as are 2 more of its paths: workflows run with the repository's secrets and decide what merges and shipsClassified: high by the always-high paths
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1fa4a-7c1a-7340-b355-a1f5a9667bcc, round 1Score: 8/10,
The workflow changes appear consistent and no actionable regressions were identified, but builds and tests were not run as instructed, and network restrictions prevented verifying the pinned action's implementation.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1fa4a-7c1a-7583-92be-05c19bf99f6e, round 1Score: 9/10,
No actionable defects were found and the installer replacement preserves relevant configuration safeguards, but builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none