Skip to content

The REVIEW page - #177

Merged
kixelated merged 15 commits into
mainfrom
quest/m0/ux/review
Nov 16, 2026
Merged

kixelated merged 15 commits into
mainfrom
quest/m0/ux/review

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Claims, implements, and deletes quest/m0/ux/review.md: the REVIEW page from mock/review.html.

Summary

REVIEW is now two halves, as in the mock-up:

  • Replay (left): a large picture of the head, a "replay what" column naming the replay source, a strip of the last 30 seconds (one picture per keyframe, a sound wave row under it, a ruler with AIR/AGO tags), two amber handles that pick the stretch, a head you drag to scrub, speed segments, and the big actions (Replay, Save clip). When a replay can't run, the strip says why: no replay source, sound only below 100%, the window not yet held, or a stretch that has aged out.
  • This show (right column): a card for the recording under way, then a card for each finished recording, repair and clip in the recordings folder, newest first, with its length, size and age, plus the free space. Clicking a card opens the file; the folder button opens the folder. Failed recordings show ERR.

Also part of this PR:

  • Clips now save into the recordings folder as <show>-clip-<n>.mp4, so they show up on the shelf. That folder still defaults to the one beside the scene file.
  • The top bar's record button shows the elapsed time.
  • Settings gains a Recording tab (folder, Open, Picture, Sound, Each source too, the repair note), taken from the mock's settings-recording frame.
  • New modules rs/moq-studio/src/past.rs (the strip's decode worker) and rs/moq-studio/src/shelf.rs (the folder listing). replay::Stretch replaces the fixed lengths.

The quest file is deleted: the two items left on it became follow-up quests (see Decisions and Follow-ups).

Views

View Mock-up
review review mock review
review_picked (a stretch picked, no replay source yet, so the refusal shows) review_picked same frame
review_into (a show with two replay sources: which one Replay plays in is picked under the speed, in place of its note) review_into same frame (the mock-up has one replay source)
recording (Settings, beside main's Show, Hotkeys, Effects, Advanced) recording mock settings recording
kit (new icons: Folder, Save, Repaired) kit

Public API and wire impact

None. moq-studio is a binary; nothing in moq-scene or the moq submodule changes, and no wire format changes. The user-visible behavior change is that clips are saved into the recordings folder instead of beside the scene file. Both are the same folder unless --recordings is set. README covers it.

Choices made

  • Two handles pick the stretch, as the quest's Plan recommended, in place of fixed lengths. A stretch pinned to the right edge (within 8 px) follows the live edge (Stretch::Last); otherwise it is fixed to two instants (Stretch::Between) and is refused once it ages out of the 30 s window.
  • Strip pictures are per keyframe. The worker decodes only each group's first frame, at 480 px wide, about once a second, so it costs one small decode per group, not a full decode of the window.
  • Card ages are relative ("2 days ago") because the app reads no time zone. The file name keeps the absolute stamp.
  • Clicking a card opens the file in the system player (xdg-open, open, explorer). There is no in-app playback of finished files.
  • Settings gets a Recording tab for the mock's settings-recording frame. The recording options (picture, sound, each source) moved there from the old recording panel on REVIEW, since the record button works from any page.
  • Replay destination picker only with more than one replay source. The "replay what" column picks what is replayed; with one replay source the page is as in the mock-up, and with several, an "Into" picker takes the speed note's row (no spare height there) and the Replay button's note says "with no sound" below 100% instead. Main had this picker in the old panel; round 1 of the review caught its loss.
  • Strip picture ids are process-wide (LAST_ID in past.rs), and the shelf runs one listing at a time, both from review round 1.
  • An aged-out stretch is freed by its end handle: where both handles are in reach, a press takes the one on its side (grip_at).
  • just shots' settle skips an idle replay source's track, which starts only with its first replay (Feed::publish in moq-scene runs from replay).
  • Lengths come from mvhd via mp4-atom (already a dev-dependency, now a dependency), skipping mdat by seeking, so listing stays cheap on large files.
  • Free space reads statvfs (rustix) on unix and GetDiskFreeSpaceExW on Windows.

Validation

  • Merged main (BUILD with layers and the inspector, moq-dev/studio#174; Studio mode and editing off air, moq-dev/studio#176; panic hides the top layer, moq-dev/studio#179). REVIEW replaces main's replay-and-record panels as before; the Recording tab joins Settings' Show, Hotkeys, Effects, Advanced; the Replay hotkeys sit beside the new StudioMode action; README keeps main's page rows and wording (layers, always on top) with REVIEW's row. On the merged head just ci passes (347 tests) and just shots renders all 32 views; the four views above are re-rendered from it.

  • just ci passed before the merge (340 tests), including clippy with the capture, pipewire, vaapi, openh264 features.

  • the_program_reaches_a_relay (lavapipe, openh264) now also checks the strip: its pictures decode from the live program's keyframes, are the canvas red, 480 wide, in order, and its sound peaks are in range and in order.

  • New unit tests: a_press_takes_the_handle_on_its_side, a_hotkey_takes_the_last_stretch_as_long, stretch_tests (spans, clamping, aging out, empty stretches), shelf::names_read_back and the_folder_lists_cards (name parsing, repairs, clips, mvhd lengths), and the review sizes, clock and cover helpers.

  • just shots renders review, review_picked, review_into, recording and kit still (each renders twice and matches).

  • UI frame CPU in a release build over 120 kittest steps: LIVE 68.87 µs, REVIEW 92.63 µs per frame. I used a throwaway test for this and did not commit it.

  • UI frame time under headless sway (sway 1.12, 1440x900@60, Mesa 26.3 RADV on the host's AMD Radeon 610M; no NVIDIA GPU, so the program is encoded with openh264 in software). Both builds are release with openh264, opened on REVIEW, publishing to a local moq-relay (--connect https://localhost:4443/anon), on shots/show.toml plus a looping clip.mp4 in Main and a replay source. On this branch the strip fills with the program's keyframes, and Replay and Save clip are enabled. An uncommitted patch logged the frame interval and the UI thread's on-CPU time (/proc/thread-self/schedstat) per 300 frames, dropping the first two windows; each thread's on-CPU ticks (100 Hz) were read 55 s in. Four alternating 60 s rounds, host load average 28 to 45 from other agents.

    Round main (99d8c3b) REVIEW: interval / UI thread per frame This branch REVIEW Strip worker review-past
    1 16.97 ms / 1.13 ms 16.89 ms / 1.27 ms 114 ticks (2.1% of a core)
    2 17.32 ms / 1.15 ms 17.12 ms / 1.51 ms 129 ticks
    3 16.81 ms / 0.94 ms 17.26 ms / 1.54 ms 137 ticks
    4 16.98 ms / 1.03 ms 17.05 ms / 1.24 ms 114 ticks

    Both hold the display's 60 fps. The new page costs the UI thread about 0.3 ms more per frame (1.39 ms against 1.06 ms, 8% of a 16.7 ms frame), and the strip's worker about 2 to 2.5% of one core while REVIEW is shown. The software encoder dominates both builds (1050 to 1350 ticks).

  • That sway run is also the real app against a relay; scrubbing and picking by hand are left to try-review, since an agent cannot judge feel.

Decisions

Taken by the agent on the maintainer's behalf while they were away, as recommended; each is for review:

  • Pictures on finished recording and clip cards: ✅ decode through moq-mux's regular MP4 import (moq-dev/moq quest m3/mp4-import) (rejected: reading the first sample here with mp4-atom, since AGENTS.md puts demuxing in moq; dropping the pictures from the mock-up). That import is not on moq's main, so this PR keeps the placeholder tile and the pictures become follow-ups. They sit in m3 beside moq's import, which the maintainer placed in moq's m3 on 2026-11-05; a quest cannot require a later milestone, so moving them up means moving the import up too.
  • What a Replay or Save clip fired outside REVIEW takes (Pullfrog's finding, then review round 3, which hit the design checkpoint): ✅ a hotkey, or the shell's clip button beside the panic key (which shows the same key), takes the last seconds as long as REVIEW's pick; REVIEW's own buttons honor a stretch fixed between two moments (rejected: always the pick as is, which replays an old moment and refuses 30 s later; turning a fixed pick into "the last N seconds" on leaving REVIEW, which rewrites the user's pick behind their back; using the fixed pick until it ages out, so one key does different things depending on age). The button's tooltip and README's Hotkeys paragraph say so.
  • The human feel check (scrubbing and picking a stretch with a relay, the page against the mock-up, the strip's labels at a normal window size): ✅ a follow-up quest with a Maintainer: item, like try-live.md (rejected: holding this PR a draft for it).

Follow-ups

  • quest/m3/pin-mp4-import.md [XS]: bump the moq pin once moq-mux's regular MP4 import lands on moq's main. Waits on moq-dev/moq. Kept by the maintainer (2026-11-15).
  • quest/m3/card-pictures.md [S]: the first picture on each finished recording's and clip's card, through that import. Requires the pin. Kept by the maintainer (2026-11-15), with its approach (import, not mp4-atom).
  • quest/m0/ux/try-review.md [XS]: the maintainer tries the REVIEW page by feel and look. Maintainer: item. Kept by the maintainer (2026-11-15).

quest/m2/markers.md already owns markers on the strip.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, M, arm A)
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, S, arm A)

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: e6e2fb7

  • Base: origin/main at 0ee8deb

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1e0d3-581f-79d2-b198-b0e27f92e441, round 5

  • Score: 10/10, The merge preserves the reviewed REVIEW behavior, and code inspection found no new issues in the branch’s incremental changes; builds and tests were not run under the review constraints.

  • Rounds: 5; first round 4 (high 1, medium 3); findings 5 (high 1, medium 4): fixed 5, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, medium effort, shadow

  • Session: 01a1e0d3-5821-7a22-be10-458e2ef7e8ef

  • Rounds: 2; first round 3 (high 1, medium 2); findings 3 (high 1, medium 2): fixed 3, refuted 0, open 0

kixelated and others added 5 commits November 15, 2026 09:42
Quest-Claim: e3d36e2c89eab2a2
… recordings

REVIEW replaces the Replay panel and the recording half of the Output
panel, as quest/m0/ux/mock/review.html draws it. The last 30 seconds of
the program or a source show as a strip of keyframes with the sound
under them, decoded on a thread of their own while the page is shown,
from the groups the tracks already keep. Two amber handles pick any
stretch of it for Replay and Save clip, and the picture under the scrub
head shows large. Beside it, this show's recordings and clips as cards
with their length and size, one repaired after a crash marked so, and
the folder. The title bar's record button shows its clock, and the
recorded picture, sound, and each source too move to Settings, Recording.

Clips are saved into the recordings folder, beside the recordings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated and others added 4 commits November 15, 2026 11:11
The REVIEW page's quest is done: pictures on finished cards wait on
moq-mux's regular MP4 import (m3, as moq's import is), and the human
feel check is the maintainer's try-review quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- An aged-out stretch's end is taken by a press on its side, so it can
  always be dragged free.
- Strip picture ids stay unique across the strip's workers, so a texture
  the page kept never shows an older picture.
- The shelf runs one listing at a time.
- With more than one replay source, which one Replay plays in is picked
  again, as before this page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 20:20
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cd2355e2-1eb6-49f3-a195-d0e089067809
Commits

Reviewing files that changed from the base of the PR and between 0ee8deb and e6e2fb7.

Files ignored due to path filters: 3

  • Cargo.lock is excluded by !**/*.lock
  • rs/moq-studio/assets/icons/download.svg is excluded by !**/*.svg
  • rs/moq-studio/assets/icons/folder.svg is excluded by !**/*.svg
Files selected for processing: 20

  • README.md
  • quest/m0/ux/review.md
  • quest/m0/ux/try-review.md
  • quest/m2/markers.md
  • quest/m3/card-pictures.md
  • quest/m3/pin-mp4-import.md
  • rs/moq-studio/Cargo.toml
  • rs/moq-studio/src/controls.rs
  • rs/moq-studio/src/engine.rs
  • rs/moq-studio/src/kit/icon.rs
  • rs/moq-studio/src/main.rs
  • rs/moq-studio/src/past.rs
  • rs/moq-studio/src/record.rs
  • rs/moq-studio/src/replay.rs
  • rs/moq-studio/src/shelf.rs
  • rs/moq-studio/src/shots.rs
  • rs/moq-studio/src/ui.rs
  • rs/moq-studio/src/ui/review.rs
  • rs/moq-studio/src/ui/settings.rs
  • rs/moq-studio/src/ui/shell.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The Replay and Save clip hotkeys keep reusing a stretch picked between two moments: they replay that old moment, and stop working entirely 30 s after the pick. The README also still says REVIEW holds the recording's picks in two places this PR didn't touch.

Reviewed changes

This review covers the whole PR at de36545: the new REVIEW page, the strip worker, the folder listing, the stretch model for replays and clips, the Settings Recording tab, and the quest files.

  • replay::Stretch replaces fixed lengths: two handles pick either the last N seconds (Last) or a fixed span between two moments (Between). take shifts each target's end back by the picked ago.
  • past.rs strip worker: while REVIEW is shown, a thread re-takes the 30 s window about once a second. It decodes each group's keyframe at 480 px on the CPU, caches them by timestamp, and reads a sound peak per packet.
  • shelf.rs folder listing: the recordings folder is listed in the background every 2 s. File names are grouped into recording, repair and clip cards, lengths come from mvhd with mdat skipped by seeking, and free space is shown.
  • REVIEW page rewrite: large picture under the scrub head, a "replay what" column, the strip with handles and ruler, speed, an "Into" picker only when there is more than one replay source, and Replay/Save clip buttons that say why they can't act. Cards for the recording under way and for finished files sit on the right.
  • Clips move to the recordings folder, the Settings Recording tab takes over the recording picks, and the title bar's record button shows elapsed time.
  • Quests: deletes quest/m0/ux/review.md and adds the try-review, card-pictures and pin-mp4-import follow-ups.

I could not run quest context (no quest or nix in the review shell), as REVIEW.md asks me to note. The UI holds controls.replay and then locks engine.state; Controls::replay takes them in the same order, and nothing takes them the other way round, so there is no new deadlock risk.

ℹ️ README still says REVIEW holds the recording's picks

This PR moves the recording's picture and sound picks to Settings' Recording tab. Two README passages outside the diff still point at REVIEW, which goes against AGENTS.md's rule that the README changes in the same PR.

Technical details
# Stale README references to REVIEW's recording picks

## Affected sites
- README.md:416 — "A recording holds the audio scene on program unless REVIEW picks another": the audio scene a recording holds is now picked in Settings' Recording tab (`Panels::recorded_audio` in `rs/moq-studio/src/ui/settings.rs`).
- README.md:1201 (Hotkeys) — "Replay, Save clip, and a recording use REVIEW's picks": a recording now uses Settings' Recording picks; only Replay and Save clip use REVIEW's.

## Required outcome
- Both passages name Settings' Recording tab for the recording's picks, matching the already updated Recording section.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

Comment thread rs/moq-studio/src/controls.rs Resolved
kixelated and others added 2 commits November 15, 2026 12:36
A stretch fixed between two moments on REVIEW kept a hotkey replaying
that old moment, and refusing once it aged out of the window. A key
pressed from another page means what just happened. The README no longer
says REVIEW holds the recording's picks, and names the replay picker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pullfrog[bot]
pullfrog Bot previously approved these changes Nov 15, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This review covers the two commits since the prior Pullfrog review at de36545.

  • Hotkeys and the clip button take the last stretch: Controls::take now calls Stretch::last() when pressed, so a Stretch::Between becomes Last(length) (capped at WINDOW) and no longer ages out. REVIEW's own buttons still honor Between.
  • Test for the new behavior: a_hotkey_takes_the_last_stretch_as_long covers the conversion, its span long after the pick, and Last passing through unchanged.
  • README and tooltip: the Hotkeys paragraph and the shell clip button's tooltip now describe the behavior, and the two stale "REVIEW picks" lines about recordings point at Settings' Recording tab.

Both concerns from the earlier review are addressed.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

kixelated and others added 4 commits November 16, 2026 00:13
# Conflicts:
#	README.md
#	rs/moq-studio/src/controls.rs
#	rs/moq-studio/src/kit/icon.rs
#	rs/moq-studio/src/shots.rs
#	rs/moq-studio/src/ui.rs
#	rs/moq-studio/src/ui/settings.rs
#	rs/moq-studio/src/ui/shell.rs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This review covers what changed since the last Pullfrog review at 55d98ab: a merge of main, a pair of commits that hosted the views and then removed them, and a wording change to a quest file.

  • Merged main (0ee8deb): I checked the conflict hunks (git show --cc 6fa235b) and each one keeps both sides.
    • In the README, the page table and Settings tabs take main's wording plus REVIEW's row and the Recording tab.
    • The Hotkeys paragraph drops the old sentence about Cut/Transition, since main now offers them as TAKE and AUTO.
    • Icon::ALL now has 53 icons: main's 50 plus Folder, Save and Repaired.
    • Setting::ALL becomes Show, Recording, Hotkeys, Effects, Advanced.
    • In shell.rs, Page::Review goes to self.review, and main's MIX keeps audio_scenes.
    • shots.rs keeps the Review views beside main's Cued and OffAir.
  • Hosted and dropped the shots: the views were committed as WebP and deleted in the next commit, as AGENTS.md asks.
  • quest/m3/card-pictures.md: now records that the maintainer kept the recommended approach.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated merged commit 7fa9668 into main Nov 16, 2026
4 checks passed
@kixelated
kixelated deleted the quest/m0/ux/review branch November 16, 2026 08:40
kixelated added a commit that referenced this pull request Nov 16, 2026
Brings in BUILD's layers and inspector (#174), Studio mode (#176), REVIEW and
Settings' Recording tab (#177), the moq pin and Flatpak camera fix (#173), and
the quest cleanup (#185). The copied source tracks take main's group starts
and skips while still stopping at END STREAM; BUILD's picture frames the
program by whether it is on air and a scene open off program as main does;
Settings has both Stream and Recording; and the hotkeys add Go live and End
stream to TAKE, AUTO, and Studio mode.

Records the maintainer's choice for program-encoder-priority.md: release the
sources' replay encoders when the program's cannot open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant