Skip to content

ci(pullfrog): fail the setup if the Nix daemon trusts the runner user - #183

Merged
kixelated merged 2 commits into
mainfrom
pullfrog/untrusted-check
Nov 16, 2026
Merged

kixelated merged 2 commits into
mainfrom
pullfrog/untrusted-check

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follows up moq-dev/studio#182, whose Pullfrog setup installs Nix with trust-runner-user: false so the agent's shell cannot reach root through the Nix daemon. That input only stops the installer adding the runner to trusted-users; nothing checked that the daemon actually treats the runner as untrusted. The PATH step now fails the job if nix store info --json reports the runner as trusted, next to the existing check that the job's token stayed out of Nix's config. Suggested by Pullfrog on moq-dev/quest#756; the same check goes to kixel-ai/rust2#841, moq-dev/web-transport#545, and moq-dev/quest#756, keeping the four repositories' setup steps byte-identical.

Public API

None.

Validation

  • Against a real Nix 2.35.2 daemon: nix store info --json prints "trusted":false as an untrusted user (sudo -u nobody), which the check passes, and "trusted":true as a trusted one, which it fails. The jq filter passes false and 0 and fails true, 1, and a missing field.
  • actionlint passes; the setup steps are byte-identical to the other three repositories'.
  • Not exercised on a runner: the pullfrog environment admits only main.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (iterate, XS, arm B)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: d75b2bb

  • Base: origin/main at 0a8f017

  • Risk: high, it changes .github/workflows/pullfrog.yml, which is always high: workflows run with the repository's secrets and decide what merges and ships

  • Classified: high by the always-high paths

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1e0bb-5938-7da3-934a-b583fde46ebd, round 1

  • Score: 9/10, The narrow change fails closed unless Nix explicitly reports the runner as untrusted, and read-only review found no actionable defects; tests were not run.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1e0bb-5937-7923-88b2-eea80a509fdf, round 1

  • Score: 9/10, The check fails closed unless the Nix daemon reports the runner as untrusted, matching the workflow’s security intent; source review found no actionable defects, but builds and tests were not run.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

trust-runner-user: false only stops the installer adding the runner to
trusted-users; assert the daemon really treats it as untrusted, as the
token guard does for the token, since neither runs before merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 19:42
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f6c7ec49-be21-40c1-a624-cd075b2a4ca0
Commits

Reviewing files that changed from the base of the PR and between d5323c4 and 5fae0eb.

Files selected for processing: 1

  • .github/workflows/pullfrog.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the single commit adding a trust check to the Pullfrog workflow.

  • Daemon trust check: the PATH step now runs nix store info --json | jq -e '.trusted == false or .trusted == 0' and exits 1 otherwise. It fails closed: a missing field, a nix error, or empty output all fail the step.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: d75b2bbca706b0356772ee84de8ee8c5c7b0e000.

No actionable issue found in the new guard. Reviewed the complete Pullfrog workflow around the change: the check runs before the agent, the explicit bash shell makes a failed nix store info pipeline fail closed, and the jq condition admits only boolean false or numeric zero (rejecting a missing/trusted value). Limits: static workflow review only; I did not execute a hosted runner or independently verify the daemon/installer configuration.

@kixelated
kixelated merged commit 4c40be0 into main Nov 16, 2026
3 checks passed
@kixelated
kixelated deleted the pullfrog/untrusted-check branch November 16, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant