Repository navigation
ci(pullfrog): fail the setup if the Nix daemon trusts the runner user - #183
Conversation
trust-runner-user: false only stops the installer adding the runner to trusted-users; assert the daemon really treats it as untrusted, as the token guard does for the token, since neither runs before merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: the single commit adding a trust check to the Pullfrog workflow.
- Daemon trust check: the PATH step now runs
nix store info --json | jq -e '.trusted == false or .trusted == 0'and exits 1 otherwise. It fails closed: a missing field, a nix error, or empty output all fail the step.
claude-sonnet-5-5 | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: d75b2bbca706b0356772ee84de8ee8c5c7b0e000.
No actionable issue found in the new guard. Reviewed the complete Pullfrog workflow around the change: the check runs before the agent, the explicit bash shell makes a failed nix store info pipeline fail closed, and the jq condition admits only boolean false or numeric zero (rejecting a missing/trusted value). Limits: static workflow review only; I did not execute a hosted runner or independently verify the daemon/installer configuration.

Summary
Follows up moq-dev/studio#182, whose Pullfrog setup installs Nix with
trust-runner-user: falseso the agent's shell cannot reach root through the Nix daemon. That input only stops the installer adding the runner totrusted-users; nothing checked that the daemon actually treats the runner as untrusted. The PATH step now fails the job ifnix store info --jsonreports the runner as trusted, next to the existing check that the job's token stayed out of Nix's config. Suggested by Pullfrog on moq-dev/quest#756; the same check goes to kixel-ai/rust2#841, moq-dev/web-transport#545, and moq-dev/quest#756, keeping the four repositories' setup steps byte-identical.Public API
None.
Validation
nix store info --jsonprints"trusted":falseas an untrusted user (sudo -u nobody), which the check passes, and"trusted":trueas a trusted one, which it fails. Thejqfilter passesfalseand0and failstrue,1, and a missing field.actionlintpasses; the setup steps are byte-identical to the other three repositories'.pullfrogenvironment admits onlymain.Follow-ups
None.
Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (iterate, XS, arm B)
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: d75b2bb
Base: origin/main at 0a8f017
Risk: high,
it changes .github/workflows/pullfrog.yml, which is always high: workflows run with the repository's secrets and decide what merges and shipsClassified: high by the always-high paths
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1e0bb-5938-7da3-934a-b583fde46ebd, round 1Score: 9/10,
The narrow change fails closed unless Nix explicitly reports the runner as untrusted, and read-only review found no actionable defects; tests were not run.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1e0bb-5937-7923-88b2-eea80a509fdf, round 1Score: 9/10,
The check fails closed unless the Nix daemon reports the runner as untrusted, matching the workflow’s security intent; source review found no actionable defects, but builds and tests were not run.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none