Repository navigation
feat(studio): a command palette over one action table - #207
Conversation
Quest-Claim: 687279e874769b76
Every action is registered once in controls.rs, with its group, id, name, and the words it answers to. The Hotkeys pane, the Wayland portal, the tooltips' keys, and a new command palette (Ctrl+K) all read it. A sound's mute joins the table, so it can be bound and run from the palette. The palette also finds the pages, each setting by name, layers, devices to add, and undo and redo, and shows why an action cannot run now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t it opens Filter after the search box takes this frame's typing, poll a device listing on any page, skip the studio's own virtual cameras, close Settings for a command that turns to a page or opens a window, stop a page's interaction when the palette takes the keyboard, and open Scene sizes when the palette finds it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
ℹ️ No critical issues. One minor mislabel is noted inline.
Approach: Sound. One FIXED table plus Action::listed gives the Hotkeys pane, the portal ids, the tooltips, and the palette a single source to read from. Mute(String) is the smallest addition that lets markers and the phone remote register later. The palette reuses controls.press, so it adds no second path for firing an action.
Reviewed changes: the whole PR at 99c4707, against main.
- Action table:
controls.rsregisters each fixed action once with its group, portal id, name, detail, and the words it is found by.Action::listedadds one row per scene and per sound, using the samestrip()filter as MIX.Controls::refusedgives the reason an action cannot run. - Mute as an action:
controls::mutemakes one undoablecommit, like the LIVE strip's button. The hotkey thread dropsengine.statebeforecontrols.press, so a mute fired from a key cannot deadlock. - Portal ids: these now come from
Action::id(). Every existing id is unchanged, and a mute's ismute/<source>. - Palette:
ui/palette.rsis an eguiModalwhose rows are rebuilt underengine.stateeach frame. Enter and the arrow keys are consumed before theTextEditsees them, and the query is filtered after it, so Enter runs what was typed. A refused row stays open, and Go live opens the go-live sheet. - Settings by name:
Setting::rowsandseek/soughtscroll the pane to a setting and highlight it. A GPU shot test checks that every name in the table is a row label in its pane. - Hotkeys pane: groups now come from
Action::listed, with a new Sounds group. Any binding not listed is kept so it can be cleared.
quest context ran. I checked these paths and found them correct:
- Layer rows index
collection.items, which is the same index space asslots::placed. - BUILD's Escape and
Akeys are skipped while the palette's text field has focus. - With Settings open under the palette, Escape and a backdrop click close only the top modal.
claude-opus-5-5 | 𝕏
|
Maintainer decision (2026-11-18,
Decision 4 (listing devices is a row you choose, not automatic on open) was not answered before the maintainer stepped away; the agent's recommendation (keep the row) is taken under (Written by Claude Opus 5.5) |
…acks it A source the MIX lists no strip for, such as a clip without audio, is still a sound of the show whose key mutes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Head 0cc2214 applies the maintainer's decisions as recorded in the PR body's Decisions: Ctrl+K / Cmd+K including in text fields, Go live opens the GO LIVE sheet, End stream ends at once, and listing devices stays a row you choose. It also merges (Written by Claude Opus 5.5 with medium) |
There was a problem hiding this comment.
✅ No new issues found. The earlier "no such sound" mislabel is fixed.
Reviewed changes: the commits since 99c4707. These are the fix for the earlier finding, a merge of main (the moq pin bump in #208), and a formatting commit.
- Hotkeys labels:
settings.rsnow readscollection.sourcesunder the same lock asAction::listed. It shows "no such sound" only when the scene file has no source of that name, which is the same testControls::refusedandcontrols::muteuse. A binding that is not listed still appears in its group, so it can be cleared. Every scene in the file is listed, so aScenebinding that is not listed always names a scene the file no longer has. - Shot test:
the_palette_finds_and_runs_anythingbinds a mute tohost, which exists but has no strip, and to a source the file does not have. It then checks that exactly one "no such sound" label appears.
claude-opus-5-5 | 𝕏
Brings in #194 (keep out of the way), #207 (command palette), and #208 (moq pin bump). A layer keeping clear places only the landscape picture: the compositor's keepers read and place the landscape view alone, and BUILD's keep helpers take the picture edited, holding or grabbing nothing in portrait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Finishes quest/m2/command-palette.md.
Problem
The studio's actions lived in a fixed enum with its names, Hotkeys groups, details, and Wayland portal ids spread across
controls.rs,settings.rs, andhotkeys/portal.rs, and nothing let an operator find and run an action, a scene, a sound, or a setting by name.quest/m2/markers.md(a Marker hotkey action) andquest/m2/phone-remote.md(a remote driving pads and mutes) both need one table to register into.Approach
rs/moq-studio/src/controls.rs): each action without a name of its own is registered once inFIXED, with its group, portal id, name, Hotkeys detail, and the words the palette finds it by.Action::listed(&State)adds a scene's action per scene and a mute per sound, in the order the Hotkeys pane and the palette list them.Controls::refused(&State, &Action)says why one cannot run now (nothing cued, a scene that cannot go on program, not on air, no replay source, a recording still finishing). The Hotkeys pane, the portal's ids, the tooltips' keys, and the palette read only this. A new action, such as Marker, is one enum variant and oneFIXEDrow, and the exhaustive match inevery_action_is_registered_oncefails the build until it is placed.Action::Mute(name)), so it binds in Settings, Hotkeys under Sounds, runs from the palette, shows its key on the MIX strip's button, and is what the phone remote can fire. It edits the scene file as the strip's button does, so undo takes it back.rs/moq-studio/src/ui/palette.rs): Ctrl+K (Cmd+K on macOS), or a new search button in the title bar, opens a search box over any page. It lists every action with its key and, dimmed, why it cannot run; then selecting each layer BUILD edits, adding a device (a first row lists them, then each is a row), adding any kind of source by hand, the pages, each Settings pane, each setting by its row's name (opening the pane scrolled to that row, lit for a moment), undo and redo, the multiview, health details, and the scene graph. Each word typed must start a word of a row's name, group, or extra words, or else appear inside one; ties keep the listed order, actions first.Setting::rows(rs/moq-studio/src/ui.rs); a driven GPU test opens every pane and fails if a listed name is not a row there, so the two cannot drift.Impact
Mutewas appended).mute/<source>.Public API and wire: none.
moq-studiois a binary; no moq crate changes.Views
New: the palette as its key opens it, finding
take(TAKE says nothing is cued,Verticalsays why it cannot go on program), and finding a setting. Changed: Settings, Hotkeys with its new Sounds group. There is no mock-up frame of the palette; it follows the settings sheet's look.Validation
just ci: passed (428 tests), on the first head and again after the review's fixes.just shots palette palette_found palette_setting live settings_hotkeys mix: passed, each still view drawn twice identically; images above.shots::the_palette_finds_and_runs_anything(new, GPU, real engine and window through egui_kittest): Ctrl+K, typeinterview, Enter takes the scene; text and Enter arriving in one frame run what was typed (this failed, leavingInterviewon program, with the first head's filtering before the search box, found in review);mute micandunmute micflip the microphone's mute in the scene file;take the cuedshows TAKE disabled and Enter leaves the palette open; Escape closes it;scene sizesopens its disclosure;fpsopens Settings at Frame rate; and every name inSetting::rowsis a row label in its pane. Passed.engine::tests::a_cue_waits_for_take(GPU, lavapipe) extended:Controls::refusedagrees with what firing the action returns (nothing is cued,the program is not on air, a scene's own refusal, no replay source), and a mute fires, unmutes, and undoes as one edit. Passed.origin/main(moq pin bump moq-dev/studio#208):just cipassed (428 tests);shots::the_palette_finds_and_runs_anythingpassed, now also binding a mute tohost(an image, no sound) and to a source the file lacks, opening Hotkeys, and finding exactly one "no such sound". With the old label it failed (left: 2, right: 1).Decisions
The maintainer's, from the pick round (pick:
/quest-merge):/quest-afk, open to overturn: ✅ listing devices stays a row you choose, since listing cameras can raise a permission prompt on macOS (rejected: listing on open).Taken under
/quest-afkwhile iterating, for review:Alternatives
fps,mic,brb) cover the synonyms that fuzzy matching would not.Follow-ups
None.
Models
Size: M
Implementer: Claude Code, claude-opus-5-5, medium effort (arm A)
Implementer: Claude Code, claude-opus-5-5, medium effort (iterate, M, arm A)
🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with medium)
Review
Rewritten by
quest reviewafter each round.Head: 0cc2214
Base: origin/main at 2b03255
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, high effort
Session:
01a1f0dc-2c49-7162-a2bc-3a8dc08f2dcb, round 3Score: 10/10,
The incremental change correctly distinguishes absent sources from sources without audio, with no new issues found by code inspection; builds and tests were not run under the review restriction.Rounds: 3; first round 5 (high 1, medium 4); findings 5 (high 1, medium 4): fixed 5, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, medium effort, shadow
Session:
01a1f0dc-2bbb-7491-b9f3-c84cf58bc62aRounds: 2; first round 2 (medium 2); findings 2 (medium 2): fixed 2, refuted 0, open 0