Skip to content

feat(studio): a command palette over one action table - #207

Merged
kixelated merged 8 commits into
mainfrom
quest/m2/command-palette
Nov 19, 2026
Merged

kixelated merged 8 commits into
mainfrom
quest/m2/command-palette

Conversation

@kixelated

@kixelated kixelated commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Finishes quest/m2/command-palette.md.

Problem

The studio's actions lived in a fixed enum with its names, Hotkeys groups, details, and Wayland portal ids spread across controls.rs, settings.rs, and hotkeys/portal.rs, and nothing let an operator find and run an action, a scene, a sound, or a setting by name. quest/m2/markers.md (a Marker hotkey action) and quest/m2/phone-remote.md (a remote driving pads and mutes) both need one table to register into.

Approach

  • One action table (rs/moq-studio/src/controls.rs): each action without a name of its own is registered once in FIXED, with its group, portal id, name, Hotkeys detail, and the words the palette finds it by. Action::listed(&State) adds a scene's action per scene and a mute per sound, in the order the Hotkeys pane and the palette list them. Controls::refused(&State, &Action) says why one cannot run now (nothing cued, a scene that cannot go on program, not on air, no replay source, a recording still finishing). The Hotkeys pane, the portal's ids, the tooltips' keys, and the palette read only this. A new action, such as Marker, is one enum variant and one FIXED row, and the exhaustive match in every_action_is_registered_once fails the build until it is placed.
  • A sound's mute is an action (Action::Mute(name)), so it binds in Settings, Hotkeys under Sounds, runs from the palette, shows its key on the MIX strip's button, and is what the phone remote can fire. It edits the scene file as the strip's button does, so undo takes it back.
  • The palette (rs/moq-studio/src/ui/palette.rs): Ctrl+K (Cmd+K on macOS), or a new search button in the title bar, opens a search box over any page. It lists every action with its key and, dimmed, why it cannot run; then selecting each layer BUILD edits, adding a device (a first row lists them, then each is a row), adding any kind of source by hand, the pages, each Settings pane, each setting by its row's name (opening the pane scrolled to that row, lit for a moment), undo and redo, the multiview, health details, and the scene graph. Each word typed must start a word of a row's name, group, or extra words, or else appear inside one; ties keep the listed order, actions first.
  • Each setting's name lives in Setting::rows (rs/moq-studio/src/ui.rs); a driven GPU test opens every pane and fails if a listed name is not a row there, so the two cannot drift.

Impact

  • New: the command palette (Ctrl+K / Cmd+K, and the title bar's search button).
  • New: each sound's mute can be bound in Settings, Hotkeys, and its key shows on the MIX strip's mute button.
  • The Hotkeys pane gains a Sounds group. Its other rows, names, and saved bindings are unchanged (bindings are saved by variant name; Mute was appended).
  • Wayland portal shortcut ids are unchanged for every existing action; a mute's is mute/<source>.
  • README: the title bar, a new Command palette section, and Hotkeys.

Public API and wire: none. moq-studio is a binary; no moq crate changes.

Views

New: the palette as its key opens it, finding take (TAKE says nothing is cued, Vertical says why it cannot go on program), and finding a setting. Changed: Settings, Hotkeys with its new Sounds group. There is no mock-up frame of the palette; it follows the settings sheet's look.

palette
palette_found
palette_setting
settings_hotkeys

Validation

  • just ci: passed (428 tests), on the first head and again after the review's fixes.
  • just shots palette palette_found palette_setting live settings_hotkeys mix: passed, each still view drawn twice identically; images above.
  • shots::the_palette_finds_and_runs_anything (new, GPU, real engine and window through egui_kittest): Ctrl+K, type interview, Enter takes the scene; text and Enter arriving in one frame run what was typed (this failed, leaving Interview on program, with the first head's filtering before the search box, found in review); mute mic and unmute mic flip the microphone's mute in the scene file; take the cued shows TAKE disabled and Enter leaves the palette open; Escape closes it; scene sizes opens its disclosure; fps opens Settings at Frame rate; and every name in Setting::rows is a row label in its pane. Passed.
  • engine::tests::a_cue_waits_for_take (GPU, lavapipe) extended: Controls::refused agrees with what firing the action returns (nothing is cued, the program is not on air, a scene's own refusal, no replay source), and a mute fires, unmutes, and undoes as one edit. Passed.
  • Unit tests: the table registers each action once under a unique id, groups keep the table's order, and the palette's matcher finds by every typed word, ranks name over extra words over inside-a-word, and splits on punctuation.
  • After merging origin/main (moq pin bump moq-dev/studio#208): just ci passed (428 tests); shots::the_palette_finds_and_runs_anything passed, now also binding a mute to host (an image, no sound) and to a source the file lacks, opening Hotkeys, and finding exactly one "no such sound". With the old label it failed (left: 2, right: 1).
  • Not measured: frame time with the palette open. It rebuilds its rows (a few hundred at most) under the state lock each frame while open, the same lock and work scale as the Hotkeys pane.

Decisions

The maintainer's, from the pick round (pick: /quest-merge):

  1. ✅ Ctrl+K / Cmd+K opens it, including inside text fields (rejected: Ctrl+Shift+P). A Hotkeys binding of the same key also fires its action.
  2. ✅ Go live from the palette opens the GO LIVE sheet, as the button does (rejected: going live at once like the hotkey).
  3. ✅ End stream from the palette ends at once like its hotkey (rejected: a confirm step).
  4. Taken under /quest-afk, open to overturn: ✅ listing devices stays a row you choose, since listing cameras can raise a permission prompt on macOS (rejected: listing on open).

Taken under /quest-afk while iterating, for review:

  • ✅ A refused row stays open on Enter, since the reason is already on the row (rejected: closing and reporting the refusal).
  • ✅ A bound mute reads "no such sound" only when the scene file has no source by that name, the test firing it uses (rejected: whenever the MIX lists no strip for it). A source with no audio now, such as a silent clip, still lists its key under Sounds so it can be cleared, unlabelled (Pullfrog's finding).

Alternatives

  • Fuzzy subsequence matching (fzf-style). Word-prefix matching with an inside-a-word fallback ranks predictably and needs no tuning; extra words (fps, mic, brb) cover the synonyms that fuzzy matching would not.
  • Settings rows registering their names as they draw. The palette needs them while no pane is drawn, so they are a table with a test that each is drawn.

Follow-ups

None.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, medium effort (arm A)
Implementer: Claude Code, claude-opus-5-5, medium effort (iterate, M, arm A)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with medium)

Review

Rewritten by quest review after each round.

  • Head: 0cc2214

  • Base: origin/main at 2b03255

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1f0dc-2c49-7162-a2bc-3a8dc08f2dcb, round 3

  • Score: 10/10, The incremental change correctly distinguishes absent sources from sources without audio, with no new issues found by code inspection; builds and tests were not run under the review restriction.

  • Rounds: 3; first round 5 (high 1, medium 4); findings 5 (high 1, medium 4): fixed 5, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, medium effort, shadow

  • Session: 01a1f0dc-2bbb-7491-b9f3-c84cf58bc62a

  • Rounds: 2; first round 2 (medium 2); findings 2 (medium 2): fixed 2, refuted 0, open 0

kixelated and others added 4 commits November 18, 2026 14:26
Every action is registered once in controls.rs, with its group, id, name,
and the words it answers to. The Hotkeys pane, the Wayland portal, the
tooltips' keys, and a new command palette (Ctrl+K) all read it. A sound's
mute joins the table, so it can be bound and run from the palette. The
palette also finds the pages, each setting by name, layers, devices to add,
and undo and redo, and shows why an action cannot run now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title A command palette feat(studio): a command palette over one action table Nov 18, 2026
…t it opens

Filter after the search box takes this frame's typing, poll a device
listing on any page, skip the studio's own virtual cameras, close Settings
for a command that turns to a page or opens a window, stop a page's
interaction when the palette takes the keyboard, and open Scene sizes when
the palette finds it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 18, 2026 23:09
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1df01dad-76d8-482c-9ed0-74fafe8c4d55
Commits

Reviewing files that changed from the base of the PR and between 2b03255 and 0cc2214.

Files ignored due to path filters: 1

  • rs/moq-studio/assets/icons/search.svg is excluded by !**/*.svg
Files selected for processing: 14

  • README.md
  • quest/m2/command-palette.md
  • rs/moq-studio/src/controls.rs
  • rs/moq-studio/src/engine.rs
  • rs/moq-studio/src/hotkeys/portal.rs
  • rs/moq-studio/src/kit/icon.rs
  • rs/moq-studio/src/shots.rs
  • rs/moq-studio/src/ui.rs
  • rs/moq-studio/src/ui/build.rs
  • rs/moq-studio/src/ui/layers.rs
  • rs/moq-studio/src/ui/mixer.rs
  • rs/moq-studio/src/ui/palette.rs
  • rs/moq-studio/src/ui/settings.rs
  • rs/moq-studio/src/ui/shell.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues. One minor mislabel is noted inline.

Approach: Sound. One FIXED table plus Action::listed gives the Hotkeys pane, the portal ids, the tooltips, and the palette a single source to read from. Mute(String) is the smallest addition that lets markers and the phone remote register later. The palette reuses controls.press, so it adds no second path for firing an action.

Reviewed changes: the whole PR at 99c4707, against main.

  • Action table: controls.rs registers each fixed action once with its group, portal id, name, detail, and the words it is found by. Action::listed adds one row per scene and per sound, using the same strip() filter as MIX. Controls::refused gives the reason an action cannot run.
  • Mute as an action: controls::mute makes one undoable commit, like the LIVE strip's button. The hotkey thread drops engine.state before controls.press, so a mute fired from a key cannot deadlock.
  • Portal ids: these now come from Action::id(). Every existing id is unchanged, and a mute's is mute/<source>.
  • Palette: ui/palette.rs is an egui Modal whose rows are rebuilt under engine.state each frame. Enter and the arrow keys are consumed before the TextEdit sees them, and the query is filtered after it, so Enter runs what was typed. A refused row stays open, and Go live opens the go-live sheet.
  • Settings by name: Setting::rows and seek/sought scroll the pane to a setting and highlight it. A GPU shot test checks that every name in the table is a row label in its pane.
  • Hotkeys pane: groups now come from Action::listed, with a new Sounds group. Any binding not listed is kept so it can be cleared.

quest context ran. I checked these paths and found them correct:

  • Layer rows index collection.items, which is the same index space as slots::placed.
  • BUILD's Escape and A keys are skipped while the palette's text field has focus.
  • With Settings open under the palette, Escape and a backdrop click close only the top modal.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

Comment thread rs/moq-studio/src/ui/settings.rs Resolved
@kixelated

Copy link
Copy Markdown
Contributor Author

Maintainer decision (2026-11-18, /quest-run pick round). Pick: /quest-merge.

  1. Palette key: ✅ Ctrl+K / Cmd+K, including inside text fields (rejected: Ctrl+Shift+P).
  2. Go live from the palette: ✅ opens the GO LIVE sheet with its checks, like the button (rejected: going live at once like the hotkey).
  3. End stream from the palette: ✅ ends at once, like its hotkey (rejected: a confirm step).

Decision 4 (listing devices is a row you choose, not automatic on open) was not answered before the maintainer stepped away; the agent's recommendation (keep the row) is taken under /quest-afk and stays open to overturn in review.

(Written by Claude Opus 5.5)

kixelated and others added 3 commits November 18, 2026 19:11
…acks it

A source the MIX lists no strip for, such as a clip without audio, is still
a sound of the show whose key mutes it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Contributor Author

Head 0cc2214 applies the maintainer's decisions as recorded in the PR body's Decisions: Ctrl+K / Cmd+K including in text fields, Go live opens the GO LIVE sheet, End stream ends at once, and listing devices stays a row you choose. It also merges origin/main (moq pin bump #208) and fixes Pullfrog's mute-label finding.

(Written by Claude Opus 5.5 with medium)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found. The earlier "no such sound" mislabel is fixed.

Reviewed changes: the commits since 99c4707. These are the fix for the earlier finding, a merge of main (the moq pin bump in #208), and a formatting commit.

  • Hotkeys labels: settings.rs now reads collection.sources under the same lock as Action::listed. It shows "no such sound" only when the scene file has no source of that name, which is the same test Controls::refused and controls::mute use. A binding that is not listed still appears in its group, so it can be cleared. Every scene in the file is listed, so a Scene binding that is not listed always names a scene the file no longer has.
  • Shot test: the_palette_finds_and_runs_anything binds a mute to host, which exists but has no strip, and to a source the file does not have. It then checks that exactly one "no such sound" label appears.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated merged commit 51f5f75 into main Nov 19, 2026
4 checks passed
@kixelated
kixelated deleted the quest/m2/command-palette branch November 19, 2026 04:16
kixelated added a commit that referenced this pull request Nov 19, 2026
Brings in #194 (keep out of the way), #207 (command palette), and #208
(moq pin bump). A layer keeping clear places only the landscape picture:
the compositor's keepers read and place the landscape view alone, and
BUILD's keep helpers take the picture edited, holding or grabbing nothing
in portrait.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant