Repository navigation
chore(quest): record the upstream waits /quest-complete settled - #216
Merged
Merged
Conversation
wgpu-unpatch waits on gfx-rs/wgpu#10675, which fixes the configure race upstream, rather than a PR of our own. drop-winit records that dragged web addresses wait for winit's drag API. pin-egress-dial notes the RTMPS tcUrl change landed in moq. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 20, 2026 04:14
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. It records settled maintainer decisions and upstream status in the quest files, with no code changes.
Reviewed changes — all three changed files were read in full.
quest/m0/pin-egress-dial.md: links the landed moq PR #8744 in place of the deleted quest file, and notes that the dial policy quest is still open.quest/m0/wgpu-unpatch.md: replaces the maintainer item to open our own PR with a wait on gfx-rs/wgpu#10675, so the quest now waits only for a release.quest/m1/drop-winit.md: records the decision to wait for winit's drag API and drops theMaintainer:item.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Records the waits
/quest-completesettled on 2026-11-19.Changes
quest/m0/wgpu-unpatch.md: the maintainer's item to open our own gfx-rs/wgpu PR is cleared. gfx-rs/wgpu#10675, from another author, takescommand_indicesaround the HAL surface configure and unconfigure, which is the race the fork fixes. It merged on trunk on 2026-11-20 UTC. The quest now waits only for a wgpu release that carries it.quest/m1/drop-winit.md: the maintainer chose to have dragged web addresses wait for winit's drag API, with no per-platform hook in the meantime. The answer is recorded in the Plan, and theMaintainer:item is gone.quest/m0/pin-egress-dial.md: notes that one of its two upstream quests, RTMPS keepstcUrl, landed as moq-dev/moq#8744. The dial policy quest is still open, so the wait stays.quest/m0/pin-egress-dial.md's Goal linked moq'squest/m2/rtmp-rtmps-tcurl.md, which #8744 deleted; it now links the PR (review fix).Decisions
command_indicesaround HAL surface (un)configure and queue drop gfx-rs/wgpu#10675 (rejected: opening our own PR frommoq-dev/wgpu'ssurface-configure-race). Maintainer, 2026-11-19: "I think someone fixed it? At least a PR". If the release that carries it still crashes the startup repro from fix: patch wgpu-core so the studio starts every time #130, the fork's remaining change goes upstream at that point.Waits still held
These are checked and unchanged:
main.pin-moq-tip:hang::healthis still private, andhas_instanceis still crate-private.0.31.0-beta.4.0.3.0-beta.4.webandcompose/hang-layers: moq has not planned these yet.The maintainer skipped every
Maintainer:try, check, host, and signing item for this session.Models
Size: XS
Implementer: Claude Code, claude-opus-5-5
Validation
just cipassed locally on 6af3acd.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 6af3acd
Base: origin/main at 6c7da41
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1f729-0962-76f2-ac45-1bbd9f15119d, round 1Score: 10/10,
The documentation-only changes update quest references, upstream status, and settled maintainer decisions, with no actionable defects found.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1f729-0960-7233-af1d-e9af9698028b, round 1Score: 9/10,
The documentation-only changes appear ready to land, with no actionable defects identified; quest context and prompting guidance were not run because reviewer instructions prohibited quest commands.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none