Skip to content

chore(quest): record the upstream waits /quest-complete settled - #216

Merged
kixelated merged 3 commits into
mainfrom
quest-complete/upstream-waits
Nov 20, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest-complete/upstream-waits

Conversation

@kixelated

@kixelated kixelated commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Records the waits /quest-complete settled on 2026-11-19.

Changes

  • quest/m0/wgpu-unpatch.md: the maintainer's item to open our own gfx-rs/wgpu PR is cleared. gfx-rs/wgpu#10675, from another author, takes command_indices around the HAL surface configure and unconfigure, which is the race the fork fixes. It merged on trunk on 2026-11-20 UTC. The quest now waits only for a wgpu release that carries it.

  • quest/m1/drop-winit.md: the maintainer chose to have dragged web addresses wait for winit's drag API, with no per-platform hook in the meantime. The answer is recorded in the Plan, and the Maintainer: item is gone.

  • quest/m0/pin-egress-dial.md: notes that one of its two upstream quests, RTMPS keeps tcUrl, landed as moq-dev/moq#8744. The dial policy quest is still open, so the wait stays.

  • quest/m0/pin-egress-dial.md's Goal linked moq's quest/m2/rtmp-rtmps-tcurl.md, which #8744 deleted; it now links the PR (review fix).

Decisions

Waits still held

These are checked and unchanged:

  • The pin quests: their upstream moq quests are still open on moq's main.
  • pin-moq-tip: hang::health is still private, and has_instance is still crate-private.
  • winit: 0.31 is still 0.31.0-beta.4.
  • blitz-dom: still 0.3.0-beta.4.
  • web and compose/hang-layers: moq has not planned these yet.

The maintainer skipped every Maintainer: try, check, host, and signing item for this session.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5

Validation

just ci passed locally on 6af3acd.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 6af3acd

  • Base: origin/main at 6c7da41

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1f729-0962-76f2-ac45-1bbd9f15119d, round 1

  • Score: 10/10, The documentation-only changes update quest references, upstream status, and settled maintainer decisions, with no actionable defects found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1f729-0960-7233-af1d-e9af9698028b, round 1

  • Score: 9/10, The documentation-only changes appear ready to land, with no actionable defects identified; quest context and prompting guidance were not run because reviewer instructions prohibited quest commands.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 19, 2026 19:38
wgpu-unpatch waits on gfx-rs/wgpu#10675, which fixes the configure race
upstream, rather than a PR of our own. drop-winit records that dragged web
addresses wait for winit's drag API. pin-egress-dial notes the RTMPS tcUrl
change landed in moq.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 20, 2026 04:14
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fc37f95f-b5d5-4b37-963e-f203bca98d18
Commits

Reviewing files that changed from the base of the PR and between 2d23869 and f2ceb2d.

Files selected for processing: 3

  • quest/m0/pin-egress-dial.md
  • quest/m0/wgpu-unpatch.md
  • quest/m1/drop-winit.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. It records settled maintainer decisions and upstream status in the quest files, with no code changes.

Reviewed changes — all three changed files were read in full.

  • quest/m0/pin-egress-dial.md: links the landed moq PR #8744 in place of the deleted quest file, and notes that the dial policy quest is still open.
  • quest/m0/wgpu-unpatch.md: replaces the maintainer item to open our own PR with a wait on gfx-rs/wgpu#10675, so the quest now waits only for a release.
  • quest/m1/drop-winit.md: records the decision to wait for winit's drag API and drops the Maintainer: item.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated enabled auto-merge (squash) November 20, 2026 18:22
@kixelated
kixelated merged commit 41994f1 into main Nov 20, 2026
3 checks passed
@kixelated
kixelated deleted the quest-complete/upstream-waits branch November 20, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant