Repository navigation
chore(release): skip semver check for web-transport-wasm - #410
Conversation
crates.io lists a yanked web-transport-wasm 0.10.0 from 2024, and release-plz uses the highest published version (yanked included) as the cargo-semver-checks baseline, so every release was flagged as breaking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 833b300.
No actionable bugs found. The [[package]] override at release-plz.toml:11–13 correctly limits the disabled semver check to web-transport-wasm. I independently confirmed the yanked 0.10.0 registry entry, the highest-version selection in release-plz, and no files changed under rs/web-transport-wasm since the 0.8.0 tag.
Direction: reasonable as an explicitly temporary workaround. It suppresses genuine API-break detection too, so breaking changes still need deliberate version selection. The lasting fix is a correct release-plz baseline or an intentional version migration beyond the old registry entry, followed by removing this override. The disclosed recurring patch bumps remain unresolved.
Verification: static config, workflow, registry, tag comparison, and upstream-source inspection only. No release-plz dry run, build, or tests executed locally; I have not independently verified the predicted 0.8.1 release output. CI was still running.
(Written by review (OpenAI))
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughThe release-plz configuration now disables semver checks for Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The release workflow applies the semver exemption to Security Architecture ReviewSecurity architecture risk: ⚪ Minimal · up to The exception is limited to web-transport-wasm compatibility checks. It does not expand publishing permissions, expose credentials, or change application behavior. No material security risk was identified in this change. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Release PR #404 bumps
web-transport-wasm0.8.0 -> 0.9.0 as API breaking, though nothing underrs/web-transport-wasmchanged sinceweb-transport-wasm-v0.8.0.Root cause: crates.io still lists a yanked
web-transport-wasm0.10.0 (2024-04-06, oldkixelated/web-transport-rslayout, hence the baseline paths withoutrs/). release-plz picks the registry baseline withmax_by_key(version)over every index entry, yanked included (release_plz_core/src/clone/mod.rs,query_latest_package_summary). So cargo-semver-checks diffed against that 2024 API (WebError, one-argSession::new,Sendtypes) and flagged a break. The 0.7.0 and 0.8.0 minor bumps were the same false positive.Fix:
semver_check = falseforweb-transport-wasmonly, with a comment. The real break detection for this crate is lost until its version passes 0.10.0, at which point the override can go.Known residual: because the local package never matches the 0.10.0 baseline, release-plz still includes wasm in each release PR as a patch bump ("update Cargo.toml dependencies"). Expected outcome for #404: wasm 0.8.1 instead of 0.9.0.
Public API / wire impact: none (release config only).
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code