Skip to content

chore(release): skip semver check for web-transport-wasm - #410

Merged
kixelated merged 1 commit into
mainfrom
fix/wasm-semver-baseline
Oct 2, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/wasm-semver-baseline

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Release PR #404 bumps web-transport-wasm 0.8.0 -> 0.9.0 as API breaking, though nothing under rs/web-transport-wasm changed since web-transport-wasm-v0.8.0.

Root cause: crates.io still lists a yanked web-transport-wasm 0.10.0 (2024-04-06, old kixelated/web-transport-rs layout, hence the baseline paths without rs/). release-plz picks the registry baseline with max_by_key(version) over every index entry, yanked included (release_plz_core/src/clone/mod.rs, query_latest_package_summary). So cargo-semver-checks diffed against that 2024 API (WebError, one-arg Session::new, Send types) and flagged a break. The 0.7.0 and 0.8.0 minor bumps were the same false positive.

Fix: semver_check = false for web-transport-wasm only, with a comment. The real break detection for this crate is lost until its version passes 0.10.0, at which point the override can go.

Known residual: because the local package never matches the 0.10.0 baseline, release-plz still includes wasm in each release PR as a patch bump ("update Cargo.toml dependencies"). Expected outcome for #404: wasm 0.8.1 instead of 0.9.0.

Public API / wire impact: none (release config only).

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

crates.io lists a yanked web-transport-wasm 0.10.0 from 2024, and
release-plz uses the highest published version (yanked included) as the
cargo-semver-checks baseline, so every release was flagged as breaking.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T03:29:14.620052Z 833b300 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 833b300.

No actionable bugs found. The [[package]] override at release-plz.toml:11–13 correctly limits the disabled semver check to web-transport-wasm. I independently confirmed the yanked 0.10.0 registry entry, the highest-version selection in release-plz, and no files changed under rs/web-transport-wasm since the 0.8.0 tag.

Direction: reasonable as an explicitly temporary workaround. It suppresses genuine API-break detection too, so breaking changes still need deliberate version selection. The lasting fix is a correct release-plz baseline or an intentional version migration beyond the old registry entry, followed by removing this override. The disclosed recurring patch bumps remain unresolved.

Verification: static config, workflow, registry, tag comparison, and upstream-source inspection only. No release-plz dry run, build, or tests executed locally; I have not independently verified the predicted 0.8.1 release output. CI was still running.

(Written by review (OpenAI))

@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 75e1555d-6bc6-4dbf-a89b-08de4021c206

📥 Commits

Reviewing files that changed from the base of the PR and between 5ba65af and 833b300.

📒 Files selected for processing (1)
  • release-plz.toml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

The release-plz configuration now disables semver checks for web-transport-wasm. A comment states that other crates use release-plz defaults.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 833b3

The release workflow applies the semver exemption to web-transport-wasm as intended. No concrete release or API failure is identified, so the change is mergeable under its documented temporary tradeoff.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to 833b3

The exception is limited to web-transport-wasm compatibility checks. It does not expand publishing permissions, expose credentials, or change application behavior. No material security risk was identified in this change.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The directly affected control is release-time compatibility validation for web-transport-wasm. The diff does not broaden the set of packages exempted from validation or add a credential, permission, or execution path.

Trust Boundaries and Controls

  • observed — The existing release workflow uses GitHub App credentials with contents and pull-request write permissions, plus a registry publishing token. This PR does not modify those credentials, permissions, the main-branch trigger, or the repository-owner condition.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the release configuration change for web-transport-wasm.
Description check ✅ Passed The description directly explains the false semver check, the targeted configuration override, and its known residual behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated enabled auto-merge (squash) October 2, 2026 03:38
@kixelated
kixelated merged commit a8bde1f into main Oct 2, 2026
1 check passed
@kixelated
kixelated deleted the fix/wasm-semver-baseline branch October 2, 2026 03:47
@kixelated kixelated mentioned this pull request Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant