Repository navigation
chore: release - #430
chore: release#430
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bda9db2b4f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| [target.'cfg(target_arch = "wasm32")'.dependencies] | ||
| web-transport-wasm = { version = "0.8.3", path = "../web-transport-wasm" } | ||
| web-transport-wasm = { version = "0.9.0", path = "../web-transport-wasm" } |
There was a problem hiding this comment.
Bump the facade before changing its published dependency
Because the parent commit already released web-transport 0.13.4, changing only its WASM dependency requirement cannot update that version's crates.io manifest: the release workflow cannot republish 0.13.4, so downstream web-transport consumers will continue resolving web-transport-wasm 0.8.3 rather than the new 0.9.0 release. Assign web-transport a new version and corresponding changelog entry so this dependency change is actually publishable.
Useful? React with 👍 / 👎.
|
|
||
| ### Other | ||
|
|
||
| - release ([#418](https://github.com/moq-dev/web-transport/pull/418)) |
There was a problem hiding this comment.
Remove the duplicate 0.13.4 release section
This adds a second 0.13.4 heading immediately above the existing section for the same version and comparison range, splitting one release's notes across duplicate entries and incorrectly presenting PR #418 as a later release. Consolidate the note into the existing section or create a genuinely new version entry.
AGENTS.md reference: AGENTS.md:L65-L66
Useful? React with 👍 / 👎.
| - *(wasm)* set waitUntilAvailable when opening streams ([#370](https://github.com/moq-dev/web-transport/pull/370)) | ||
| - *(wasm)* fail with a clear error when web_sys_unstable_apis is unset ([#336](https://github.com/moq-dev/web-transport/pull/336)) | ||
| - *(wasm)* advertise subprotocols for negotiation ([#253](https://github.com/moq-dev/web-transport/pull/253)) |
There was a problem hiding this comment.
Limit the 0.9.0 notes to changes after 0.8.3
The new section claims to describe the 0.8.3...0.9.0 comparison, but it lists changes such as #370, #381, and #315 that are already documented under earlier releases and are ancestors of the 0.8.3 release commit. This makes users believe 0.9.0 newly introduces fixes and breaking changes they already received; regenerate the entry from the actual post-0.8.3 range.
AGENTS.md reference: AGENTS.md:L65-L66
Useful? React with 👍 / 👎.
81c199d to
436ce2d
Compare
436ce2d to
0f7e6a0
Compare
🤖 New release
web-transport-trait: 0.5.0 -> 0.5.1 (✓ API compatible changes)qmux: 0.6.3 -> 0.6.4 (✓ API compatible changes)web-transport-quinn: 0.13.2 -> 0.13.3 (✓ API compatible changes)web-transport-wasm: 0.8.3 -> 0.8.4web-transport-iroh: 0.8.3 -> 0.8.4 (✓ API compatible changes)web-transport-noq: 0.4.2 -> 0.4.3 (✓ API compatible changes)web-transport-quiche: 0.8.1 -> 0.8.2 (✓ API compatible changes)web-transport: 0.13.4 -> 0.13.5Changelog
web-transport-traitqmuxweb-transport-quinnweb-transport-wasmweb-transport-irohweb-transport-noqweb-transport-quicheweb-transportThis PR was generated with release-plz.