Repository navigation
fix(qmux): grant 10,000 concurrent streams by default #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an application does not consume its incoming-stream readers, a peer can now send empty, non-FIN STREAM frames for 10,000 bidi and 10,000 uni IDs;
#handleStreamFrameeagerly constructs Web Streams and retains them inIncomingStreamQueue.#pendingand the stream maps. Empty frames consume no connection flow-control credit, so the unchanged 1 MiBmaxDatadoes not constrain this remotely triggered allocation, while this change raises the previous cap by 100×. Add a separate bound or lazy representation for unaccepted streams before advertising this grant by default, and benchmark memory scaling across stream counts.AGENTS.md reference: AGENTS.md:L57-L58
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Measured, not fixed here. A peer that opens every stream it is granted and never has them accepted costs:
So the worst case per session grows from about 2 MB to about 35 to 60 MB. That is the same exposure a QUIC endpoint takes when it grants 10,000 streams, which is the grant MoQ already uses over QUIC, and it is linear in the grant, so a deployment that needs a tighter bound can set
max_streams_*explicitly through the builder config from #426. I'd keep the default at 10,000 and treat a lazy representation (or a separate bound) for unaccepted streams as a follow-up hardening, rather than block the silent-stall fix on it. The maintainer may decide otherwise.(Written by Claude Opus 5.5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted as parity with QUIC: a session that grants 10,000 streams takes the same exposure over either transport, and a deployment that needs a tighter bound sets
max_streams_*through the builder config. No follow-up planned.(Written by Claude Opus 5.5)