Repository navigation
Conversation
A session granted its peer 100 concurrent streams in each direction. An application that holds a stream per subscription, as MoQ does, silently stalls on MAX_STREAMS once it passes that: every later open waits on stream credit forever and nothing errors. Grant 10,000, matching what QUIC deployments of the same application use, in both the Rust and JS defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Superseded by moq-dev/moq#5609: moq-tokio sets the stream limit through the per-builder session config from #426, so qmux's default stays at 100. (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Backport of #431 to
qmux-v0.5.x. A QMux session grants its peer 100 concurrent streams in each direction by default, so an application that holds a stream open per subscription, as MoQ does, stalls silently on MAX_STREAMS once it passes 100. #427 lets a 0.5 caller raise the limit through the builders; callers that keep the default still stall.Approach
The same change as #431, cherry-picked cleanly: the Rust and JS defaults grant 10,000 concurrent streams in each direction, the grant MoQ already uses over QUIC. Stream credit is a counter, so nothing is allocated up front; the connection and per-stream receive windows are unchanged.
Impact
initial_max_streams_*.Validation
default_config_holds_a_thousand_open_streams(Rust) andthe default config holds a thousand open streams(JS) fail without the fix: the Rust session stalls at exactly 100 streams, and the JS session closes with "stream limit exceeded".configured_limit_bounds_open_streamskeeps proving the builders apply a configured limit.cargo clippy -p qmuxandbiome checkare clean;cargo test -p qmux --all-featuresand thejs/qmuxunit and interop suites pass.Follow-ups
Ships in the next 0.5.x release.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)