Skip to content

fix(qmux): grant 10,000 concurrent streams by default (0.5) - #432

Closed
kixelated wants to merge 1 commit into
qmux-v0.5.xfrom
fix/qmux-default-streams-0.5
Closed

kixelated wants to merge 1 commit into
qmux-v0.5.xfrom
fix/qmux-default-streams-0.5

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

Backport of #431 to qmux-v0.5.x. A QMux session grants its peer 100 concurrent streams in each direction by default, so an application that holds a stream open per subscription, as MoQ does, stalls silently on MAX_STREAMS once it passes 100. #427 lets a 0.5 caller raise the limit through the builders; callers that keep the default still stall.

Approach

The same change as #431, cherry-picked cleanly: the Rust and JS defaults grant 10,000 concurrent streams in each direction, the grant MoQ already uses over QUIC. Stream credit is a counter, so nothing is allocated up front; the connection and per-stream receive windows are unchanged.

Impact

  • Public API: no signature changes. The default grant changes from 100 to 10,000; a caller that relied on the default as a cap should set it explicitly.
  • Wire format: unchanged. Sessions advertise a larger initial_max_streams_*.

Validation

  • default_config_holds_a_thousand_open_streams (Rust) and the default config holds a thousand open streams (JS) fail without the fix: the Rust session stalls at exactly 100 streams, and the JS session closes with "stream limit exceeded".
  • configured_limit_bounds_open_streams keeps proving the builders apply a configured limit.
  • cargo clippy -p qmux and biome check are clean; cargo test -p qmux --all-features and the js/qmux unit and interop suites pass.

Follow-ups

Ships in the next 0.5.x release.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

A session granted its peer 100 concurrent streams in each direction. An
application that holds a stream per subscription, as MoQ does, silently
stalls on MAX_STREAMS once it passes that: every later open waits on stream
credit forever and nothing errors. Grant 10,000, matching what QUIC
deployments of the same application use, in both the Rust and JS defaults.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T18:53:51.073108Z e43393c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Superseded by moq-dev/moq#5609: moq-tokio sets the stream limit through the per-builder session config from #426, so qmux's default stays at 100.

(Written by Claude Opus 5.5)

@kixelated kixelated closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant