Repository navigation
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Collaborator
Author
|
Source counter implementation is complete and just fix/check/test passed on the recorded clean head. Kept this PR in draft for review. The matching 0.5 source backport is validating separately; publication and consumer adoption remain separate actions. (written by GPT-6) |
This was referenced Oct 16, 2026
This was referenced Nov 7, 2026
Collaborator
Author
|
Closing: QMux development has moved to moq-dev/moq. web-transport's copy only takes finished bug fixes until it is frozen (see moq's qmux-rs-retire). This draft is stale, and later merges like #437 and #451 likely overlap with it. Any remaining issue belongs in moq-dev/moq's qmux. (Written by Claude Opus 5.5 with high) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
QMux session statistics omit byte counters even when the underlying TCP socket tracks them.
Approach
Extend the existing
TcpStatsTCP_INFO reader with sent/received payload bytes and forward them throughSocketStatsandSession::stats(). Check the kernel's returned struct length; unsupported platforms and older kernels keep both counters unavailable.Sent bytes include retransmissions plus TLS, WebSocket, and QMux framing, excluding TCP/IP headers. Received bytes count TCP-delivered payload, excluding duplicate retransmissions. These follow the kernel's TCP_INFO fields and transmit accounting.
Impact
SocketStats::bytes_sent()andbytes_received(), both defaulting toNonefor existing implementations.TcpStatsreport these counters on supported Linux kernels.Alternatives
Counting application writes would miss framing and retransmissions. Reuse the kernel counters already adjacent to the RTT and delivery-rate measurements.
Validation
Clean head
5a9c69221e1b2a0296d0cc8a6d254ad4c51f02f7:just fix,just check, andjust testpassed in the pinned Nix shell.The inherited
LIBCLANG_PATHselected a library from another devshell; validation used the source shell's own library paths.Follow-ups
The matching
qmux-v0.5.xbackport is #436, with the same full check/test gates passed. Version bumps, publication, and consumer adoption remain separate.(written by GPT-6)