Repository navigation
Exercise packaged Node bindings and lifecycle in PR CI - #452
Conversation
Blocked on packaging scope: the published entry point exports src/index.ts, which Node rejects inside node_modules. No release packaging correction has been applied. A disposable compiled-JS/declaration packaging prototype passes all runtime cases, natural exit, and forced teardown. The timeout experiment fails as expected and removes its temporary stage. just fix, package type checking, Node syntax checking, quest validation, and diff checks passed; just check is still running. Full just test has not been run for this checkpoint.
|
Checkpoint complete and clean at The staging-only JS/declaration prototype passes all runtime assertions and natural/forced process exits. The deliberately lingering-handle experiment fails within its deadline and confirms child/stage cleanup. Decision needed: authorize the recommended narrow JS/declaration/prepack/entry-point correction within this quest while preserving NAPI platform/release layout, or split a packaging prerequisite quest. This PR stays draft and the quest stays open until that boundary is settled. (written by GPT-6) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The user's “finish up please,” following unattended recommended-action authorization, settles the prior packaging boundary: complete the required JS/declaration/prepack/export correction within this Node runtime quest and merge the finished in-flight work. No separate prerequisite quest or further decision remains. Public exports, versions, NAPI platform artifacts/release layout, and wire behavior are preserved. The actual built-and-packed native artifact passes all Node lifecycle, close/wakeup, natural-exit, and forced-teardown checks. The isolated declaration consumer and package lint pass. Codex completed an independent review of current head (written by GPT-6) |
|
Taking over this stale draft (last active 2026-10-20). The maintainer approved the takeover and lifted the earlier pause in a /quest-complete session. I'll merge (Written by Claude Opus 5.5) |
Keep main's bun tests and biome-formatted napi build alongside the dist/ build, and exclude the packaged-consumer type check from the source tsconfig since it only resolves against the packed package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary for head
(Written by Claude Opus 5.5) |
This PR builds and packs the real NAPI package, installs it, and exercises its entry point under Node. The test covers connection setup, uni/bi streams, datagrams, close information, reader wakeups, natural process exit, and forced teardown. A separate
Node runtimePR workflow runs it for every PR, so shared Rust and build changes are covered too. Bounded subprocess cleanup removes the temporary stages.The installed-package test reproduced Node refusing to load the exported TypeScript source from inside
node_modules. The package now compiles JavaScript and declarations intodist/and exports those files. They are built throughprepackand during release preparation.Python CI also exposed a close race in the mixed-stream fixture. The fixture now confirms it received every uni stream through their echoes, and the browser closes only after consuming them. Swallowed write errors are removed. No production close behavior, skips, retries, or CI deadlines changed.
Compatibility
./src/index.tsto./dist/index.js+./dist/index.d.ts.src/is still shipped.Choices made without asking
main(Kotlin runtime CI moq-dev/web-transport#495, Node server close moq-dev/web-transport#485,WebTransportErrormoq-dev/web-transport#470, release moq-dev/web-transport#465).package.json: kept main'sbun test tests, itstsconfig.tests.jsoncheck, and its Biome formatting of the generated NAPI files (now inbuild:native), plus this PR'sbuild:js,prepack, andtest:runtime.tsconfig.tests.jsonexcludestests/consumer.ts. That file imports@moq/web-transportby package name, so it only resolves against the packed package, andtest:runtimetype-checks it there.Validation
7335abf), locally:just fix,just check,quest check --base origin/main,bun run check,build,test(7 pass), andtest:runtime(natural and forced runs passed).603f33f, locally: all 311 Python tests passed with debug bindings and Chromium 145, along with 100 independent mixed-stream sessions. CI on7335abfis all green, including thewheeljob (the mixed-stream test no longer hangs), all release-wheel builds,runtime(packaged Node),build,chromium, and Kotlin/JVM.Closes the Node child of
/quest/a1/bindings/README.md.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)