Repository navigation
feat(quinn)!: accept caller-provided transport configuration - #489
Conversation
Quest-Claim: cf3c47ab8e7ef7d3
Own TransportConfig in the Quinn builders and apply explicit congestion choices as an overlay. Cover client finishing paths, server endpoint construction, defaults, and setter order. Document the builder Clone migration. (Written by GPT-6.1 Sol with xhigh)
Forward the existing typed Quinn configuration from the native router builder and compare transport test state using Quinn-generated expected output. (Written by GPT-6.1 Sol with xhigh)
|
Design change: expose The new head also compares transport Debug state against a Quinn-formatted expected configuration instead of fixed field/value strings. The builder (Written by GPT-6.1 Sol with xhigh) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary: landing head c8c820f as is.
(Written by Claude Opus 5.5) |
Keep #489's owned TransportConfig and port its transport tests into client/tests.rs, starting connections through the lazy client endpoints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep #489's owned TransportConfig, build #490's lazy per-family client endpoints with crypto::endpoint_config(), and run #490's client tests on the default rind provider. Rebuild the README's manual client example on Client::from with system roots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Quinn's client and server builders now accept an owned
quinn::TransportConfigthroughwith_transport_config, preserving caller-provided transport settings through the existing TLS and endpoint finishing paths. The native router client builder forwards the same typed configuration.Explicit
LowLatencyandThroughputchoices override only the supplied congestion controller, independently of setter order.Defaultclears the override and preserves the supplied controller. Omitting the input retains Quinn's defaults.Compatibility and choices
web_transport_quinn::ClientBuilderand nativeweb_transport::ClientBuilderno longer implementClone, because Quinn's TransportConfig is not cloneable. Migration: construct a builder for each configuration, then clone the finishedClientto share its endpoint and settings. This ownership choice was explicitly authorized by the user.Validation
Passed on c8c820f38a88d9cfbabfeccbd32847971d0feccb, using the Nix development shell and
quest gate:just fix,just check, andjust test, including native/WASM tests, doctests, QMux interop, and Node polyfill testscargo test -p web-transport-quinn --no-default-features --features ringquest check --base origin/mainand diff checksRegressions cover caller timeout/keepalive settings and defaults through all four client finishing paths and server configuration; custom controller preservation; explicit congestion overlays in both setter orders; clearing the overlay with
Default; and the actual controller selected by server endpoint construction. Expected transport state is formatted using the same Quinn Debug implementation as actual state, so field/value formatting changes affect both sides equally.Review
Latest local review: Claude Code,
claude-opus-5-5, medium effort, new session round 1, reviewed c8c820f38a88d9cfbabfeccbd32847971d0feccb. No findings remain.Prior findings were fixed: native router configuration access and tests that assumed fixed Debug field/value formatting. The approved builder
Cloneremoval is documented with migration guidance. Concrete controller assertions are retained because they verify this repository's existing BBR/CUBIC selections reach the endpoint; the custom-factory counter alone would miss an incorrect built-in selection. These dispositions are recorded in the design and review response.The review used the coordinator-provided installed Quest binary because the repository-pinned shell binary lacks the review command/skill. No maintainer decision remains open.
Follow-ups
No new follow-ups. Node-facing options remain owned by their existing quest.
(Written by GPT-6.1 Sol with xhigh)