Skip to content

feat(quinn)!: accept caller-provided transport configuration - #489

Merged
kixelated merged 3 commits into
mainfrom
quest/a1/node-idle/native-transport-config
Nov 8, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/a1/node-idle/native-transport-config

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Quinn's client and server builders now accept an owned quinn::TransportConfig through with_transport_config, preserving caller-provided transport settings through the existing TLS and endpoint finishing paths. The native router client builder forwards the same typed configuration.

Explicit LowLatency and Throughput choices override only the supplied congestion controller, independently of setter order. Default clears the override and preserves the supplied controller. Omitting the input retains Quinn's defaults.

Compatibility and choices

  • Breaking public API: web_transport_quinn::ClientBuilder and native web_transport::ClientBuilder no longer implement Clone, because Quinn's TransportConfig is not cloneable. Migration: construct a builder for each configuration, then clone the finished Client to share its endpoint and settings. This ownership choice was explicitly authorized by the user.
  • The Quinn builders and native router accept the backend's existing typed configuration directly. The router's forwarding method keeps configuration available to router clients after the builder ownership change; no new cross-platform configuration type or callback API is introduced.
  • Client system-root, certificate, certificate-hash, and disabled-verification paths use the shared finishing path. Server construction composes its transport configuration before creating the endpoint.
  • TLS verification, crypto providers, ALPN, wire formats, and package versions are unchanged. The parallel rind migration remains separate.
  • Remove the completed quest and its references, unblocking the Node-options quest once merged.

Validation

Passed on c8c820f38a88d9cfbabfeccbd32847971d0feccb, using the Nix development shell and quest gate:

  • just fix, just check, and just test, including native/WASM tests, doctests, QMux interop, and Node polyfill tests
  • cargo test -p web-transport-quinn --no-default-features --features ring
  • quest check --base origin/main and diff checks

Regressions cover caller timeout/keepalive settings and defaults through all four client finishing paths and server configuration; custom controller preservation; explicit congestion overlays in both setter orders; clearing the overlay with Default; and the actual controller selected by server endpoint construction. Expected transport state is formatted using the same Quinn Debug implementation as actual state, so field/value formatting changes affect both sides equally.

Review

Latest local review: Claude Code, claude-opus-5-5, medium effort, new session round 1, reviewed c8c820f38a88d9cfbabfeccbd32847971d0feccb. No findings remain.

Prior findings were fixed: native router configuration access and tests that assumed fixed Debug field/value formatting. The approved builder Clone removal is documented with migration guidance. Concrete controller assertions are retained because they verify this repository's existing BBR/CUBIC selections reach the endpoint; the custom-factory counter alone would miss an incorrect built-in selection. These dispositions are recorded in the design and review response.

The review used the coordinator-provided installed Quest binary because the repository-pinned shell binary lacks the review command/skill. No maintainer decision remains open.

Follow-ups

No new follow-ups. Node-facing options remain owned by their existing quest.

(Written by GPT-6.1 Sol with xhigh)

@kixelated kixelated changed the title Accept typed native transport configuration feat(quinn)!: accept caller-provided transport configuration Nov 7, 2026
Own TransportConfig in the Quinn builders and apply explicit congestion choices as an overlay. Cover client finishing paths, server endpoint construction, defaults, and setter order. Document the builder Clone migration.

(Written by GPT-6.1 Sol with xhigh)
Forward the existing typed Quinn configuration from the native router builder and compare transport test state using Quinn-generated expected output.

(Written by GPT-6.1 Sol with xhigh)

Copy link
Copy Markdown
Collaborator Author

Design change: expose with_transport_config on the native router client builder as a direct forwarding method for the existing Quinn type. Local review found that removing the wrapper builder's Clone without configuration access left router users unable to configure their client. The forwarding method fixes that gap without a cross-platform configuration abstraction or TLS/provider changes.

The new head also compares transport Debug state against a Quinn-formatted expected configuration instead of fixed field/value strings. The builder Clone removal remains the user's explicitly approved API decision. Concrete BBR/CUBIC endpoint assertions remain because they verify the current selections in client::controller_factory; the factory counter alone cannot detect an incorrect built-in selection. These are the responses to local review round 1, and the next review starts a new session for the API addition.

(Written by GPT-6.1 Sol with xhigh)

@kixelated
kixelated marked this pull request as ready for review November 7, 2026 10:05
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0e58b4c1-01fe-47c0-894d-bd22448885a2
Commits

Reviewing files that changed from the base of the PR and between 7cc85bd and c8c820f.

Files selected for processing: 8

  • quest/a1/node-idle/README.md
  • quest/a1/node-idle/native-transport-config.md
  • quest/a1/node-idle/options.md
  • rs/web-transport-quinn/README.md
  • rs/web-transport-quinn/src/client.rs
  • rs/web-transport-quinn/src/server.rs
  • rs/web-transport/README.md
  • rs/web-transport/src/quinn.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T10:06:40.154705Z c8c820f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: landing head c8c820f as is.

  • CI: all 5 checks passed; GitHub reports the PR mergeable and clean against main.
  • Review: Codex finished its review of this head with no findings. CodeRabbit hit its rate limit and didn't review.
  • quest check --base origin/main --branch quest/a1/node-idle/native-transport-config passes. The PR deletes the finished quest and its links.
  • Breaking change: the native and Quinn ClientBuilder types no longer implement Clone, as the PR body documents. The user approved this.
  • No open decisions. This is the first PR in the Quinn chain: moq-dev/web-transport#490 and then moq-dev/web-transport#488 rebase onto it after it lands.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 85270d0 into main Nov 8, 2026
5 checks passed
@kixelated
kixelated deleted the quest/a1/node-idle/native-transport-config branch November 8, 2026 17:09
@moq-bot moq-bot Bot mentioned this pull request Nov 8, 2026
kixelated added a commit that referenced this pull request Nov 8, 2026
Keep #489's owned TransportConfig and port its transport tests into
client/tests.rs, starting connections through the lazy client endpoints.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated added a commit that referenced this pull request Nov 8, 2026
Keep #489's owned TransportConfig, build #490's lazy per-family client
endpoints with crypto::endpoint_config(), and run #490's client tests on
the default rind provider. Rebuild the README's manual client example on
Client::from with system roots.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant