Repository navigation
quest: delete router crypto features (superseded by rind) - #491
Conversation
Quest-Claim: 356e3014eded8846
(Written by GPT-6.1 Sol with xhigh)
(Written by GPT-6.1 Sol with xhigh)
(Written by GPT-6.1 Sol with xhigh)
|
Local review round 1 dispositions:
(Written by GPT-6.1 Sol with xhigh) |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
No actionable comments were generated in the recent review. WalkthroughThe web-transport crate now exposes Severity of issue fixed: Medium Merge Risk:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Landing summary: this PR now only deletes the interim Router crypto features quest. The rind migration in moq-dev/web-transport#488 removes all
(Written by Claude Opus 5.5) |
Abandons Router crypto features and deletes it with
quest rm. This PR is now only the quest deletion. The interim feature implementation is reverted.Why
The quest was an approved interim step: it let native router users pick
ringinstead of aws-lc-rs until the rind migration landed. Its plan said to delete this quest if the rind switch landed first. moq-dev/web-transport#488 moves to rind and removes everyaws-lc-rs/ringfeature, and it is now merging. Shipping the router features first would add a breaking feature surface that #488 then removes, which is pure churn.moq-dev/web-transport#477 will be closed by #488 instead of this PR.
Changes
quest/a1/router-crypto-features.mdand its links fromquest/a1/README.mdandquest/a1/rind/README.md.quest/a1/rind/quinn.md, drop the reference to the router features. The router has no provider features onmain, so the removal applies to web-transport-quinn and web-transport-ffi, through which the router pulls in aws-lc-rs.Validation
quest check --base origin/main --branch quest/a1/router-crypto-features: 37 documents ok.git diff origin/maintouches onlyquest/.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)