Skip to content

quest: delete router crypto features (superseded by rind) - #491

Merged
kixelated merged 7 commits into
mainfrom
quest/a1/router-crypto-features
Nov 8, 2026
Merged

kixelated merged 7 commits into
mainfrom
quest/a1/router-crypto-features

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Abandons Router crypto features and deletes it with quest rm. This PR is now only the quest deletion. The interim feature implementation is reverted.

Why

The quest was an approved interim step: it let native router users pick ring instead of aws-lc-rs until the rind migration landed. Its plan said to delete this quest if the rind switch landed first. moq-dev/web-transport#488 moves to rind and removes every aws-lc-rs/ring feature, and it is now merging. Shipping the router features first would add a breaking feature surface that #488 then removes, which is pure churn.

moq-dev/web-transport#477 will be closed by #488 instead of this PR.

Changes

  • Delete quest/a1/router-crypto-features.md and its links from quest/a1/README.md and quest/a1/rind/README.md.
  • In quest/a1/rind/quinn.md, drop the reference to the router features. The router has no provider features on main, so the removal applies to web-transport-quinn and web-transport-ffi, through which the router pulls in aws-lc-rs.
  • No code, API, wire, or version changes.

Validation

  • quest check --base origin/main --branch quest/a1/router-crypto-features: 37 documents ok.
  • git diff origin/main touches only quest/.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@kixelated kixelated changed the title Forward crypto-provider features through the router crate feat(router): forward native crypto-provider features Nov 7, 2026
@kixelated kixelated changed the title feat(router): forward native crypto-provider features feat(router)!: forward native crypto-provider features Nov 7, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Local review round 1 dispositions:

  • Generic native client construction with neither feature: refuted against the recorded maintainer decision. It explicitly gates ClientBuilder and retains Session/Server conversion for callers configuring Quinn directly. Converting a configured native client into the generic client while preserving subprotocols is separately owned by the native-client-composition quest. This interim change preserves that boundary.
  • Panic when Cargo unifies both providers: the same Plan explicitly preserves the existing installed-provider rule and excludes changing Quinn's selection behavior. Documentation now explicitly warns that another dependency can enable the second backend provider.
  • Single-provider tests missing from CI: fixed by running the crypto integration test with each provider separately in just test, in addition to the existing all-feature run.
  • Provider identity not asserted: fixed by comparing cipher suites and named key-exchange groups against the selected rustls backend, and by checking Arc identity with the installed process-wide provider in the both-feature case.

(Written by GPT-6.1 Sol with xhigh)

@kixelated
kixelated marked this pull request as ready for review November 7, 2026 10:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T17:11:11.701810Z 447f61e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 67e31bb1-d3c4-4d40-b51f-f54b9f8fce90
Commits

Reviewing files that changed from the base of the PR and between 14d3821 and 447f61e.

Files selected for processing: 4

  • quest/a1/README.md
  • quest/a1/rind/README.md
  • quest/a1/rind/quinn.md
  • quest/a1/router-crypto-features.md

No actionable comments were generated in the recent review.

Walkthrough

The web-transport crate now exposes aws-lc-rs and ring features, with aws-lc-rs enabled by default. The native ClientBuilder is available only when either feature is enabled. Documentation describes provider precedence, native behavior, and unchanged WASM availability. A crypto-provider test and separate test runs cover the provider configurations. The related planning document and references were also updated or removed.

Severity of issue fixed: Medium

Merge Risk: Minimal · previous review 14d38

No actionable issue remains that should block this feature change from merging after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Linked Issues check Passed [#477] The router forwards ring and aws-lc-rs and disables Quinn backend defaults. The default remains aws-lc-rs. The reported ring-only dependency graph excludes aws-lc-sys, and WASM remains …
Out of Scope Changes check Passed [#477] The feature gating, provider documentation, tests, CI commands, and quest updates support the router crypto feature work. The exact rind quest diff was unavailable, but its summarized follow-up…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Title check Passed The title names the main change: deleting the router crypto features quest document because rind supersedes it. The changeset deletes quest/a1/router-crypto-features.md and removes its links in quest/…
Description check Passed The description states that the PR abandons the Router crypto features quest and deletes it. It lists the changed files, explains why the quest is superseded by the rind migration in PR 488, and says …
Full details: Linked Issues check

Explanation

[#477] The router forwards ring and aws-lc-rs and disables Quinn backend defaults. The default remains aws-lc-rs. The reported ring-only dependency graph excludes aws-lc-sys, and WASM remains unaffected. The provider test and single-provider CI commands cover provider selection.

Full details: Out of Scope Changes check

Explanation

[#477] The feature gating, provider documentation, tests, CI commands, and quest updates support the router crypto feature work. The exact rind quest diff was unavailable, but its summarized follow-up change relates to these interim features.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (4 skipped: 4 unsupported.)

Full details: Title check

Explanation

The title names the main change: deleting the router crypto features quest document because rind supersedes it. The changeset deletes quest/a1/router-crypto-features.md and removes its links in quest/a1/README.md, quest/a1/rind/README.md, and quest/a1/rind/quinn.md. The title is specific and consistent with the changes.

Full details: Description check

Explanation

The description states that the PR abandons the Router crypto features quest and deletes it. It lists the changed files, explains why the quest is superseded by the rind migration in PR 488, and says no code, API, wire, or version changes are included. This matches the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e74bb8e7-cb86-47d2-8d39-e93bc6f6b3bf
Commits

Reviewing files that changed from the base of the PR and between 7cc85bd and 14d3821.

Files selected for processing: 10

  • justfile
  • quest/a1/README.md
  • quest/a1/rind/README.md
  • quest/a1/rind/quinn.md
  • quest/a1/router-crypto-features.md
  • rs/web-transport/Cargo.toml
  • rs/web-transport/README.md
  • rs/web-transport/src/lib.rs
  • rs/web-transport/src/quinn.rs
  • rs/web-transport/tests/crypto.rs
Files with no reviewable changes: 3

  • quest/a1/rind/README.md
  • quest/a1/README.md
  • quest/a1/router-crypto-features.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@kixelated kixelated changed the title feat(router)!: forward native crypto-provider features quest: delete router crypto features (superseded by rind) Nov 8, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing summary: this PR now only deletes the interim Router crypto features quest. The rind migration in moq-dev/web-transport#488 removes all aws-lc-rs/ring features, so shipping them first would only add churn. The previous feature implementation was reverted to main. moq-dev/web-transport#477 will be closed by #488.

  • Head 447f61ed0cb5fdff087ace2f55ba4df0de787b5b: CI passed, Codex reacted 👍 (no findings), and quest check passed against the current main.
  • Choice: quest/a1/rind/quinn.md now says to remove the providers from web-transport-quinn and web-transport-ffi, since the router has no provider features of its own on main.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 30b1813 into main Nov 8, 2026
4 checks passed
@kixelated
kixelated deleted the quest/a1/router-crypto-features branch November 8, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant