Repository navigation
Conversation
Quest-Claim: e6429dc8ef058b93
Preserve the draft migration and upstream packet-key and BLAKE3 blockers before readiness. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft migration of web-transport-iroh to rind. Not ready: iroh reaches the same upstream packet-key incompatibility as the Noq migration, and BLAKE3 retains a C-toolchain dependency in the shipped graph.
Changes
crypto::default_provider(): reuse the installed rustls provider, otherwise construct rind-rustls's provider after its CPU check. ReturnCryptoError::UnsupportedCpuwith the original error; do not install a process-wide provider.aws-lc-rs/ringfeatures. Keep iroh defaults disabled and require iroh 1.4 for the provider interface.presets::Emptyand the explicit provider, so they expose the upstream runtime failure rather than accidentally using ring.Compatibility and choices
Breaking Rust API/configuration change: remove the
aws-lc-rsandringCargo features; callers configure their endpoints with the fallible provider helper. Iroh'sMinimal/N0presets are gated on its built-in provider features, so the example usespresets::Empty; applications configure relays/address lookup explicitly. The remaining features aremetrics,portmapperandqlog.This crate already accepts caller-created endpoints and owns no endpoint builder. The recommended implementation therefore exposes the small composable provider helper at endpoint configuration time instead of introducing a parallel builder.
Client::new()stays infallible. There are no direct rind primitives requiring a CPU check when an installed provider wins. rind supports x86_64, aarch64 and 32-bit ARM; aarch64 requires NEON, and other architectures including WASM cannot compile rind.No version bump or intended QUIC/HTTP/3 wire change. The current stable rind provider cannot perform the iroh handshake, so this draft must not ship. No local packet-suite adapter, provider fallback, test suppression, pinned harness change or graph exception has been added.
Waiting
rind-rustlsrelease implementing rustls QUICPacketKey::encrypt_in_place_for_pathanddecrypt_in_place_for_path. Stable 0.23.0 lacks both. iroh 1.4.1 depends on Noq 1.4.0, which calls the encryption method even for path 0 and unwraps its defaultEncryptErroratnoq-proto/src/crypto/rustls.rs:649. Require the fixed release, complete CPU-refusal coverage, rerun raw QUIC/H3 and repository checks, then run/quest-review. An upstream implementation plus stable publication is recommended; no local duplicate adapter is authorized.ccbuild dependency. Both iroh 1.4.1 and iroh-relay 1.4.1 reachblake3 1.8.7 -> cc 1.11.1. BLAKE3'spurefeature still retainscc, so it does not meet the rind epic's literal normal/build graph requirement. Recommend resolving this upstream and preserving the no-C-crypto criterion. Narrowing the epic to TLS providers would require a maintainer decision.Validation
All local commands ran in the Nix shell; builds/tests used the installed
quest gate.just fix: passed.cargo test -p web-transport-iroh --test crypto: passed. The dedicated integration-test process verifies rind fallback, no global installation and exact installed-provider precedence.ring,aws-lc-rs,aws-lc-sys, iroh's test-utils and iroh-relay's server feature. This is dependency resolution, not cross-compilation.ccremains through BLAKE3, so the full epic graph goal fails.cargo test -p web-transport-iroh --all-features tests::h3_smoke -- --exact --nocapture: compiled, then failed withEncryptErrorat Noq's unwrap; poisoned-lock cleanup caused SIGABRT.just test: failed with the same error intests::quic_smoke; subsequent suites did not run. This is a migration blocker, not a passing/pre-existing-failure exception.just check: failed at the pinnedquest checkbefore compilation, because that older CLI rejects the required## Waitingheading (allowed: Goal, Plan, Required, Closes, Related). The installed Quest binary accepts it:quest check --base origin/mainpasses. The pinned tool and runner remain unchanged; no altered full run is reported as passing.git diff --check: passed. The Python wheel runner was not run; it is unaffected and unchanged.Runtime reproduction:
Remaining inverse graph:
Review
Local cross-vendor
quest reviewand readiness are deferred because the migration is unfinished and its transport tests abort with the current stable provider. No review skip or approval is claimed. Run/quest-iterateafter the outside conditions clear, complete validation, then/quest-reviewbefore marking ready.Suggested follow-ups
Waitingformat and localquest reviewcommand. No pin change is included in this crate migration.(Written by GPT-6.1 Sol with xhigh)