Skip to content

quest: plan CI, tooling, and TypeScript QMux credit follow-ups - #513

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/ci-followups
Nov 11, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/ci-followups

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Plans the follow-ups reported by this session's merge agents. Quests only, with no code, API, or wire changes. quest check passes.

  • quest/a0/quinn-crypto-flake.md [S]: crypto::upstream_handshake_retry_key_update_and_reset fails ~1.5% (a datagram is missing in Pair::traffic), which can fail the required build on any PR. Find the mechanism, fix the lowest layer, no retries.
  • quest/a0/quest-pin.md [XS]: the merge driver passes --marker-size, which the flake's pinned quest 0.1.0 rejects, so link-list auto-resolve crashes on every local merge. Bump the pin.
  • quest/a0/qmux-recv-credit-js.md [S]: the TypeScript QMux leaks connection credit after cancel. cancel deletes the entry from #recvStreams, so later STREAM data and RESET_STREAM gaps return before any accounting (verified in js/qmux/src/session.ts). This is the sibling of quest/a0/qmux-recv-credit.md, whose out-of-scope note now links it.
  • quest/a1/bindings/wheel-ubuntu-26.md [XS]: the wheel job fails on ubuntu-latest (now 26.04) because the locked Playwright 1.58.0 won't download Chromium there. Added as the first child of the bindings epic, which drops its size per the epic rule.

The two CI/tooling quests rank first in a0 because they affect every PR.

Dropped after checking:

  • The Kotlin/JVM check failure, which passed on moq-dev/web-transport#486's latest run.
  • Not selected: committing Cargo.lock, the DROP_CODE comment fix, and regenerating napi.cjs.

Decisions

Which CI/tooling follow-ups become quests? (multi-select)

  • ✅ Flaky quinn crypto test
  • ✅ wheel on Ubuntu 26.04
  • ✅ Bump quest pin
  • Commit Cargo.lock

Which code follow-ups become quests? (multi-select)

  • ✅ TS QMux credit leak
  • DROP_CODE comment
  • Regenerate napi.cjs

CI/tooling placement

  • ✅ Both in a0
  • Flaky in a0, pin in a1
  • Both in a1

wheel fix

  • ✅ Bump Playwright, and pin the job to ubuntu-24.04 only if no release supports 26.04
  • Pin runner to 24.04
  • Nix-provided browsers

wheel placement

  • ✅ Child of the a1 bindings epic
  • Standalone in a0

TS QMux leak

  • ✅ Separate a0 quest that mirrors the refused-stream path
  • Fold into the Rust quest

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4de9625c-024c-48d3-9cf7-cad654c29cd2
Commits

Reviewing files that changed from the base of the PR and between d221362 and e0401d1.

Files selected for processing: 7

  • quest/a0/README.md
  • quest/a0/qmux-recv-credit-js.md
  • quest/a0/qmux-recv-credit.md
  • quest/a0/quest-pin.md
  • quest/a0/quinn-crypto-flake.md
  • quest/a1/bindings/README.md
  • quest/a1/bindings/wheel-ubuntu-26.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T08:31:22.196882Z e0401d1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Head e0401d1feb75678d1d2b47a332970701c7106989 reviewed by Codex with no findings; CodeRabbit was rate-limited and posted no review.
  • Required build passed. The optional wheel check fails on Playwright/Ubuntu 26.04, which is the failure quest/a1/bindings/wheel-ubuntu-26.md plans to fix.
  • No changes were made to the PR. The decisions recorded in the body stand.
  • quest check --base origin/main passes (22 documents). Main has since merged moq-dev/web-transport#499, which touches only quest/a1/README.md and quest/a1/response-headers.md. Neither overlaps this PR.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 5b8af64 into main Nov 11, 2026
6 of 7 checks passed
@kixelated
kixelated deleted the quest-plan/ci-followups branch November 11, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant