Repository navigation
quest: plan CI, tooling, and TypeScript QMux credit follow-ups - #513
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Merge summary:
(Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plans the follow-ups reported by this session's merge agents. Quests only, with no code, API, or wire changes.
quest checkpasses.quest/a0/quinn-crypto-flake.md[S]:crypto::upstream_handshake_retry_key_update_and_resetfails ~1.5% (a datagram is missing inPair::traffic), which can fail the requiredbuildon any PR. Find the mechanism, fix the lowest layer, no retries.quest/a0/quest-pin.md[XS]: the merge driver passes--marker-size, which the flake's pinned quest 0.1.0 rejects, so link-list auto-resolve crashes on every local merge. Bump the pin.quest/a0/qmux-recv-credit-js.md[S]: the TypeScript QMux leaks connection credit after cancel.canceldeletes the entry from#recvStreams, so later STREAM data and RESET_STREAM gaps return before any accounting (verified injs/qmux/src/session.ts). This is the sibling ofquest/a0/qmux-recv-credit.md, whose out-of-scope note now links it.quest/a1/bindings/wheel-ubuntu-26.md[XS]: thewheeljob fails onubuntu-latest(now 26.04) because the locked Playwright 1.58.0 won't download Chromium there. Added as the first child of the bindings epic, which drops its size per the epic rule.The two CI/tooling quests rank first in a0 because they affect every PR.
Dropped after checking:
Cargo.lock, theDROP_CODEcomment fix, and regeneratingnapi.cjs.Decisions
Which CI/tooling follow-ups become quests? (multi-select)
Which code follow-ups become quests? (multi-select)
CI/tooling placement
wheel fix
wheel placement
TS QMux leak
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code