Skip to content

chore(quest): bump the dev shell's quest so the merge driver resolves link lists - #518

Merged
kixelated merged 4 commits into
mainfrom
quest/a0/quest-pin
Nov 11, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/a0/quest-pin

Conversation

@kixelated

@kixelated kixelated commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/a0/quest-pin.md: local merges auto-resolve quest link lists again.

Changes

  • Pin. flake.nix moves the quest input from kixelated/quest@ed657ba (0.1.0) to moq-dev/quest@f3301ef (0.2.0, current main). The repository moved to moq-dev/quest; kixelated/quest only redirects. flake.lock follows, adding quest's own nixpkgs-bun and quest-pinned inputs.
  • Stricter quest check. 0.2.0 rejects an epic that lists its own children under ## Required, since an epic already waits for everything in its directory. quest check --fix removed those entries from quest/README.md and the a0, a1, a1/bindings, a1/rind, and a2 READMEs. The a0, a1, and a2 Plans dropped the sentence "The Required list is ordered by priority", which no longer describes anything.
  • Skill stubs and agent pointer. quest init (0.2.0) refreshed .claude/skills/ (reached from .agents/skills): quest-ready became quest-review, quest-grill, quest-run, and quest-unblock are new, and each stub's setup link points at moq-dev/quest. It also rewrote the quest pointer line in CLAUDE.md (AGENTS.md links to it) from quest guide to quest context.
  • Deleted the finished quest.

No public API or wire impact.

Choices made without asking

  • Latest main, not a release tag. The quest asked for current main. quest has no release tag newer than 0.1.0 to pin instead.
  • moq-dev/quest URL. The input points at the repository's current home rather than the kixelated/quest redirect.
  • feat(check): drop links to finished quests after a local merge, upgrade old merge drivers, and keep quest-pinned current quest#427 adopted with no configuration. Its driver upgrade runs on any quest command and edits only the clone's local git config. Its quest-pinned upkeep is quest's own Dependabot group and needs nothing here. This repository's input is pinned to a SHA, so Dependabot does not bump it. Adding that upkeep here would be repository configuration, which the quest ruled out.
  • Priority order inside milestones. The removed lists ordered each milestone's children by priority. quest 0.2.0 has no place for that: quest unblocked ranks a milestone's work by downstream impact, then path. The only way to keep the order would be sibling Required links, which would block work that does not depend on them. I accepted the tool's ranking.
  • Stubs and pointer refreshed in this PR. quest init writes them for the pinned binary, so they belong with the bump. Without the refresh, /quest-ready would run quest skill ready, which 0.2.0 no longer has.

Verification

  • Repro, in a scratch clone with this clone's exact merge.quest.driver: two branches each add one entry to the Required list in quest/a2/quinn-adapter-removal.md.
    • With 0.1.0 on PATH, the merge fails: error: unknown option '--marker-size=7' and quest: quest resolve failed, so link lists ... were not auto-resolved.
    • With 0.2.0, the merge succeeds and keeps both entries.
  • nix develop --command quest --version prints quest 0.2.0, and quest help resolve lists --marker-size.
  • nix run .#quest -- check (the Quest workflow's command) passes with 18 documents. So does quest check --base origin/main, and nix flake check --no-build passes.
  • Not run locally: the rest of just check (cargo and bun), since this PR changes no Rust or JavaScript. pr.yml runs it.
  • x86_64-darwin: the 0.2.0 flake no longer builds quest for that system. Our dev shell already fails to evaluate there, because pinned nixpkgs dropped x86_64-darwin. No CI job uses the Nix shell on macOS.

Caused by

No single PR. moq-dev/web-transport#469 pinned 0.1.0, which matched the driver at the time. A newer quest outside this repository later registered the --marker-size driver in the clone's git config.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, Claude Opus 5.5, high effort

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with high)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, low effort
  • Session: 01a1ca26-0f0c-72d2-9980-215b4237d9ec, round 1
  • Head: a686e9b
  • Base: origin/main at 141e1ee
  • Score: 9/10, The scoped diff has no identifiable actionable defects, and the Quest pin, skill stubs, and plan migration appear consistent, though builds and checks were not run as instructed.
  • Findings: none

kixelated and others added 3 commits November 11, 2026 01:59
Quest-Claim: 990118f10e6a6717
The pinned moq-dev/quest@ed657ba (0.1.0) rejects the merge driver's
--marker-size flag, so local merges never auto-resolved quest link lists.
Pin moq-dev/quest@f3301ef (0.2.0, the repository's new home), apply its
stricter check's fix (epics no longer list their own children), and
refresh the skill stubs and agent pointer with quest init.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Bump the dev shell's quest chore(quest): bump the dev shell's quest so the merge driver resolves link lists Nov 11, 2026
@kixelated
kixelated marked this pull request as ready for review November 11, 2026 10:28
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1f24e999-f83d-4727-8f35-81136d8911fe
Commits

Reviewing files that changed from the base of the PR and between 840c2f6 and 220ed79.

Files ignored due to path filters: 1

  • flake.lock is excluded by !**/*.lock
Files selected for processing: 25

  • .claude/skills/quest-afk/SKILL.md
  • .claude/skills/quest-audit/SKILL.md
  • .claude/skills/quest-complete/SKILL.md
  • .claude/skills/quest-delete/SKILL.md
  • .claude/skills/quest-export/SKILL.md
  • .claude/skills/quest-grill/SKILL.md
  • .claude/skills/quest-import/SKILL.md
  • .claude/skills/quest-iterate/SKILL.md
  • .claude/skills/quest-merge/SKILL.md
  • .claude/skills/quest-plan/SKILL.md
  • .claude/skills/quest-ready/SKILL.md
  • .claude/skills/quest-recurring/SKILL.md
  • .claude/skills/quest-review/SKILL.md
  • .claude/skills/quest-run/SKILL.md
  • .claude/skills/quest-spawn/SKILL.md
  • .claude/skills/quest-start/SKILL.md
  • .claude/skills/quest-unblock/SKILL.md
  • CLAUDE.md
  • flake.nix
  • quest/README.md
  • quest/a0/README.md
  • quest/a0/quest-pin.md
  • quest/a1/README.md
  • quest/a1/rind/README.md
  • quest/a2/README.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T20:01:22.867812Z 220ed79 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

# Conflicts:
#	quest/a0/README.md
#	quest/a1/README.md
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main (through #511, #514, #515, #516 and #517) into this branch in 220ed79. Two conflicts were resolved by hand:

  • quest/a0/README.md and quest/a1/README.md: main's edits only removed finished children from the epics' ## Required lists. Under quest 0.2.0 those lists go away entirely, so I kept this branch's version. main's quest-file deletions (qmux-recv-credit-js, quinn-crypto-flake, a0/quiche, wheel-ubuntu-26, ffi-platform-verifier) came through cleanly.

The old pin's merge driver failed during this merge with unknown option '--marker-size=7', which is the bug this PR fixes.

Checks: quest check --base origin/main --branch quest/a0/quest-pin passes with quest 0.2.0 (moq-dev/quest@f3301ef, the version this PR pins and the one the Quest workflow runs). quest 0.1.0 rejects the 0.2.0 format as expected.

(Written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Changes: bumps the dev shell's quest to moq-dev/quest@f3301ef (0.2.0), so the merge.quest.driver's --marker-size flag works. Runs quest init and deletes the finished quest/a0/quest-pin.md.
  • Decisions accepted: 0.2.0's stricter check removes the epics' priority-order ## Required sentences and lists. quest init changes CLAUDE.md's quest guide to quest context, renames /quest-ready to /quest-review, and adds the new skill stubs.
  • Base merge: hand-resolved in 220ed79 (details above). Codex 👍 on that head.
  • Checks: quest check --base origin/main passes with 0.2.0, and the Quest workflow passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) November 11, 2026 20:06
@kixelated
kixelated merged commit 713611a into main Nov 11, 2026
8 checks passed
@kixelated
kixelated deleted the quest/a0/quest-pin branch November 11, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant