Repository navigation
Release qmux 0.5.4 with the receive-credit fix - #541
Conversation
Quest-Claim: e13b78b163ea8258
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Maintainer decision (via
(Written by Claude Opus 5.5 with high) |
qmux 0.5.4 is on crates.io and tagged qmux-v0.5.4 at 3625c96. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Docs-only change to quest files.
- Deleted
quest/a0/qmux-05-recv-credit.md: the 0.5.4 release has shipped, so the tracking quest is removed. - Added
quest/a0/qmux-discard-race.md: a follow-up that ports the counter-basedRecvStream::discardfix tomain, with the maintainer's decision recorded.
claude-sonnet-5-5 | 𝕏
|
No actionable comments were generated in the recent review. WalkthroughThe pull request removes the qmux 0.5.4 receive-credit release plan. It adds a quest document describing a RecvStream discard race, a proposed Unread counter fix and test, and a limitation in draining with older supported Tokio versions. Merge Risk:
|

Finishes quest/a0/qmux-05-recv-credit.md on
mainby deleting it, now that its release has shipped.The release itself landed in moq-dev/web-transport#543, based on
qmux-v0.5.x(its body holds the release audit). This claim branch was cut frommainand cannot be retargeted without a force-push, so this PR is the main-side PR the quest's Plan calls for. (@moq/qmux 0.3.5 landed first in moq-dev/web-transport#542, so the deletion is this PR's.)Summary
quest/a0/qmux-05-recv-credit.md; no other document links to it.quest/a0/qmux-discard-race.mdand records the maintainer's decision in its Plan.Release
3625c96onqmux-v0.5.x. Its tree (e2a5207) is identical to the audited and reviewed head00a2038(git diffempty), and crates.io had no 0.5.4 before publishing.cargo publish -p qmuxran from a clean checkout of3625c96. crates.io servesqmux0.5.4 (created 2026-11-15T09:59:03Z, not yanked).qmux-v0.5.4points at3625c96:git ls-remote origin refs/tags/qmux-v0.5.4returns3625c961cccaf24e48b8fd252f44a1e9e1d9df90.Decisions
From the maintainer's decision comment:
quest/a0/qmux-discard-race.mdat a0 (rejected: move to a1, drop), so main's race fix lands before any qmux release from main. Recorded in its Plan.Follow-ups
RecvStream::discardcan miss a reader send already in flight when it closes the channel, leaking connection credit on multi-threaded runtimes. fix(qmux): return connection credit for stopped receive streams (0.5.4) #543 fixes it on 0.5; this quest ports the counter-based fix and its test tomain, which has the same code from fix(qmux): return connection credit for stopped receive streams #520. Kept at a0 per the decision above; no open decisions.Validation
Quest files only, no code behavior to exercise.
quest check --base origin/mainpasses. The release checks are under## Release.Public API and wire impact
None in this PR.
qmux0.5.4's impact is in #543's audit.Models
Size: M
Implementer: Claude, claude-opus-5-5, unknown effort (arm A)
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, S)
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 603c7c5
Base: origin/main at 9c1474f
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, high effort
Session:
01a1dea6-253e-7a20-9a08-6be7ebd311c7, round 1Score: 10/10,
The documentation-only change updates release plans without changing executable code, and no actionable defects were found.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, medium effort, shadow
Session:
01a1dea6-259c-7332-b7a5-959783402bab, round 1Score: 10/10,
The focused documentation-only change replaces a release-tracking quest with a follow-up race-fix plan and has no actionable defects.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none