Skip to content

Release qmux 0.5.4 with the receive-credit fix - #541

Merged
kixelated merged 5 commits into
mainfrom
quest/a0/qmux-05-recv-credit
Nov 15, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/a0/qmux-05-recv-credit

Conversation

@kixelated

@kixelated kixelated commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/a0/qmux-05-recv-credit.md on main by deleting it, now that its release has shipped.

The release itself landed in moq-dev/web-transport#543, based on qmux-v0.5.x (its body holds the release audit). This claim branch was cut from main and cannot be retargeted without a force-push, so this PR is the main-side PR the quest's Plan calls for. (@moq/qmux 0.3.5 landed first in moq-dev/web-transport#542, so the deletion is this PR's.)

Summary

  • Deletes quest/a0/qmux-05-recv-credit.md; no other document links to it.
  • Adds follow-up quest/a0/qmux-discard-race.md and records the maintainer's decision in its Plan.

Release

  • fix(qmux): return connection credit for stopped receive streams (0.5.4) #543 squash-merged as 3625c96 on qmux-v0.5.x. Its tree (e2a5207) is identical to the audited and reviewed head 00a2038 (git diff empty), and crates.io had no 0.5.4 before publishing.
  • cargo publish -p qmux ran from a clean checkout of 3625c96. crates.io serves qmux 0.5.4 (created 2026-11-15T09:59:03Z, not yanked).
  • Tag qmux-v0.5.4 points at 3625c96: git ls-remote origin refs/tags/qmux-v0.5.4 returns 3625c961cccaf24e48b8fd252f44a1e9e1d9df90.

Decisions

From the maintainer's decision comment:

  • ✅ Merge moq-dev/web-transport#543 (rejected: skip, delete). Merging approved publishing 0.5.4 and pushing its tag, both done above.
  • ✅ Keep follow-up quest/a0/qmux-discard-race.md at a0 (rejected: move to a1, drop), so main's race fix lands before any qmux release from main. Recorded in its Plan.

Follow-ups

Validation

Quest files only, no code behavior to exercise. quest check --base origin/main passes. The release checks are under ## Release.

Public API and wire impact

None in this PR. qmux 0.5.4's impact is in #543's audit.

Models

Size: M
Implementer: Claude, claude-opus-5-5, unknown effort (arm A)
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, S)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Head: 603c7c5

  • Base: origin/main at 9c1474f

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1dea6-253e-7a20-9a08-6be7ebd311c7, round 1

  • Score: 10/10, The documentation-only change updates release plans without changing executable code, and no actionable defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, medium effort, shadow

  • Session: 01a1dea6-259c-7332-b7a5-959783402bab, round 1

  • Score: 10/10, The focused documentation-only change replaces a release-tracking quest with a follow-up race-fix plan and has no actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 3 commits November 14, 2026 23:17
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Maintainer decision (via /quest-run):

(Written by Claude Opus 5.5 with high)

qmux 0.5.4 is on crates.io and tagged qmux-v0.5.4 at 3625c96.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 15, 2026 10:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T10:01:20.273214Z 603c7c5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated enabled auto-merge (squash) November 15, 2026 10:01

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Docs-only change to quest files.

  • Deleted quest/a0/qmux-05-recv-credit.md: the 0.5.4 release has shipped, so the tracking quest is removed.
  • Added quest/a0/qmux-discard-race.md: a follow-up that ports the counter-based RecvStream::discard fix to main, with the maintainer's decision recorded.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request removes the qmux 0.5.4 receive-credit release plan. It adds a quest document describing a RecvStream discard race, a proposed Unread counter fix and test, and a limitation in draining with older supported Tokio versions.

Merge Risk: Minimal · up to 603c7

This change only updates internal planning documents after the qmux 0.5.4 release. It does not alter runtime behavior, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title says the PR releases qmux 0.5.4 with the receive-credit fix. The objectives and description confirm the PR deletes the receive-credit quest after that release shipped and adds the follow-up …
Description check Passed The description states the PR deletes quest/a0/qmux-05-recv-credit.md after the qmux 0.5.4 release shipped and adds quest/a0/qmux-discard-race.md. It links the release PR, the publish commit, the tag,…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title says the PR releases qmux 0.5.4 with the receive-credit fix. The objectives and description confirm the PR deletes the receive-credit quest after that release shipped and adds the follow-up discard-race quest. The title names the release, but the diff itself only changes quest documents, so the title is partially related: it describes the release that the PR records, not the file changes. It is specific enough for a reader scanning history.

Full details: Description check

Explanation

The description states the PR deletes quest/a0/qmux-05-recv-credit.md after the qmux 0.5.4 release shipped and adds quest/a0/qmux-discard-race.md. It links the release PR, the publish commit, the tag, and the maintainer decision, and it states that the PR changes quest files only. This matches the changeset, so the description is on-topic and detailed.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9b50c046-1437-4c23-a2f1-7111646274f2
Commits

Reviewing files that changed from the base of the PR and between 9c1474f and 603c7c5.

Files selected for processing: 2

  • quest/a0/qmux-05-recv-credit.md
  • quest/a0/qmux-discard-race.md
Files with no reviewable changes: 1

  • quest/a0/qmux-05-recv-credit.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@kixelated
kixelated merged commit 66974a1 into main Nov 15, 2026
8 checks passed
@kixelated
kixelated deleted the quest/a0/qmux-05-recv-credit branch November 15, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant