Repository navigation
ci(pullfrog): give reviews the dev shell's tools #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
200ff55
ci(pullfrog): give reviews the dev shell's tools
kixelated 54047e1
ci(pullfrog): fail on a failed print-dev-env, scrub the token from ni…
kixelated c7d1e76
ci(pullfrog): keep the job token off disk and the runner user untrust…
kixelated c9a49ed
quest: plan fixing the flaky finished-read waker test
kixelated 2425391
ci(pullfrog): fail the setup if the Nix daemon trusts the runner user
kixelated 2b5f854
Merge remote-tracking branch 'origin/main' into pullfrog/dev-shell
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # [S] A finished quiche read sometimes still holds its waker | ||
|
|
||
| ## Goal | ||
|
|
||
| `a_finished_read_releases_the_poller` in | ||
| `rs/web-transport-quiche/tests/ez_wakers.rs` passes every run. It fails about | ||
| one run in 200 on `main` (0cb7412), and failed CI's `build` job on | ||
| [moq-dev/web-transport#545](https://github.com/moq-dev/web-transport/pull/545), | ||
| which changes only a workflow: after the read completes and the test drops its | ||
| own `Waker`, `Arc::strong_count` of the poller's waker is 2, not 1. | ||
|
|
||
| ## Plan | ||
|
|
||
| Find whether the extra reference is a real retention in the ez read path or | ||
| the test racing the driver: the test runs on a two-thread runtime, so a wake | ||
| in flight on the driver thread may hold a clone just as the count is read. | ||
| Fix the retention if it is one; if it is a transient clone, make the test | ||
| wait on the event that releases it rather than reading the count once, | ||
| without a sleep or retry. Reproduce with | ||
| `for i in $(seq 200); do cargo test -q -p web-transport-quiche --test ez_wakers a_finished_read_releases_the_poller || break; done`. | ||
|
|
||
| Caused by: [moq-dev/web-transport#353](https://github.com/moq-dev/web-transport/pull/353) | ||
| added the test and the waker release it checks. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.