refactor(repo): drop bun for vitest, node, and esbuild by haydenshively · Pull Request #130 · morpho-org/morpho-bots

haydenshively · 2026-08-05T13:26:59Z

Remove Bun in favor of Vitest, Node, and esbuild

#129 has merged, so this PR targets main directly and completes the repository migration away from Bun:

moves the test surface to Vitest plus the Node playground suites;
runs bots on Node and bundles them with esbuild;
replaces Bun runtime APIs with Node equivalents;
moves installs and workspace commands to pnpm;
removes Bun from CI, deployment workflows, live operator instructions, and container images; and
preserves soltag compilation through its Vitest/esbuild integrations.

The reconciliation also ports the market-making bootstrap, field-visibility, Railway deployment, and Railway utility work inherited from main.

Review remediation

ports both market-making deployment workflows to the shared pnpm/Node setup and updates the Pages workflow contract test;
rebuilds the market-making image on Node 24.14.1 with Corepack/pnpm, an isolated frozen install, build-time bundling, and an unprivileged runtime;
restores the root market-making:playground alias and removes remaining live Bun commands and runtime descriptions;
returns pnpm to its isolated linker default and verifies the frozen install without adding unnecessary dependencies;
makes both fake Vite executables consume the production --outDir contract and adds an executable regression test; and
removes the obsolete Bun cleanup branch while keeping test selection platform-aware.

Validation

clean pnpm install --frozen-lockfile with pnpm's isolated layout
pnpm -r run typecheck
pnpm lint
pnpm format
pnpm knip
focused Pages, playground build/process/serve/smoke/browser-smoke suites, including temporary assertion inversions to prove modified tests fail non-vacuously
pnpm --filter @morpho-org/market-making-bot run jsdoc:build
forge test --root packages/contracts --offline -vv — 16 passed
git diff --check
all four bot images build, run as UID 1000, contain no Bun executable, and reach their expected fail-loud configuration boundary

The local pnpm test run completed 1,666 tests with 2 skipped; its only three failing suites require the unavailable RPC_URL_8453 credential. GitHub Actions supplies that credential and is authoritative for the full-suite result.

devin-ai-integration

Devin Review found 3 potential issues.

View 3 additional findings in Devin Review.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce08fe4a6e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Addresses review on #130. - tryCatch branched on `fn instanceof Promise`, so an execa subprocess — a thenable that is NOT a native Promise, yet typed `extends Promise<Result>` — fell through to the sync path and got *called*. Every deploy would have reported "Railway CLI not found" from assertCli() before reaching Railway. It now branches on callable and assimilates the thenable via Promise.resolve, which also lets the ad-hoc Promise.resolve() wrappers at the other execa call sites go away so all of them read the same. - Restored `prestart` on all four bots. `start` runs `dist/src/index.js`, which a clean checkout does not have; the images build at image-build time and their CMD never fires a pre-script, so this only affects the documented local path. `{.}...` scopes the build to the bot plus its workspace deps. - market-making declares `vite` (its vitest.config.ts imports loadEnv) instead of relying on root hoisting, matching the two liquidation bots. - Registered scripts/bundle-failed.error.ts in check-jsdoc.ts, typedoc.json, and the build-jsdoc skill inventory. - .claude/commands: babysit-pr's validate block runs `pnpm test`, review.md's stack list names vitest/esbuild/Node. (CLAUDE.md's remaining "bun" is a verbatim past commit title used as a format example, so it stays.) - Declaring vite in market-making shifted knip's peer attribution and exposed root `tsx` as unused. It is not: `node --import tsx` and the CLI subprocess tests resolve it from the root, and dropping it fails two market-making tests. knip now ignores it explicitly, with the reason recorded at the usage. Verified: 1417 pass / 1 skip / 136 files (fork suites included, RPC_URL_8453 supplied); the two new tryCatch tests reproduce `fn is not a function` against the old implementation; a real execa call through tryCatch now succeeds for a present binary and still errors for a missing one; all four bots build from wiped dists via prestart and reach their fail-loud config check; all three images build, run as uid=1000(node), carry no bun binary, and reach that same check; pnpm lint 0/0, knip clean, 12/12 typecheck, jsdoc:build exits 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

haydenshively · 2026-08-05T18:08:09Z

Heads-up: GitHub reports this stacked PR as conflicting, and git disagrees

GitHub shows mergeable: CONFLICTING / mergeStateStatus: DIRTY, which is also why no Checks run has fired on this branch since 13:27Z — the workflow only triggers on pull_request opened/synchronize, and GitHub skips that when it cannot compute the merge.

There was a real conflict, and it is now fixed. main gained #121/#124/#125 after this branch's merge-base, and a stacked PR's mergeability is computed against main, not against the immediate parent — which is why #129 stayed green while this one went dirty. main is merged in as of ddacbad, along with the mechanical port of what it brought (8 more files off bun:test, Bun.file/Bun.serve/Bun.sleep, and 3 more floating expect(...).rejects).

After that merge, git reports no conflict from any angle:

conflicts vs main:                 0
behind main by:                    0
base (chore/migrate-to-pnpm) is an ancestor of head:  yes
compare base...head:               status "ahead", behind_by 0

GitHub has not recomputed. The usual escape hatches are both closed for a stack:

PUT /pulls/130/update-branch → 403 Updating a stacked PR's branch via this endpoint is not supported.
gh pr edit --base … → Cannot change the base branch because the pull request is part of a stack.

A rebase onto the updated parent (verified byte-identical tree) and a fresh push did not clear it either.

What is needed: someone with the PR open in the browser hitting the stack's Restack / Update control, which is the only path the API leaves for a stacked PR. Merging #129 first would also collapse the stack and moot it. Once the state clears, Checks will run on the next push.

Everything is verified locally in the meantime: 1459 pass / 1 skip / 141 files (fork suites included), vitest collects exactly the 141 tracked *.test.ts with zero delta, pnpm lint 0/0, knip clean, 12/12 typecheck, jsdoc:build exits 0, and all three images build, run as uid=1000(node), and reach their fail-loud config check.

haydenshively · 2026-08-05T18:21:01Z

Resolved — the stack is rebased and checks are running

My previous comment said this needed the Restack control in the browser. That was wrong: the fix is gh stack (the official github/gh-stack extension), which the repo's stack was created with.

gh stack checkout 131   # stack #131: main <- #129 <- #130 <- #134
gh stack rebase
gh stack push

All three PRs now report mergeable: true (blocked is just the pending required review), and Checks fired on all three for the first time since 13:27Z.

Two notes on what the rebase needed by hand:

Linearizing dropped the merge commit, and with it the bun:test → vitest ports for the seven files main had added. They are restored as their own commit (refactor(market-making): port main's new test files off bun:test), and the resulting tree is byte-identical to the merge-based state that was verified.
The rebase tried to replay main's own 14 commits on top of #129 — they were only reachable through that merge commit and are already in the new base's ancestry, so they were dropped from the todo rather than re-applied.

Verified after the restack, per branch:

	#129	#130	#134
own contribution vs. pre-rebase	identical	tree byte-identical	identical (same 25 files)
tests	—	1459 pass / 1 skip / 141 files	1522 pass / 1 skip / 142 files
lint · knip · typecheck	✓	0/0 · clean · 12/12	0/0 · clean · 12/12

Addresses review on #130. - tryCatch branched on `fn instanceof Promise`, so an execa subprocess — a thenable that is NOT a native Promise, yet typed `extends Promise<Result>` — fell through to the sync path and got *called*. Every deploy would have reported "Railway CLI not found" from assertCli() before reaching Railway. It now branches on callable and assimilates the thenable via Promise.resolve, which also lets the ad-hoc Promise.resolve() wrappers at the other execa call sites go away so all of them read the same. - Restored `prestart` on all four bots. `start` runs `dist/src/index.js`, which a clean checkout does not have; the images build at image-build time and their CMD never fires a pre-script, so this only affects the documented local path. `{.}...` scopes the build to the bot plus its workspace deps. - market-making declares `vite` (its vitest.config.ts imports loadEnv) instead of relying on root hoisting, matching the two liquidation bots. - Registered scripts/bundle-failed.error.ts in check-jsdoc.ts, typedoc.json, and the build-jsdoc skill inventory. - .claude/commands: babysit-pr's validate block runs `pnpm test`, review.md's stack list names vitest/esbuild/Node. (CLAUDE.md's remaining "bun" is a verbatim past commit title used as a format example, so it stays.) - Declaring vite in market-making shifted knip's peer attribution and exposed root `tsx` as unused. It is not: `node --import tsx` and the CLI subprocess tests resolve it from the root, and dropping it fails two market-making tests. knip now ignores it explicitly, with the reason recorded at the usage. Verified: 1417 pass / 1 skip / 136 files (fork suites included, RPC_URL_8453 supplied); the two new tryCatch tests reproduce `fn is not a function` against the old implementation; a real execa call through tryCatch now succeeds for a present binary and still errors for a missing one; all four bots build from wiped dists via prestart and reach their fail-loud config check; all three images build, run as uid=1000(node), carry no bun binary, and reach that same check; pnpm lint 0/0, knip clean, 12/12 typecheck, jsdoc:build exits 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Completes the toolchain consolidation started by the pnpm migration. All 136 test files move from bun:test to vitest (soltag sol`` via its vite adapter, fork-suite env via loadEnv); bots bundle with esbuild and run plain node dist/src/index.js; images are node-slim with no bun binary; CI drops setup-bun and runs pnpm test. Bun APIs replaced: Bun.env->process.env (59), Bun.spawn->node:child_process, Bun.serve->node:http, Bun.file->readFile, Bun.sleep->node:timers/promises, Bun.which, Bun.argv->process.argv, import.meta.dir/main, bun's $ shell->execa, global confirm()->node:readline/promises, and the `bun` module type imports. Bun.build in @repo/contracts also moves to esbuild. Three latent bugs surfaced and are fixed: - 24 floating expect(...).rejects assertions that bun's typings hid. They never asserted anything; oxlint's no-floating-promises catches them under vitest typings. - Anvil fork ports collided once files ran in parallel. bun's runner was serial, so fixed ports were only deconflicted within a bot. Every fork suite now claims a distinct port and the registry is documented. - fetch.preconnect in http-json.utils.ts was a bun-only extension to fetch. Two bounds are raised because the interpreter genuinely changed: a tsx cold start costs ~1.3s against bun's ~0.1s, so the market-making subprocess tests get a 30s ceiling and the FIFO fail-closed probe a 10s bound. Both still prove what they were written to prove. Evidence: vitest collects exactly the same 136 files as bun (diffed, zero delta, including the one test outside test/); @repo/contracts' abis/*.json and dist/index.d.ts are byte-identical across Bun.build->esbuild; the secret path in deploy-railway still reaches stdin and never argv (probed); all 11 projects verified non-vacuous. Full suite green: 1415 pass, 1 skip. CRTR-2822 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Addresses review on #130. - tryCatch branched on `fn instanceof Promise`, so an execa subprocess — a thenable that is NOT a native Promise, yet typed `extends Promise<Result>` — fell through to the sync path and got *called*. Every deploy would have reported "Railway CLI not found" from assertCli() before reaching Railway. It now branches on callable and assimilates the thenable via Promise.resolve, which also lets the ad-hoc Promise.resolve() wrappers at the other execa call sites go away so all of them read the same. - Restored `prestart` on all four bots. `start` runs `dist/src/index.js`, which a clean checkout does not have; the images build at image-build time and their CMD never fires a pre-script, so this only affects the documented local path. `{.}...` scopes the build to the bot plus its workspace deps. - market-making declares `vite` (its vitest.config.ts imports loadEnv) instead of relying on root hoisting, matching the two liquidation bots. - Registered scripts/bundle-failed.error.ts in check-jsdoc.ts, typedoc.json, and the build-jsdoc skill inventory. - .claude/commands: babysit-pr's validate block runs `pnpm test`, review.md's stack list names vitest/esbuild/Node. (CLAUDE.md's remaining "bun" is a verbatim past commit title used as a format example, so it stays.) - Declaring vite in market-making shifted knip's peer attribution and exposed root `tsx` as unused. It is not: `node --import tsx` and the CLI subprocess tests resolve it from the root, and dropping it fails two market-making tests. knip now ignores it explicitly, with the reason recorded at the usage. Verified: 1417 pass / 1 skip / 136 files (fork suites included, RPC_URL_8453 supplied); the two new tryCatch tests reproduce `fn is not a function` against the old implementation; a real execa call through tryCatch now succeeds for a present binary and still errors for a missing one; all four bots build from wiped dists via prestart and reach their fail-loud config check; all three images build, run as uid=1000(node), carry no bun binary, and reach that same check; pnpm lint 0/0, knip clean, 12/12 typecheck, jsdoc:build exits 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

main gained #121/#124/#125 after this branch's merge-base, adding test files that still import bun:test and call bun's mock(). Linearizing the stack dropped these conversions along with the merge commit that carried them, so they are restored here as their own commit: 7 files moved to vitest imports and mock() -> vi.fn(). Tree is byte-identical to the verified pre-rebase state. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

haydenshively · 2026-08-11T14:33:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4bc9c0ab0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cashd

I think this can use a /simplify run - otherwise lgtm

julien-devatom · 2026-08-11T16:12:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1c85dbd73

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

linear-code · 2026-08-11T18:42:56Z

CRTR-2999

haydenshively self-assigned this Aug 5, 2026

haydenshively requested a review from cashd August 5, 2026 13:41

haydenshively marked this pull request as ready for review August 5, 2026 13:41

devin-ai-integration Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread bots/market-making/vitest.config.ts

Comment thread .claude/commands/review.md

Comment thread bots/market-making/scripts/bundle-failed.error.ts

chatgpt-codex-connector Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread bots/blue-liquidation/scripts/deploy-railway.ts

Comment thread bots/blue-liquidation/package.json

haydenshively mentioned this pull request Aug 5, 2026

fix(bots): count only broadcast submits and explain skipped plans #134

Open

haydenshively force-pushed the refactor/remove-bun branch from c135e89 to c644283 Compare August 5, 2026 17:58

haydenshively force-pushed the refactor/remove-bun branch from ddacbad to 0244681 Compare August 5, 2026 18:20

haydenshively force-pushed the refactor/remove-bun branch from 0244681 to fc4087e Compare August 7, 2026 15:57

haydenshively force-pushed the refactor/remove-bun branch from fc4087e to b9e5524 Compare August 7, 2026 16:14

haydenshively force-pushed the refactor/remove-bun branch from b9e5524 to 9b903a6 Compare August 7, 2026 16:18

Base automatically changed from chore/migrate-to-pnpm to main August 7, 2026 18:52

haydenshively force-pushed the refactor/remove-bun branch from e0783c9 to cfd1133 Compare August 7, 2026 18:52

haydenshively and others added 8 commits August 11, 2026 09:25

fix(repo): reconcile migration with main

96d901f

fix(market-making): build playground with vite

6c9dac2

ci(checks): run browser smoke with pnpm

2f09bd5

fix(market-making): preserve relative playground assets

0acd366

test(market-making): stabilize node playground smoke

bede192

fix(market-making): port main additions off bun

c4bc9c0

haydenshively force-pushed the refactor/remove-bun branch from fbf6a3d to c4bc9c0 Compare August 11, 2026 14:28

haydenshively requested a review from julien-devatom August 11, 2026 14:33

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread .github/actions/setup/action.yml

Comment thread bots/market-making/vitest.config.ts

Comment thread package.json Outdated

Comment thread bots/blue-liquidation/package.json Outdated

cashd approved these changes Aug 11, 2026

View reviewed changes

Comment thread .agents/skills/build-jsdoc/SKILL.md Outdated

haydenshively added 3 commits August 11, 2026 10:55

fix(repo): cover playground checks with pnpm

058c276

test(market-making): rename migrated tool fixtures

4e85f0c

fix(market-making): restore dynamic jsdoc inventory

c1c85db

julien-devatom approved these changes Aug 11, 2026

View reviewed changes

test(market-making): tolerate reaped install children

97afb1b

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

fix(repo): finish bun removal migration

adda072

haydenshively merged commit 9d93f4f into main Aug 11, 2026
6 checks passed

haydenshively deleted the refactor/remove-bun branch August 11, 2026 18:42

Uh oh!

Conversation

haydenshively commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Remove Bun in favor of Vitest, Node, and esbuild

Review remediation

Validation

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

haydenshively commented Aug 5, 2026

Heads-up: GitHub reports this stacked PR as conflicting, and git disagrees

Uh oh!

haydenshively commented Aug 5, 2026

Resolved — the stack is rebased and checks are running

Uh oh!

haydenshively commented Aug 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cashd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

julien-devatom commented Aug 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linear-code Bot commented Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

haydenshively commented Aug 5, 2026 •

edited

Loading