refactor: rename market-making to quoter-bot - #138
Conversation
56740ea to
ad49660
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Migrate the Railway Dockerfile variable before deploy-only
Because CI always sets DEPLOY_ONLY=true, the deployment script skips the block that writes RAILWAY_DOCKERFILE_PATH=bots/quoter-bot/Dockerfile. Existing Railway services were provisioned with the old bots/market-making/Dockerfile value, and that path is deleted in this change, so even after the credentials and service name are preserved the next deploy-only release asks Railway to build from a missing Dockerfile; update that Railway variable during the rename or run a non-deploy-only migration before relying on this workflow.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ad49660 to
e183adc
Compare
Rebase the package rename onto the latest main branch; align code, documentation, tests, configuration, workflows, and generated references with the repository's quoter terminology; preserve externally bound compatibility identifiers; and carry forward the Railway volume-permission hardening from main.
e183adc to
6afb135
Compare
|
@codex review |
Use the clarified GitHub Environment name in the production workflow and operator documentation.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Use a valid GitHub Actions job identifier and retain ignore protection for legacy secret-bearing config files.
|
@codex review |
Apply the clarified quoter-bot- prefix to Pages artifacts, deployment metadata, and concurrency keys.
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Why
The bot is now named
quoter-bot, but its repository identity still used the former name across workspace paths, package metadata, source symbols, runtime event names, configuration discovery, tests, documentation, and GitHub Pages automation. Keeping both identities would make imports, operator commands, and deployment maintenance ambiguous.What changed
bots/market-makingtobots/quoter-bot, including nested component files and tests.@morpho-org/quoter-botand updated workspace lockfile/configuration references.quoter-bot.Quoter botwording.mainRailway volume-permission hardening under the renamedquoter-botpath, including root-owned volume preparation followed by privilege dropping.Naming audit
A full tracked-tree, case-insensitive scan of old
market-makingidentity variants found zero actionable remnants and zero stale path names. Every remaining match is an intentional external compatibility exception:market-making.yaml/market-making.yml(retained to prevent secret-bearing upgrade leftovers from becoming accidentally trackable).market-making-bot-628e80069e52.Market Maker.No workflow filename, package identifier, source symbol, runtime message, or other repository-owned identity remains under the former name.
Verification
pnpm --filter @morpho-org/quoter-bot run playground:serve:test— passed, 55/55 tests.pnpm run lint— passed with 0 warnings and 0 errors, including the playground smoke lint.pnpm --filter @morpho-org/quoter-bot run typecheck— passed.pnpm --filter @morpho-org/quoter-bot run jsdoc:build— passed (405 declarations; HTML generated).pnpm format— passed with no resulting diff.git diff --check— passed.pnpm testafterpnpm buildreached 1,667 passing and 2 skipped tests; the only 3 failing fork suites require unavailableRPC_URL_8453. The same 3 suites fail for the same missing environment variable on clean currentmain.Requested by: @julien (Slack)