feat(midnight-crossed-books): add readonly mode - #152
feat(midnight-crossed-books): add readonly mode#152prd-carapulse[bot] wants to merge 16 commits into
Conversation
Co-authored-by: Julien Thomas <61523188+julien-devatom@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-authored-by: Julien Thomas <61523188+julien-devatom@users.noreply.github.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e19cbbaef9
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
Co-authored-by: Julien Thomas <61523188+julien-devatom@users.noreply.github.com>
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d211480caa
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: 鈩癸笍 About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 馃憤. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Co-authored-by: Julien Thomas <61523188+julien-devatom@users.noreply.github.com>
Co-authored-by: Julien Thomas <61523188+julien-devatom@users.noreply.github.com>
Co-authored-by: Julien Thomas <61523188+julien-devatom@users.noreply.github.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: 鈩癸笍 About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 馃憤. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Co-authored-by: Julien Thomas <61523188+julien-devatom@users.noreply.github.com>
Co-authored-by: Julien Thomas <61523188+julien-devatom@users.noreply.github.com>
|
@codex review |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9f2c9c535
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
Remove the unsupported project flag from Railway variable set commands and cover both public and stdin-backed variable writes.
|
@codex review |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4fbfe77aa
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Use supported Railway deletion paths, preserve idempotent CLI reruns, and pass explicit project context.
|
@codex review |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91efac1a69
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9a13e928a
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90e8d32252
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f6fbb0134
鈩癸笍 About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: 鈩癸笍 About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 馃憤. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Why
Operators need a safe observation mode for the crossed-books resolver that can identify and simulate profitable resolutions without loading signing authority or broadcasting transactions.
What changed
READONLY=true/1runtime configuration; absent/false/0retain write mode and malformed values are rejected.RESOLVER_PRIVATE_KEYin readonly mode while retaining the named write-mode key invariant.SIMULATION_CALLER_ADDRESSfor keyless, execution-equivalentmsg.senderand profit-transfer simulation.match.computedwithout submission.READONLY: readonly removes a stale private key; write mode removes a stale simulation caller.railway variable list --jsonmode detection with Railway's paginated key-only metadata and an explicitly project/environment/service/name-scopedvariableDeletemutation.Verification
variable deletedoes not support--skip-deploys; current deletion uses no CLI delete command.variable setdoes support and retains--skip-deploys.pnpm exec vitest run --project midnight-crossed-books(101 passed).pnpm --filter @morpho-org/midnight-crossed-books run typecheck(passed).pnpm --filter @morpho-org/midnight-crossed-books run build(passed).pnpm lint(0 warnings, 0 errors).pnpm format(passed; only intended files changed).pnpm knip(passed).pnpm --filter @morpho-org/quoter-bot run jsdoc:build(passed; 408 declarations, HTML generated).pnpm testreached 1,719 passing / 2 skipped locally; three unrelated fork suites require unavailableRPC_URL_8453, so current-head CI is authoritative for the full workspace.git diff --checkand added-line secret-pattern scan passed.Requested by: <@U02N5KRFDB9> | Julien Thomas