Repository navigation
Fix build warnings - #440
Merged
Merged
Conversation
- lib build now builds @react-avatar-editor/core first so vite-plugin-dts can resolve its types (TS2307/TS2339 errors during declaration build). Emitted index.d.ts is unchanged. - remove .npmrc: enable-pre-post-scripts=true is pnpm's default and made npm print 'Unknown project config' on every command. - demo:build no longer builds the lib twice.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
react-avatar-editor | d46e65c | Commit Preview URL Branch Preview URL |
Sep 30 2026, 12:23 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsconfig.build.jsonmaps@react-avatar-editor/coreto../core/dist/index.d.ts, which only exists if core was built. Nothing built it, so the dts step logged TS2307/TS2339 errors (output happened to be fine). Lib'sbuildnow builds core first. Emitteddist/index.d.tsis byte-identical to 15.2.0..npmrc: only setenable-pre-post-scripts=true(pnpm default); npm warned about it on every command. Removed.demo:build: filterreact-avatar-editor*rebuilt the lib a second time; now only builds the demo afterpnpm build.Verified: clean build with no errors, lint, fmt:check, core (84) and lib (46) unit tests.