Repository navigation
fix(mcp): migrate from rmcp's deprecated ServerInfo to ServerConfig - #1229
Merged
Merged
Conversation
rmcp 3.4.0 added `ServerConfig` and deprecated the `ServerInfo` alias, whose name collided with the protocol's `serverInfo` field. Dependabot's #1226 moves rmcp from 3.2.0 to 3.4.1, and `cargo clippy -- -D warnings` then rejects `LaurusMcpServer::get_info`. Both aliases name `InitializeResult`, so the rename does not change behavior. `ServerConfig` does not exist before 3.4.0, so raise the workspace requirement to 3.4.1 and update the lock file to match. Closes #1228
mosuka
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks Dependabot PR #1226, whose
Clippyjob fails after it moves rmcp from 3.2.0 to 3.4.1.rmcp 3.4.0 added
ServerConfigand deprecated theServerInfoalias (modelcontextprotocol/rust-sdk#1266, #1156).LaurusMcpServer::get_infostill usedServerInfo, socargo clippy -- -D warningsrejects it.Test Allon #1226 fails only because it aggregates the required jobs; all test jobs pass there.Changes
laurus-mcp/src/server.rsServerInfo→ServerConfiginget_infoCargo.tomlrmcprequirement3.1.2→3.4.1(ServerConfigdoes not exist before 3.4.0)Cargo.lockrmcp/rmcp-macros3.2.0→3.4.1; no other packages changeBoth aliases name
InitializeResult, so behavior does not change. The fix is a separate PR rather than a commit on the Dependabot branch, so Dependabot keeps managing #1226. After this merges, Dependabot rebases #1226 and rmcp drops out of the group.Verification
cargo clippy -p laurus-mcp --all-targets -- -D warnings: passes.server.rsand rmcp 3.4.1 reproduces chore(deps): bump the cargo-minor-patch group across 1 directory with 13 updates #1226's two errors (server.rs:1051:27,1052:9).cargo test -p laurus-mcp: 26 passed.cargo fmt --all -- --check: clean.Closes #1228
Refs #1226