Skip to content

Bug 2055331 - Report reason in unenrollment telemetry#7480

Merged
freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-ykvzxlknkskw
Jul 16, 2026
Merged

Bug 2055331 - Report reason in unenrollment telemetry#7480
freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-ykvzxlknkskw

Conversation

@freshstrangemusic

Copy link
Copy Markdown
Member

The nimbsus_events.unenrollment metric is supposed to contain the reason field, but it just hasn't been reported.

Additionally, this removes "is_rollout" field from the nimbus_events.enrollment metric as (a) that data is not already reported, (b) the data is not already available on the EnrollmentChangeEvent (and adding it would be a breaking change), and (c) the field is not all that useful.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-ykvzxlknkskw branch from a1a4421 to b1926d1 Compare July 16, 2026 14:26
Comment thread components/nimbus/metrics.yaml Outdated
@freshstrangemusic

Copy link
Copy Markdown
Member Author

Data review is not necessary since this is only metric field removal

@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-ykvzxlknkskw branch from b1926d1 to 97045a4 Compare July 16, 2026 17:57
@freshstrangemusic
freshstrangemusic added this pull request to the merge queue Jul 16, 2026
@freshstrangemusic
freshstrangemusic removed this pull request from the merge queue due to a manual request Jul 16, 2026
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-ykvzxlknkskw branch from 97045a4 to fa6e86a Compare July 16, 2026 21:10
The `nimbsus_events.unenrollment` metric is supposed to contain the
reason field, but it just hasn't been reported.

Additionally, this removes "is_rollout" field from the
`nimbus_events.enrollment` metric as (a) that data is not already
reported, (b) the data is not already available on the
`EnrollmentChangeEvent` (and adding it would be a breaking change), and
(c) the field is not all that useful.
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-ykvzxlknkskw branch from fa6e86a to f724dd5 Compare July 16, 2026 21:13
@freshstrangemusic
freshstrangemusic added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit d21832c Jul 16, 2026
14 checks passed
@freshstrangemusic
freshstrangemusic deleted the freshstrangemusic/push-ykvzxlknkskw branch July 16, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants