[draft/wip] Fxa 13142 pt 2 - #21116
Draft
nshirley wants to merge 1 commit into
Draft
Conversation
Because: * A passkey needs somewhere to store the envelope that unlocks kB without a password. * Gating the write on a verification proof rather than the MFA scope avoids exposing one capability at two auth levels. This commit: * Adds POST /passkey/keys behind the passwordless sync flag, with exact-width validation for the five envelope fields. * Spends the proof after every other check, so a rejected payload costs the user no extra device prompt. * Returns 201 on insert, 200 on an identical repeat, 409 on a different one. * Checks only that the credential exists and is owned; `prfEnabled` is a best-guess column and no basis for refusing a verified write. * Lets recordSecurityEvent carry additionalInfo, so a new failure reason needs no new event name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.