chore(customs): add a build-fast target so yarn start mza skips tsc - #21119
Closed
vbudhram wants to merge 1 commit into
Closed
chore(customs): add a build-fast target so yarn start mza skips tsc#21119vbudhram wants to merge 1 commit into
vbudhram wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in no-op fast-build target so yarn start mza includes the JavaScript-based Customs server without TypeScript compilation.
Changes:
- Adds the
build-fastpackage script. - Remains dependent on stacked PR #21118.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vbudhram
added a commit
that referenced
this pull request
Aug 27, 2026
Because: * Copilot code review picks skills with review-focused names in .github/skills; fxa-risk-score was read as a file, never as guidance. * Two reviews on #21118 and #21119 confirmed the miss. This commit: * Renames the directory and skill name to code-review. * Reframes the description around reviewing a pull request.
vbudhram
force-pushed
the
customs-build-fast
branch
from
August 27, 2026 20:30
d2c83e3 to
530c005
Compare
Because: * build-fast is opt-in per project and customs-server never defined one. * Nx only builds a dependency that declares the target, so it was skipped. This commit: * Adds a no-op build-fast script, matching the pattern in pm2-all.sh.
vbudhram
force-pushed
the
customs-build-fast
branch
from
August 27, 2026 20:30
530c005 to
103dcc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #21118 so the head branch carries
.github/skills/fxa-risk-scorewhile the diff is ordinary code.Why
build-fastis opt-in per project. Nx's^build-fastedge only builds a dependency that declares the target and never falls back tobuild, sofxa-customs-serverwas skipped byyarn start mza. It has nobuildscript to skip, so the target is a no-op.Test plan
yarn start mzareaches customs-server without a tsc step.Draft, and partly a probe: checking whether Copilot code review picks up the agent skill from the head branch when the diff is not the skill itself. Do not merge before #21118.