Speed up FuzzyJobFinder - #9719
Draft
jcristau wants to merge 1 commit into
Draft
Conversation
Memoize the job list and fuse index, don't sort on every render, and use a set instead of an array to test inclusion. And more importantly, cap the number of displayed task labels: each one is an <option> DOM node and rendering tens of thousands takes forever, freezing the UI. Users can use the search box to narrow down the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memoize the job list and fuse index, don't sort on every render, and use a set instead of an array to test inclusion.
And more importantly, cap the number of displayed task labels: each one is an DOM node and rendering tens of thousands takes forever, freezing the UI. Users can use the search box to narrow down the list.