Skip to content

fix(sandcastle): Pin the structured-output roles and scope the review:claude rule - #445

Merged
mpaulosky merged 3 commits into
mainfrom
fix/440-pin-role-agents
Oct 26, 2026
Merged

mpaulosky merged 3 commits into
mainfrom
fix/440-pin-role-agents

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Why

Closes #440, the two Advisory findings the local review left on the Sandcastle migration (#441).

What changed

  • R14: .sandcastle/lib/repo-config.test.mts pins maxIterations 1 for intake, planner, critique, reviewer, gate-fixer and follow-up (a mutation of follow-up to 2 fails it). intake, planner and critique use structured output (Output.object); the other three are single-shot by design, and the test's comment says so. The other roles' values stay free to move.
  • R15: CLAUDE.md no longer contradicts docs/PROCESS.md: "don't add review:claude yourself, except where docs/PROCESS.md says to (a push that needs a new review, or one more review past the cap)".

Verification

  • scripts/gate.sh passes.
  • Local /pre-push-review: 2 rounds; one Advisory finding (the test comment claimed structured output for all six roles), fixed; nothing open.
  • dotfiles' own CLAUDE.md has the same sentence; it is not changed here.

🤖 Generated with Claude Code

mpaulosky and others added 3 commits October 26, 2026 15:02
Refs #440 (R14).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Refs #440 (R15).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@mpaulosky mpaulosky added the review:claude Claude reviews each head, a backup to Copilot's review label Oct 26, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Review

Overview

This PR adds a test that pins six ROLE_AGENTS roles to maxIterations === 1. It also lets CLAUDE.md make an exception to its "don't add review:claude yourself" rule. I found no blocking problems, but I could only partly check the test's inputs (see Advisory).

Changes

File What changed
.sandcastle/lib/repo-config.test.mts Imports ROLE_AGENTS and adds a ROLE_AGENTS suite. For intake, planner, critique, reviewer, gate-fixer and follow-up, one generated test each asserts maxIterations is 1.
CLAUDE.md The sentence "don't add it yourself" now ends "except where docs/PROCESS.md says to (a push that needs a new review, or one more review past the cap)".

Advisory (not blocking)

  • .sandcastle/lib/repo-config.mts wasn't in the context pieces, so I couldn't confirm it exports ROLE_AGENTS, keys it by those six role names, and gives each entry a numeric maxIterations. A mismatch would fail pnpm run check:sandcastle (type-check or test), and the local gate catches that.
  • CLAUDE.md now points at docs/PROCESS.md for when to add review:claude by hand. I couldn't read docs/PROCESS.md, so confirm it describes both cases (a push that needs a new review, and one more review past the cap).
  • .sandcastle/check.sh says main.test.mts reads CLAUDE.md. If that test matches the old wording of the label sentence, it would fail. I couldn't read it to check.
  • Each role is checked in its own it, and a role missing from ROLE_AGENTS would fail with a TypeError rather than a clear message. This is a minor readability point.

No findings.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results Summary

660 tests  ±0   660 ✅ ±0   50s ⏱️ -4s
  6 suites ±0     0 💤 ±0 
  6 files   ±0     0 ❌ ±0 

Results for commit 99c7ab6. ± Comparison against base commit 9d0dfca.

@mpaulosky
mpaulosky merged commit b61e268 into main Oct 26, 2026
32 checks passed
@mpaulosky
mpaulosky deleted the fix/440-pin-role-agents branch October 26, 2026 22:15
mpaulosky added a commit that referenced this pull request Oct 26, 2026
Automated release blog posts for #445, opened by the release workflow.
It holds every Release whose post isn't on main yet, rebuilt from main
on each run. The [skip-release] title marker keeps its merge from
starting another release.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.65%. Comparing base (9d0dfca) to head (99c7ab6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files          42       42           
  Lines         568      568           
  Branches      100      100           
=======================================
  Hits          549      549           
  Misses          5        5           
  Partials       14       14           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:claude Claude reviews each head, a backup to Copilot's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(review): Advisory review findings: chore/migrate-sandcastle-to-baseline

1 participant